[asterisk-dev] Change in asterisk[master]: res_pjsip: Add external PJSIP resolver implementation using ...

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: res_pjsip: Add external PJSIP resolver implementation using core DNS API. .. Patch Set 1: (3 comments)

[asterisk-dev] Change in asterisk[1.8]: .gitignore: Ignore tarballs (*.gz)

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/86 To unsubscribe, visit

[asterisk-dev] Change in asterisk[12]: .gitignore: Ignore tarballs (*.gz)

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: .gitignore: Ignore tarballs (*.gz) .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/85 To unsubscribe, visit

[asterisk-dev] Change in asterisk[1.8]: .gitignore: Ignore tarballs (*.gz)

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz

[asterisk-dev] Change in asterisk[1.8]: Add .gitignore and .gitreview files

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/82 To unsubscribe, visit

[asterisk-dev] Change in asterisk[1.8]: Add .gitignore and .gitreview files

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can

[asterisk-dev] Change in asterisk[1.8]: main/editline: Add .gitignore.

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results.

[asterisk-dev] Change in asterisk[1.8]: main/editline: Add .gitignore.

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/84 To unsubscribe, visit

[asterisk-dev] Change in asterisk[12]: main/editline: Add .gitignore.

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: main/editline: Add .gitignore. .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/83 To unsubscribe, visit

[asterisk-dev] Change in asterisk[12]: main/editline: Add .gitignore.

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: main/editline: Add .gitignore. .. main/editline: Add .gitignore. This patch adds a .gitignore for main/editline to ignore all build results.

[asterisk-dev] Change in asterisk[12]: Add .gitignore and .gitreview files

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview files .. Add .gitignore and .gitreview files Add the .gitignore and .gitreview files to the asterisk repo. NB: You can

[asterisk-dev] Change in asterisk[12]: Add .gitignore and .gitreview files

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Add .gitignore and .gitreview files .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/81 To unsubscribe, visit

[asterisk-dev] Change in repotools[master]: mapmantis: Remove dependency on digium_jira

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: mapmantis: Remove dependency on digium_jira .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/68 To unsubscribe, visit

[asterisk-dev] Change in repotools[master]: digium_jira: Refactor module to wrap the Atlassian JIRA REST...

2015-04-13 Thread Mark Michelson (Code Review)
Hello Jared K. Smith, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/69 to look at the new patch set (#2). Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST client

[asterisk-dev] Change in asterisk[master]: Fixing extconf compile

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: Fixing extconf compile .. Fixing extconf compile During the mass code deletion for clang support, a stray backslash was left behind that was causing

[asterisk-dev] Change in asterisk[13]: Fixing extconf compile

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: Fixing extconf compile .. Fixing extconf compile During the mass code deletion for clang support, a stray backslash was left behind that was causing

[asterisk-dev] Change in asterisk[11]: Fixing extconf compile

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: Fixing extconf compile .. Fixing extconf compile During the mass code deletion for clang support, a stray backslash was left behind that was causing

[asterisk-dev] Change in asterisk[master]: Fixing extconf compile

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Fixing extconf compile .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/90 To unsubscribe, visit

[asterisk-dev] Change in asterisk[13]: Fixing extconf compile

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Fixing extconf compile .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/89 To unsubscribe, visit

[asterisk-dev] Change in asterisk[11]: Fixing extconf compile

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Fixing extconf compile .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/88 To unsubscribe, visit

[asterisk-dev] Change in asterisk[12]: .gitignore: Ignore tarballs (*.gz)

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: .gitignore: Ignore tarballs (*.gz) .. .gitignore: Ignore tarballs (*.gz) This patch updates the root .gitignore file to ignore files with a .gz

[asterisk-dev] Change in repotools[master]: digium_jira: Refactor module to wrap the Atlassian JIRA REST...

2015-04-13 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: digium_jira: Refactor module to wrap the Atlassian JIRA REST client .. Patch Set 2: (2 comments) https://gerrit.asterisk.org/#/c/69/2/digium_jira.py File

[asterisk-dev] Change in testsuite[master]: rest_api/applications/stasisstatus: Make run-test executable

2015-04-09 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: rest_api/applications/stasisstatus: Make run-test executable .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/36 To

[asterisk-dev] Change in testsuite[master]: rest_api/applications/stasisstatus: Make run-test executable

2015-04-09 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: rest_api/applications/stasisstatus: Make run-test executable .. rest_api/applications/stasisstatus: Make run-test executable If it isn't executable,

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.asterisk.org/18 To unsubscribe, visit

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.asterisk.org/18 To unsubscribe,

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: -Verified Removing the Verified since there are still outstanding findings. --

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 5: Code-Review+1 (2 comments) It's looking good by me!

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 10: Code-Review+2 Verified+1 -- To view, visit https://gerrit.asterisk.org/18 To

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-08 Thread Mark Michelson (Code Review)
Mark Michelson has submitted this change and it was merged. Change subject: stasis: set a channel variable on websocket disconnect error .. stasis: set a channel variable on websocket disconnect error This test is to ensure

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

2015-04-07 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new patch set (#3). Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. sip_attended_transfer now supports pre-12 Asterisk versions. The sip_attended transfer test was

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

2015-04-07 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new patch set (#3). Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. sip_attended_transfer now supports pre-12 Asterisk versions. The sip_attended transfer test was

[asterisk-dev] Change in testsuite[master]: Enable support for directory containing custom tests.

2015-04-07 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Enable support for directory containing custom tests. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/27 To unsubscribe, visit

[asterisk-dev] Change in testsuite[master]: Testsuite: New test for FAX via PJSIP T38 with authentication

2015-04-07 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.asterisk.org/28 To unsubscribe,

[asterisk-dev] Change in testsuite[master]: Add SIP attended transfer for Asterisk 11.

2015-04-03 Thread Mark Michelson (Code Review)
Mark Michelson has abandoned this change. Change subject: Add SIP attended transfer for Asterisk 11. .. Abandoned -- To view, visit https://gerrit.asterisk.org/20 To unsubscribe, visit https://gerrit.asterisk.org/settings

[asterisk-dev] Change in testsuite[master]: Add SIP attended transfer for Asterisk 11.

2015-04-03 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Add SIP attended transfer for Asterisk 11. .. Patch Set 1: I am abandoning this change in favor of change /c/29/ -- To view, visit

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

2015-04-03 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. Patch Set 1: (1 comment)

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

2015-04-03 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new change for review. https://gerrit.asterisk.org/29 Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. sip_attended_transfer now supports pre-12 Asterisk versions.

[asterisk-dev] Change in testsuite[master]: sip_attended_transfer now supports pre-12 Asterisk versions.

2015-04-03 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new patch set (#2). Change subject: sip_attended_transfer now supports pre-12 Asterisk versions. .. sip_attended_transfer now supports pre-12 Asterisk versions. The sip_attended transfer test was

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-04-01 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: Code-Review+1 (4 comments) I noticed that I gave the Code-Review a 0 last time. I

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

2015-04-01 Thread Mark Michelson (Code Review)
Hello Ashley Sanders, I'd like you to reexamine a change. Please visit https://gerrit.asterisk.org/19 to look at the new patch set (#3). Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

2015-04-01 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new patch set (#3). Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite sip_attended_transfer test to stop failing. The sip_attended_transfer test has been bouncing for a

[asterisk-dev] Change in testsuite[master]: rest_api/channels/snoop_spy: Stop test on bridge destruction

2015-04-01 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: rest_api/channels/snoop_spy: Stop test on bridge destruction .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/21 To unsubscribe,

[asterisk-dev] Change in testsuite[master]: stasis: set a channel variable on websocket disconnect error

2015-03-31 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: stasis: set a channel variable on websocket disconnect error .. Patch Set 1: (10 comments)

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

2015-03-31 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Rewrite sip_attended_transfer test to stop failing. .. Patch Set 2: (6 comments) Thanks for the review!

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

2015-03-30 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new patch set (#2). Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite sip_attended_transfer test to stop failing. The sip_attended_transfer test has been bouncing for a

[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

2015-03-30 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new change for review. https://gerrit.asterisk.org/19 Change subject: Rewrite sip_attended_transfer test to stop failing. .. Rewrite sip_attended_transfer test to stop failing. The

[asterisk-dev] Change in testsuite[master]: Add SIP attended transfer for Asterisk 11.

2015-03-30 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new change for review. https://gerrit.asterisk.org/20 Change subject: Add SIP attended transfer for Asterisk 11. .. Add SIP attended transfer for Asterisk 11. The structure of this is similar to

[asterisk-dev] Change in testsuite[master]: PJSIP: Added test to ensure retransmissions are not handled.

2015-03-27 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new patch set (#2). Change subject: PJSIP: Added test to ensure retransmissions are not handled. .. PJSIP: Added test to ensure retransmissions are not handled. In this test, a SIPp scenario sends

[asterisk-dev] Change in testsuite[master]: PJSIP: Added test to ensure retransmissions are not handled.

2015-03-27 Thread Mark Michelson (Code Review)
Mark Michelson has uploaded a new patch set (#2). Change subject: PJSIP: Added test to ensure retransmissions are not handled. .. PJSIP: Added test to ensure retransmissions are not handled. In this test, a SIPp scenario sends

[asterisk-dev] Change in repotools[master]: Add web proxy support to commit_msg.py

2015-03-27 Thread Mark Michelson (Code Review)
Mark Michelson has posted comments on this change. Change subject: Add web proxy support to commit_msg.py .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.asterisk.org/13 To unsubscribe, visit