Re: [asterisk-dev] CentOS 6 and Ubuntu 12 Testing Support

2017-04-12 Thread Scott Griepentrog
After testing with CentOS 6.8, I agree that it has become difficult to continue supporting it. On Wed, Apr 12, 2017 at 9:27 AM, George Joseph <gjos...@digium.com> wrote: > > > On Wed, Apr 12, 2017 at 7:22 AM, Scott Griepentrog < > sgriepent...@digium.com> wrote: > &

Re: [asterisk-dev] CentOS 6 and Ubuntu 12 Testing Support

2017-04-12 Thread Scott Griepentrog
r Software Developer > 445 Jan Davis Drive NW - Huntsville, AL 35806 - US > Check us out at: www.digium.com & www.asterisk.org > > -- > _ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or upda

Re: [asterisk-dev] BuildSystem: make --jobs without amount of thread hangs

2016-06-09 Thread Scott Griepentrog
: > http://lists.digium.com/mailman/listinfo/asterisk-dev > -- [image: Digium logo] Scott Griepentrog Digium, Inc · Software Developer 445 Jan Davis Drive NW · Huntsville, AL 35806 · US direct/fax: +1 256 4

Re: [asterisk-dev] BuildSystem: make --jobs without amount of thread hangs

2016-06-08 Thread Scott Griepentrog
> this issue on JIRA, so that someone else looks into this one day? > > > -- > _ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > > asterisk-dev mailing list > To UNSUBSCRIBE or update options visit: >http://lists.digium.com/mail

Re: [asterisk-dev] ast_safe_system() from within chan_sip.c

2016-02-22 Thread Scott Griepentrog
; > > > Este correo electrónico se ha enviado desde un equipo libre de virus y > protegido por Avast. > www.avast.com <https://www.avast.com/sig-email> > > -- > _ > -- Bandwidth and Colocation Provided by http://www.api-digital.com -- > &g

Re: [asterisk-dev] asterisk 11.18.0-rc1 Now Available

2015-05-22 Thread Scott Griepentrog
://lists.digium.com/mailman/listinfo/asterisk-dev -- [image: Digium logo] Scott Griepentrog Digium, Inc · Software Developer 445 Jan Davis Drive NW · Huntsville, AL 35806 · US direct/fax: +1 256 428 6239 · mobile: +1 256 580 6090 Check us out at: http://digium.com · http://asterisk.org

Re: [asterisk-dev] asterisk 11.18.0-rc1 Now Available

2015-05-22 Thread Scott Griepentrog
On 2015-05-22 15:08, Scott Griepentrog wrote: ​Although I would recommend switching to git instead, it is possible to use svn co on the github repository as such: svn co https://github.com/asterisk/asterisk/branches/13 [1] ​ On Fri, May 22, 2015 at 6:14 AM, Joshua Colp jc...@digium.com wrote

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Scott Griepentrog
Correction: as one will end up getting a new ID (the second one to reuse the same token). On Tue, May 12, 2015 at 1:24 PM, Scott Griepentrog sgriepent...@digium.com wrote: So as opposed to spoofing, there is also the case that someone having a copy of Asteirsk in a virtual machine clones

Re: [asterisk-dev] Asterisk Beacon Module Proposal

2015-05-12 Thread Scott Griepentrog
-- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev -- [image: Digium logo] Scott Griepentrog Digium, Inc · Software

Re: [asterisk-dev] Review Request: Sorcery Caching

2015-05-04 Thread Scott Griepentrog
-- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev -- [image: Digium logo] Scott Griepentrog Digium, Inc · Software Developer 445 Jan Davis Drive NW · Huntsville, AL 35806 · US direct/fax: +1 256 428 6239 · mobile: +1 256

Re: [asterisk-dev] Review Request: Sorcery Caching

2015-04-28 Thread Scott Griepentrog
or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev -- [image: Digium logo] Scott Griepentrog Digium, Inc · Software Developer 445 Jan Davis Drive NW · Huntsville, AL 35806 · US direct/fax: +1 256 428 6239 · mobile: +1 256 580 6090 Check us out at: http://digium.com

Re: [asterisk-dev] [Code Review] 4595: Voicemail API: fix handling of mailbox full condition

2015-04-07 Thread Scott Griepentrog
the message in the Inbox without deleting it. Diffs - /branches/11/apps/app_voicemail.c 434135 Diff: https://reviewboard.asterisk.org/r/4595/diff/ Testing --- Tested manually on my system under Asterisk 13. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4574: pjsip: resolve compatibility problem with ast_sip_session struct

2015-04-02 Thread Scott Griepentrog
--- With this change, a DPMA crash has been eliminated when transmitting messages via PJSIP. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] Problems Building 13.x with GCC 5.0

2015-04-01 Thread Scott Griepentrog
-- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev -- [image: Digium logo] Scott Griepentrog Digium, Inc · Software Developer 445 Jan

Re: [asterisk-dev] [Code Review] 4574: pjsip: resolve compatibility problem with ast_sip_session struct

2015-04-01 Thread Scott Griepentrog
. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-17 Thread Scott Griepentrog
/utils.h 432661 /branches/13/build_tools/cflags.xml 432661 Diff: https://reviewboard.asterisk.org/r/4463/diff/ Testing --- I'm unable to get Asterisk to actually start with 1 in 100,000 failure rate. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-17 Thread Scott Griepentrog
--- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4497: logger: init_logger_chain has unreachable code

2015-03-17 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4497/#review14725 --- Ship it! Ship It! - Scott Griepentrog On March 14, 2015, 4

Re: [asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-10 Thread Scott Griepentrog
432661 /branches/13/main/config.c 432661 /branches/13/main/codec_builtin.c 432661 /branches/13/main/asterisk.c 432661 /branches/13/include/asterisk/config.h 432661 Diff: https://reviewboard.asterisk.org/r/4468/diff/ Testing --- Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Scott Griepentrog
--- On March 7, 2015, 12:01 a.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4463

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Scott Griepentrog
--- On March 7, 2015, 12:01 a.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4463

Re: [asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-09 Thread Scott Griepentrog
/branches/13/main/asterisk.c 432661 Diff: https://reviewboard.asterisk.org/r/4468/diff/ Testing --- Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

[asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-09 Thread Scott Griepentrog
432661 /branches/13/main/utils.c 432661 /branches/13/main/endpoints.c 432661 /branches/13/main/config.c 432661 /branches/13/main/codec_builtin.c 432661 /branches/13/main/asterisk.c 432661 Diff: https://reviewboard.asterisk.org/r/4468/diff/ Testing --- Thanks, Scott Griepentrog

[asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-06 Thread Scott Griepentrog
/ Testing --- I'm unable to get Asterisk to actually start with 1 in 100,000 failure rate. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-06 Thread Scott Griepentrog
432613 /branches/13/include/asterisk/utils.h 432613 /branches/13/build_tools/cflags.xml 432613 Diff: https://reviewboard.asterisk.org/r/4463/diff/ Testing --- I'm unable to get Asterisk to actually start with 1 in 100,000 failure rate. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-03-04 Thread Scott Griepentrog
as they have 400ms OFF periods. Effectively, the other DR patterns are signalled as one continuous ring due to use of only 200ms OFF. Since the distictive ring detection issues I'm encountering are not the fault of chan_dahdi, sig_analog, or these improvements, I'm good with this. - Scott

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-02-27 Thread Scott Griepentrog
On Feb. 27, 2015, 9:39 a.m., Scott Griepentrog wrote: I updated the chan_dahdi [channels] configuration with cadences matching the Bellcore spec and retested for both CID detection and DR pattern recognition. Results are certain patterns (especially DR2, DR4, and DR5) exhibit

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-02-27 Thread Scott Griepentrog
. There may be leftover artifacts on CID detection between calls, as repeating a failed call tends to correlate to another failure. - Scott Griepentrog On Feb. 23, 2015, 6:51 p.m., rmudgett wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-02-27 Thread Scott Griepentrog
On Feb. 27, 2015, 9:39 a.m., Scott Griepentrog wrote: I updated the chan_dahdi [channels] configuration with cadences matching the Bellcore spec and retested for both CID detection and DR pattern recognition. Results are certain patterns (especially DR2, DR4, and DR5) exhibit

Re: [asterisk-dev] [Code Review] 4443: dial api: add self destruction option

2015-02-26 Thread Scott Griepentrog
: https://reviewboard.asterisk.org/r/4443/diff/ Testing --- Correct operation confirmed with a temporary test function running under valgrind to insure there are no invalid references or leaks. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4444: chan_dahdi/sig_analog: Fix distinctive ring detection to suck less.

2015-02-24 Thread Scott Griepentrog
and confirmed to resolve CID detection problem. Ran out of time to validate DR detection, will attempt later. - Scott Griepentrog On Feb. 23, 2015, 6:51 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply

Re: [asterisk-dev] [Code Review] 4407: cleanup various issues discovered during leak testing

2015-02-06 Thread Scott Griepentrog
/main/utils.c 431571 /branches/13/main/config.c 431571 Diff: https://reviewboard.asterisk.org/r/4407/diff/ Testing --- In each case Valgrind did not show the same error again after the patch was added. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4141: Enable REF_DEBUG for ast_module_ref / ast_module_unref

2015-02-06 Thread Scott Griepentrog
https://reviewboard.asterisk.org/r/4141/#comment24954 red blob - Scott Griepentrog On Feb. 5, 2015, 2:36 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

Re: [asterisk-dev] [Code Review] 4407: cleanup various issues discovered during leak testing

2015-02-06 Thread Scott Griepentrog
/main/config.c 431571 Diff: https://reviewboard.asterisk.org/r/4407/diff/ Testing --- In each case Valgrind did not show the same error again after the patch was added. Thanks, Scott Griepentrog -- _ -- Bandwidth

[asterisk-dev] [Code Review] 4407: cleanup various issues discovered during leak testing

2015-02-05 Thread Scott Griepentrog
Valgrind did not show the same error again after the patch was added. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-01-30 Thread Scott Griepentrog
both the explicit extension conflict cases i.e. 200 vs 200 and the wildcard _2XX vs 200. - Scott Griepentrog On Jan. 27, 2015, 8:23 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4141: Enable REF_DEBUG for ast_module_ref / ast_module_unref

2015-01-30 Thread Scott Griepentrog
/4141/#comment24892 I would recommend using a variable name such as ref_debug to better describe it's purpose. - Scott Griepentrog On Nov. 2, 2014, 1:13 a.m., Corey Farrell wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-29 Thread Scott Griepentrog
: https://reviewboard.asterisk.org/r/4382/diff/ Testing --- Running tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app now does not result in an occasional failure. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-29 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4382/#review14347 --- On Jan. 29, 2015, 11:20 a.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-29 Thread Scott Griepentrog
/branches/13/include/asterisk/bridge.h 431296 Diff: https://reviewboard.asterisk.org/r/4382/diff/ Testing --- Running tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app now does not result in an occasional failure. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-28 Thread Scott Griepentrog
in an occasional failure. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-28 Thread Scott Griepentrog
://reviewboard.asterisk.org/r/4382/#review14341 --- On Jan. 27, 2015, 8:55 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-28 Thread Scott Griepentrog
/external_interaction/attended_transfer/stasis_bridge_to_stasis_app now does not result in an occasional failure. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

[asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup up swap channel

2015-01-27 Thread Scott Griepentrog
/ Testing --- Running tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app now does not result in an occasional failure. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-27 Thread Scott Griepentrog
in an occasional failure. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4382: stasis bridge: handle early hangup of swap channel

2015-01-27 Thread Scott Griepentrog
/include/asterisk/bridge.h 431242 Diff: https://reviewboard.asterisk.org/r/4382/diff/ Testing --- Running tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_app now does not result in an occasional failure. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread Scott Griepentrog
://reviewboard.asterisk.org/r/4372/#comment24772 Use ast_copy_string? - Scott Griepentrog On Jan. 26, 2015, 10:28 a.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org

Re: [asterisk-dev] [Code Review] 4341: stasis transfers: fix race condition on set replace channel

2015-01-22 Thread Scott Griepentrog
/branches/13/res/stasis/app.c 430394 Diff: https://reviewboard.asterisk.org/r/4341/diff/ Testing --- The stasis start/end tests that discovered the issue are now passing, and I've not found any other test failures. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4341: stasis transfers: fix race condition on set replace channel

2015-01-20 Thread Scott Griepentrog
/13/res/stasis/app.c 430394 Diff: https://reviewboard.asterisk.org/r/4341/diff/ Testing --- The stasis start/end tests that discovered the issue are now passing, and I've not found any other test failures. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4341: stasis transfers: fix race condition on set replace channel

2015-01-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4341/#review14214 --- On Jan. 16, 2015, 3:58 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 4341: stasis transfers: fix race condition on set replace channel

2015-01-16 Thread Scott Griepentrog
430394 Diff: https://reviewboard.asterisk.org/r/4341/diff/ Testing --- The stasis start/end tests that discovered the issue are now passing, and I've not found any other test failures. Thanks, Scott Griepentrog

[asterisk-dev] [Code Review] 4341: stasis transfers: fix race condition on set replace channel

2015-01-15 Thread Scott Griepentrog
that discovered the issue are now passing, and I've not found any other test failures. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 4322: app_bridge: return to next dialplan priority

2015-01-09 Thread Scott Griepentrog
the bridge_baseline and other bridge tests to insure they passed. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-09 Thread Scott Griepentrog
/python/asterisk/channel_test_condition.py 6149 Diff: https://reviewboard.asterisk.org/r/4256/diff/ Testing --- Currently fails while ASTERISK-24513 is not yet patched. Thanks, Scott Griepentrog -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2015-01-09 Thread Scott Griepentrog
://reviewboard.asterisk.org/r/4280/diff/ Testing --- Ran on config files from various sources to insure no exceptions occurred. Perused output to confirm appearance of converted input values. Thanks, Scott Griepentrog -- _ -- Bandwidth

[asterisk-dev] [Code Review] 4322: app_bridge: return to next dialplan priority

2015-01-07 Thread Scott Griepentrog
/features.c 430220 Diff: https://reviewboard.asterisk.org/r/4322/diff/ Testing --- Testsuite test that caught problem now passes. I also ran the bridge_baseline and other bridge tests to insure they passed. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2015-01-06 Thread Scott Griepentrog
On Jan. 5, 2015, 5 p.m., Scott Griepentrog wrote: Is this missing a sip.conf? It's using the bridge test case which is built on sip and includes it's own default sip.conf. Thus, I don't have to provide one in this test, and it would require changing the bridge test case, or at least

Re: [asterisk-dev] [Code Review] 4302: bridge: channel ref leak after failed blond transfer

2015-01-05 Thread Scott Griepentrog
/13/main/bridge_basic.c 430163 Diff: https://reviewboard.asterisk.org/r/4302/diff/ Testing --- Both the blond_nominal and atxfer_fail_blond (r/4256) tests pass without error. Thanks, Scott Griepentrog -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-05 Thread Scott Griepentrog
with unload and graceful shutdown. - Scott Griepentrog On Jan. 2, 2015, 1:46 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311

Re: [asterisk-dev] [Code Review] 4302: bridge: channel ref leak after failed blond transfer

2015-01-02 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4302/#review14062 --- On Jan. 2, 2015, 10:46 a.m., Scott Griepentrog wrote: --- This is an automatically

Re: [asterisk-dev] [Code Review] 4302: bridge: channel ref leak after failed blond transfer

2015-01-02 Thread Scott Griepentrog
/4256) tests pass without error. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Scott Griepentrog
., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4286/ --- (Updated Dec. 19, 2014, 2:24 p.m

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-31 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review14033 --- On Dec. 19, 2014, 7:52 a.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-31 Thread Scott Griepentrog
on config files from various sources to insure no exceptions occurred. Perused output to confirm appearance of converted input values. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2014-12-31 Thread Scott Griepentrog
/channel_test_condition.py 6149 Diff: https://reviewboard.asterisk.org/r/4256/diff/ Testing --- Currently fails while ASTERISK-24513 is not yet patched. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2014-12-31 Thread Scott Griepentrog
. To reply, visit: https://reviewboard.asterisk.org/r/4256/#review14036 --- On Dec. 31, 2014, 12:01 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Scott Griepentrog
. Diffs (updated) - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Scott Griepentrog
On Dec. 23, 2014, 7:41 a.m., Joshua Colp wrote: /trunk/main/rtp_engine.c, line 2193 https://reviewboard.asterisk.org/r/4286/diff/1/?file=69966#file69966line2193 Yeah, put this in the 96-127 rang instead. Scott Griepentrog wrote: Wouldn't that cause ast_rtp_engine_load_format

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-31 Thread Scott Griepentrog
--- Ran on config files from various sources to insure no exceptions occurred. Perused output to confirm appearance of converted input values. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-31 Thread Scott Griepentrog
this, the previous use 128 for the slin192 format has been changed to 95. Diffs - /trunk/main/rtp_engine.c 429845 Diff: https://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog

[asterisk-dev] [Code Review] 4302: bridge: channel ref leak after failed blond transfer

2014-12-30 Thread Scott Griepentrog
) tests pass without error. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-19 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review13995 --- On Dec. 19, 2014, 7:52 a.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-19 Thread Scott Griepentrog
--- Ran on config files from various sources to insure no exceptions occurred. Perused output to confirm appearance of converted input values. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4279: chan_sip: Send CANCEL via proxy if CANCEL is to be sent after an UPDATE

2014-12-19 Thread Scott Griepentrog
the same negation started on the line containing SIP_CANCEL. - Scott Griepentrog On Dec. 17, 2014, 12:11 p.m., kwemheuer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4279

Re: [asterisk-dev] [Code Review] 4262: bridge: channel ref leak on blond_nonfinal_enter

2014-12-19 Thread Scott Griepentrog
'atxfer_fail_blonde' (https://reviewboard.asterisk.org/r/4256/) now passes. No other new test failures encountered. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

[asterisk-dev] [Code Review] 4286: rtp_engine: avoid payload types above 127

2014-12-19 Thread Scott Griepentrog
://reviewboard.asterisk.org/r/4286/diff/ Testing --- Tested with pjsip calls to allow=all configured extensions. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

[asterisk-dev] [Code Review] 4280: sip_to_pjsip: improved ability to parse input without exception

2014-12-17 Thread Scott Griepentrog
to confirm appearance of converted input values. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

2014-12-17 Thread Scott Griepentrog
On Dec. 17, 2014, 11:14 a.m., Mark Michelson wrote: /trunk/rest-api/api-docs/channels.json, line 374 https://reviewboard.asterisk.org/r/4101/diff/10/?file=69813#file69813line374 Why is this change present? greenfieldtech wrote: I changed this from int to long, for

Re: [asterisk-dev] [Code Review] 4262: bridge: channel ref leak on blond_nonfinal_enter

2014-12-16 Thread Scott Griepentrog
/#review13959 --- On Dec. 12, 2014, 4:10 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4262

Re: [asterisk-dev] [Code Review] 4262: bridge: channel ref leak on blond_nonfinal_enter

2014-12-16 Thread Scott Griepentrog
/r/4256/) now passes. No other new test failures encountered. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

[asterisk-dev] [Code Review] 4262: bridge: channel ref leak on blond_nonfinal_enter

2014-12-12 Thread Scott Griepentrog
- /branches/12/main/bridge_basic.c 429516 Diff: https://reviewboard.asterisk.org/r/4262/diff/ Testing --- Newly created test 'atxfer_fail_blonde' (https://reviewboard.asterisk.org/r/4256/) now passes. No other new test failures encountered. Thanks, Scott Griepentrog

[asterisk-dev] [Code Review] 4256: testsuite: check for channel leak on failed blonde transfer

2014-12-12 Thread Scott Griepentrog
/trunk/lib/python/asterisk/bridge_test_case.py 6082 Diff: https://reviewboard.asterisk.org/r/4256/diff/ Testing --- Currently fails while ASTERISK-24513 is not yet patched. Thanks, Scott Griepentrog -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-12-09 Thread Scott Griepentrog
the end of the buffer. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify an originator when originating calls.

2014-12-08 Thread Scott Griepentrog
https://reviewboard.asterisk.org/r/4243/#comment24443 I would suggest using a slightly more descriptive name for this struct that passes arguments to the dialing thread. - Scott Griepentrog On Dec. 5, 2014, 3:27 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 4244: ari: Add originate with originator test.

2014-12-08 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4244/#review13920 --- Ship it! Ship It! - Scott Griepentrog On Dec. 5, 2014, 3

Re: [asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

2014-12-05 Thread Scott Griepentrog
from. - Scott Griepentrog On Dec. 5, 2014, 2:28 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4243

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

2014-11-18 Thread Scott Griepentrog
--- On Oct. 16, 2014, 4:23 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/ --- (Updated

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

2014-11-18 Thread Scott Griepentrog
). - Scott --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4090/#review13561 --- On Oct. 16, 2014, 4:23 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

2014-11-18 Thread Scott Griepentrog
with multiple asterisk instances Diffs - /asterisk/trunk/runtests.py 5733 /asterisk/trunk/lib/python/asterisk/test_case.py 5733 /asterisk/trunk/lib/python/asterisk/asterisk.py 5733 Diff: https://reviewboard.asterisk.org/r/4090/diff/ Testing --- Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 3496: testsuite: add valgrind support

2014-11-18 Thread Scott Griepentrog
/valgrind.supp PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3496/diff/ Testing --- Used to locate reference problems on Userevent issue, and incorporated several improvements over the prior attempt. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4090: testsuite: add basic valgrind support

2014-11-18 Thread Scott Griepentrog
On Nov. 18, 2014, 8:18 a.m., Corey Farrell wrote: Please discard my findings, they are minor. I'd like to see this committed ASAP so further improvements can be made against it. Scott Griepentrog wrote: I like your idea of adding an option to pass valgrind options, but it needs

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-11-14 Thread Scott Griepentrog
on a repeated test I was running where the atoi of the version # happen to hit the end of the buffer. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4139: stun: fix size of attribute string to match rfc

2014-11-14 Thread Scott Griepentrog
/4139/diff/ Testing --- Since I don't have an easy way to generate RTP STUN messages, I've tested the change on a separate test bed, and submitted the patch to the reporter for confirmation. Thanks, Scott Griepentrog

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-11-14 Thread Scott Griepentrog
--- On Nov. 14, 2014, 5:03 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4182

Re: [asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-11-14 Thread Scott Griepentrog
that possibility. Diffs (updated) - /branches/13/main/asterisk.c 427948 Diff: https://reviewboard.asterisk.org/r/4182/diff/ Testing --- It stopped crashing on a repeated test I was running where the atoi of the version # happen to hit the end of the buffer. Thanks, Scott Griepentrog

[asterisk-dev] [Code Review] 4182: core: avoid rasterisk crash due to long identifier

2014-11-13 Thread Scott Griepentrog
://reviewboard.asterisk.org/r/4182/diff/ Testing --- It stopped crashing on a repeated test I was running where the atoi of the version # happen to hit the end of the buffer. Thanks, Scott Griepentrog -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4101: Channel Originate/Continue via ARI support for labels in dialplan is incomplete

2014-11-06 Thread Scott Griepentrog
On Nov. 5, 2014, 11:43 a.m., Joshua Colp wrote: Matt brought it up that this is actually a backwards incompatible change - specifically changing priority into a string from an integer. What about having label as a separate argument that is optional? If present it's treated as a label

Re: [asterisk-dev] [Code Review] 4147: config: BUG: Restore ability for non-templates to be used as base objects in config.

2014-11-04 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4147/#review13667 --- Ship it! Ship It! - Scott Griepentrog On Nov. 4, 2014, 11

Re: [asterisk-dev] [Code Review] 4129: pjsip: clarify tls key file usage

2014-10-31 Thread Scott Griepentrog
--- Rebuilt with no documentation errors. Thanks, Scott Griepentrog -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 4119: pjsip: handle outbound unregister correctly

2014-10-31 Thread Scott Griepentrog
/res_pjsip_outbound_registration.c 426523 Diff: https://reviewboard.asterisk.org/r/4119/diff/ Testing --- Previously failing test channels/pjsip/registration/outbound/unregister/unauthed now passes. Other pjsip tests that were passing still pass. Thanks, Scott Griepentrog

  1   2   3   4   >