to reuse weakproxy objects. Not sure how useful
it will be.
- rmudgett
On April 3, 2015, 11:58 a.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4108
to be used in audiohooks.
Maybe that is what should happen but it does not. Audiohooks on the read path
examine the incoming frame before it is translated for return by ast_read().
Audiohooks on the write path examine frames after it is translated to go out on
the wire.
- rmudgett
app_originate to setup a call through a non-optimizing local
channel. The resulting call used the same codecs as before the patch even
between parties with different speeds.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation
parties with different speeds.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
capabilities. Without the patch I get the path
translation warnings. With the patch I don't get the warnings.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
434509
Diff: https://reviewboard.asterisk.org/r/4607/diff/
Testing
---
Items found while researching code for ASTERISK-24841. It compiles. Warm
fuzzy because it was part of code put in while testing overall code for
ASTERISK-24841.
Thanks,
rmudgett
for ASTERISK-24841. It compiles. Warm
fuzzy because it was part of code put in while testing overall code for
ASTERISK-24841.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
technologies but softmix
and without the code identified in ASTERISK-24841 allowing the PJSIP
native format capabilities to hold more than one audio format at a time,
there is no difference between the patch being applied or not.
Calls using G.722 into ConfBridge still work.
Thanks,
rmudgett
,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
,
there is no difference between the patch being applied or not.
Calls using G.722 into ConfBridge still work.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing
() to force inclusion of the h264
video codec in the native capabilities. Without the patch I get the path
translation warnings. With the patch I don't get the warnings.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided
to not
advertise anything you have to have a global section with user_agent explicitly
set to nothing.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15095
/apps/app_minivm.c
https://reviewboard.asterisk.org/r/4541/#comment25782
Might as well fix the comment typo while changing the line anyway.
Rest - Reset
- rmudgett
On April 6, 2015, 9:23 p.m., Diederik de Groot wrote
for the pjsip.conf [global] section.
The command seems aptly named.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4597/#review15109
On March 31, 2015, 8:16 p.m., rmudgett wrote:
/branches/13/funcs/func_curl.c, lines 174-175
https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174
Try defining this as:
#define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500)
This should shut-up
://reviewboard.asterisk.org/r/4541/#comment25760
Missing the !
if (!ast_strlen_zero())
/branches/13/apps/app_minivm.c
https://reviewboard.asterisk.org/r/4541/#comment25761
Same
/branches/13/apps/app_minivm.c
https://reviewboard.asterisk.org/r/4541/#comment25762
red blob
- rmudgett
On March
for the effort.
- rmudgett
On April 3, 2015, 4:24 p.m., Diederik de Groot wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4554
the scheduler that failed to be added.
/branches/13/channels/chan_iax2.c
https://reviewboard.asterisk.org/r/4554/#comment25733
This NULL check is not needed. peer can never be NULL here without an
earlier crash. This function is a scheduler callback.
- rmudgett
On April 3, 2015, 4:24
in res_pjsip.c.
It is documented as force instead of always. Maybe add force here as an
alias of always since it has been documented that way.
- rmudgett
On April 3, 2015, 2:58 p.m., Kevin Harwell wrote:
---
This is an automatically
On April 3, 2015, 4:36 p.m., rmudgett wrote:
This is still a nuisance warning that doesn't add much value for the effort.
Diederik de Groot wrote:
We can drop it no problem. I still think it could be useful in detecting
_ref/_unref issues, alas it would quite a bit of work but could
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4582/#review15056
---
Ship it!
Ship It!
- rmudgett
On April 3, 2015, 5:52 p.m
On April 3, 2015, 5:40 p.m., rmudgett wrote:
/branches/13/channels/chan_iax2.c, lines 2009-2013
https://reviewboard.asterisk.org/r/4554/diff/2/?file=73276#file73276line2009
This change causes bugs. It is supposed to return peer because it
increased the ref.
Diederik de Groot
it again.
It is specific framehooks that cannot be attached twice. It is not a general
requirement/property of the framehook concept.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https
byte layout.
A datastore could be used to record if the framehook is attached.
- rmudgett
On April 2, 2015, 2:08 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
and the overall macro expression.
#define MACRO(a,b) ((a) + (b))
- rmudgett
On March 31, 2015, 8:59 p.m., Diederik de Groot wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533
, I'm not sure.
- rmudgett
On March 30, 2015, 6:08 a.m., Diederik de Groot wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4533
://reviewboard.asterisk.org/r/4555/#comment25680
De red blobs.
- rmudgett
On March 31, 2015, 8:30 p.m., Diederik de Groot wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4555/#review15016
---
Ship it!
Ship It!
- rmudgett
On March 31, 2015, 9:42 p.m
On March 31, 2015, 8:16 p.m., rmudgett wrote:
/branches/13/funcs/func_curl.c, lines 174-175
https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174
Try defining this as:
#define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500)
This should shut-up
On March 31, 2015, 6:21 p.m., rmudgett wrote:
/branches/13/main/utils.c, lines 492-493
https://reviewboard.asterisk.org/r/4555/diff/5/?file=73346#file73346line492
Revert this. This change could affect the callers of the function
since you are changing the API. However
a potential for memory and ref
leaks.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4542/#review14972
---
On March 27, 2015
values are handled without a problem but with a
performance penalty. On other processors such as the 68000 you get an
alignment exception.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https
.
So this can be considered the reverse of the first warning, where an
assignment requires double parantheses.
rmudgett wrote:
I think this warning is a backlash from the warning about putting
assignments inside tests that you suppress by adding parentheses.
if ((a = b
/#comment25631
weakref2
/trunk/tests/test_astobj2_weaken.c
https://reviewboard.asterisk.org/r/4108/#comment25632
Destrustor and notifies not called...
- rmudgett
On March 4, 2015, 3:43 p.m., Corey Farrell wrote
once worked with
compiler that had a similar warning. The lengths you sometimes have to go to
eradicate the the warning can be extream.
There are several places in this patch that change code behavior and introduce
bugs.
- rmudgett
On March 28, 2015, 7:44 p.m., Diederik de Groot wrote
if (test_len == 0 {
test2 = ;
}
/branches/13/tests/test_strings.c
https://reviewboard.asterisk.org/r/4555/#comment25644
Revert now that the clang ast_alloca() problem is worked around.
- rmudgett
On March 29, 2015, 5:49 p.m., Diederik de Groot wrote
. It appears to be just a
nuisance warning.
/branches/13/formats/format_wav.c
https://reviewboard.asterisk.org/r/4544/#comment25538
Revert this per guidelines
- rmudgett
On March 27, 2015, 11:38 a.m., Diederik de Groot wrote
the escaped_len to 1 if
appdata==NULL, so that it will be able to contain '\0'.
ast_strlen_zero() is a boolean test. It does not actually do a strlen. It is
just: (!str || (*str == '\0')).
- rmudgett
---
This is an automatically generated e-mail
no longer reports those leaks.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
be one variable size struct element and it has to be at
the last position. Having them anywhere in the struct is a gcc extension.
rmudgett wrote:
This is not a valid fix!! The buf.name field is supposed to be the extra
space that the buf.iev.name field represents.
rmudgett wrote
contact_autoexpire *should* be empty, but I wonder if the
ao2_callback should be placed under the if (sched) check just to be on
the safe side.
There shouldn't be anything in the container if sched is NULL but for safety
I'll make the change.
- rmudgett
://reviewboard.asterisk.org/r/4523/diff/
Testing
---
Before the patch valgrind reported struct contact_expiration object memory
leaks.
After the patch valgrind no longer reports those leaks.
Thanks,
rmudgett
--
_
-- Bandwidth
://reviewboard.asterisk.org/r/4502/#comment25430
I though you were going to remove this change.
- rmudgett
On March 24, 2015, 5:05 p.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
Diff: https://reviewboard.asterisk.org/r/4524/diff/
Testing
---
Phones still registered.
Placed a call and it still worked.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
is:
load_module() {}
unload_module() {}
When a failing load_module() usually calls unload_module() to cleanup.
- rmudgett
On March 25, 2015, 10:35 a.m., Matt Jordan wrote:
---
This is an automatically generated e-mail. To reply, visit
/4501/#comment25420
Oopsie. There should be only one. :)
- rmudgett
On March 24, 2015, 5:18 p.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4501
initially had 1 second for my test box but increased it to 2 for the slower
agents.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4518/#review14790
/13/main/bridge_channel.c
https://reviewboard.asterisk.org/r/4510/#comment25393
Just
if (digit)
is sufficient.
If anything, you should assert:
ast_assert(0 = digit)
because passing in a negative value is invalid.
- rmudgett
On March 19, 2015, 4:59 p.m., Kevin Harwell
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4477/#review14797
---
Ship it!
- rmudgett
On March 19, 2015, 4:59 p.m., Kevin
to the caller.
* https://reviewboard.asterisk.org/r/4518/ testsuite test passes.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4518/diff/
Testing
---
This is the testsuite test to test the rpid_immediate option added by review:
https://reviewboard.asterisk.org/r/4473/
The test passes.
Thanks,
rmudgett
On March 24, 2015, 12:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users
://reviewboard.asterisk.org/r/4502/#comment25411
This can be removed as it was added for the backtrace
_ast_mem_backtrace_buffer[].
- rmudgett
On March 15, 2015, 9:17 p.m., Corey Farrell wrote:
---
This is an automatically generated e-mail
.
- rmudgett
On March 22, 2015, 11:36 p.m., Ashley Sanders wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519
to be exposed.
- rmudgett
On March 15, 2015, 9:17 p.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502
On March 24, 2015, 12:52 p.m., rmudgett wrote:
/branches/13/main/logger.c, line 1762
https://reviewboard.asterisk.org/r/4502/diff/1/?file=72474#file72474line1762
Why couldn't the log safe recursion check be done all the time by
ast_log_full()?
Relying on users
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4510/#review14816
---
Ship it!
Ship It!
- rmudgett
On March 24, 2015, 3:30 p.m
On March 20, 2015, 11:54 p.m., Corey Farrell wrote:
Is a sipp scenario needed to verify Asterisk sends the correct SIP packets
for rpid_immediate on and off?
rmudgett wrote:
A sipp scenario is not needed. The test is to check *when* connected
line is passed not how since
/4518/ testsuite test passes.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
changing the offset of send_diversion and
refresh_method. Seems like it's in the right place for trunk (keeping
unsigned int's together). Not sure if it even matters for res_pjsip to
provide stable ABI.
rmudgett wrote:
Ugh. Yes it is an ABI change. Even worse, the new value cannot go
/rpid_immediate/configs/ast1/extensions.conf
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4518/diff/
Testing
---
This is the testsuite test to test the rpid_immediate option added by review:
https://reviewboard.asterisk.org/r/4473/
The test passes.
Thanks,
rmudgett
option controls.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4518/#review14762
---
On March 20, 2015, 3:48 p.m
if there are subtle
interactions between modules for the atexit and cleanup versions when doing a
stop/restart now.
- rmudgett
On March 15, 2015, 5:33 a.m., Corey Farrell wrote:
---
This is an automatically generated e-mail. To reply
/4501/#comment25340
These can be merged.
/branches/13/main/http.c
https://reviewboard.asterisk.org/r/4501/#comment25341
This may need to stay. HTTP needs to shutdown socket connections.
Manager as well.
- rmudgett
On March 15, 2015, 5:33 a.m., Corey Farrell wrote
there too
because the module is reffed on channel creation and if there ever are any
local channels they wouldn't have a chance to go away before the module unload
cleanup completed and hilarity ensues.
- rmudgett
from the
sorcery_object_field_destructor().
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
/
Testing
---
* Ran the tests/channels/pjsip testsuite tests. They still pass.
* Made a call chain as follows: 100 - * - * - * - 200. With the patch
there are no unnecessary messages. Without the patch there were several
180 Ringing messages sent back to the caller.
Thanks,
rmudgett
to test the rpid_immediate option added by review:
https://reviewboard.asterisk.org/r/4473/
The test passes.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing
://reviewboard.asterisk.org/r/4518/ testsuite test passes.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
OPTIONS and MESSAGE
requests hit the code that leaked the endpoint object refs.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
. Without the patch there were several
180 Ringing messages sent back to the caller.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
().
bridge_channel is not really used as conference_bridge_user-chan could be
used instead.
branches/11/apps/app_confbridge.c
https://reviewboard.asterisk.org/r/4477/#comment25318
Similar situation here as with action_toggle_mute().
- rmudgett
On March 17, 2015, 1 p.m., Kevin Harwell wrote
we need to return and empty the digit collection buffer.
branches/13/main/bridge_channel.c
https://reviewboard.asterisk.org/r/4510/#comment25329
This can be simplified to:
dfmf_len = strlen()
if (!dtmf_len) { return }
- rmudgett
On March 17, 2015, 1 p.m., Kevin Harwell wrote
that valgrind no longer complains of
sscanf() performing an invalid read in get_codecs().
* Valgrind no longer complains of definitely leaked memory resulting from the
sorcery_object_field_destructor().
Thanks,
rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4189/#review14718
---
Ship it!
Ship It!
- rmudgett
On March 16, 2015, 6:42 p.m
---
Compiling and code inspection.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com
/13/res/res_pjsip.c 433089
Diff: https://reviewboard.asterisk.org/r/4511/diff/
Testing
---
Added temporary logging messages to show that incoming OPTIONS and MESSAGE
requests hit the code that leaked the endpoint object refs.
Thanks,
rmudgett
433004
/branches/13/main/netsock2.c 433004
/branches/13/apps/app_externalivr.c 433004
Diff: https://reviewboard.asterisk.org/r/4509/diff/
Testing
---
Compiling and code inspection.
Thanks,
rmudgett
/4189/#comment25277
Take the assignment out of the if test. The long assignment line has
better line breaks outside of the if test.
- rmudgett
On March 15, 2015, 10 p.m., Corey Farrell wrote:
---
This is an automatically generated e
On March 12, 2015, 3:41 p.m., Matt Jordan wrote:
1. For this to go into Asterisk 13, tests will need to be provided that
cover the new parameter. (Really, those tests should be written regardless)
2. The CHANGES file will need to get updated with the new option.
rmudgett wrote
chain as follows: 100 - * - * - * - 200. With the patch
there are no unnecessary messages. Without the patch there were several
180 Ringing messages sent back to the caller.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation
On March 12, 2015, 3:41 p.m., Matt Jordan wrote:
1. For this to go into Asterisk 13, tests will need to be provided that
cover the new parameter. (Really, those tests should be written regardless)
2. The CHANGES file will need to get updated with the new option.
rmudgett wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4487/#review14678
---
Ship it!
Ship It!
- rmudgett
On March 13, 2015, 2:28 a.m
/trunk/tests/hep/pjsip-auth/configs/ast1/pjsip.conf 6522
Diff: https://reviewboard.asterisk.org/r/4484/diff/
Testing
---
Tests now pass with the patch.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http
://reviewboard.asterisk.org/r/4472/diff/
Testing
---
Ran the tests/channels/pjsip testsuite tests. They still pass.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
when they would go out without a
value before.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
. The
User-Agent and Server headers do not go out when they would go out without a
value before.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
with the patch.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk
that the rpid_immediate option not exist at all and the
code it controls to just be removed. Sending connected line updates back to
the caller _before_ getting connected doesn't really make sense. This is what
the REDIRECTING information is supposed to be doing.
- rmudgett
* - starts playback and continue
The user now must restart DTMF entry to match *1.
- rmudgett
On March 11, 2015, 12:05 p.m., Kevin Harwell wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
? Or add a refresh at xx% of lowest TTL or one second
whichever is greater parameter? Maybe a maximum refresh interval time if the
TTL is very large.
- rmudgett
On March 11, 2015, 6:42 a.m., Joshua Colp wrote
to res_pjsip_private.h
I'll move these and the other similar prototypes to the private file after I
commit this patch. I'll leave this issue open as a reminder.
- rmudgett
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4469/#review14627
---
Ship it!
Ship It!
- rmudgett
On March 10, 2015, 8:47 a.m
they would go out without a
value before.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com
On March 10, 2015, 8:25 a.m., Joshua Colp wrote:
/branches/13/res/res_pjsip/config_global.c, line 229
https://reviewboard.asterisk.org/r/4467/diff/1/?file=71922#file71922line229
Why the change of this from a define to not a device?
rmudgett wrote:
The define did not help
in send_direct_media_request().
Diffs
-
/branches/13/res/res_pjsip_caller_id.c 432722
/branches/13/channels/chan_pjsip.c 432722
Diff: https://reviewboard.asterisk.org/r/4472/diff/
Testing
---
Ran the tests/channels/pjsip testsuite tests. They still pass.
Thanks,
rmudgett
to the caller.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk
user_agent value set. The User-Agent
and Server headers have the custom value.
4) One global object defined with user_agent value set to an empty string. The
User-Agent and Server headers do not go out when they would go out without a
value before.
Thanks,
rmudgett
/
Testing
---
The testsuite tests/channels/pjsip/ tests still pass with the patch.
Thanks,
rmudgett
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update
I reported for the switch-statement
bodies from lines 748 and 478. This could benefit from a common function
for assigning the response value.
Much more refactoring is beyond the scope of the issue.
- rmudgett
1 - 100 of 861 matches
Mail list logo
