Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-02-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/ --- (Updated Feb. 6, 2014, 5:33 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-28 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/ --- (Updated Jan. 28, 2014, 4:20 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/#review10597 --- branches/12/res/res_pjsip/config_transport.c

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread Mark Michelson
On Jan. 16, 2014, 3:10 p.m., Joshua Colp wrote: branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 285-287 https://reviewboard.asterisk.org/r/3104/diff/1/?file=51197#file51197line285 I'm cracking down on gratuitous RAII_VAR usage these days. Actually, this use of RAII_VAR

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/#review10599 --- branches/12/res/res_pjsip/config_auth.c

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
On Jan. 16, 2014, 8:10 a.m., Joshua Colp wrote: branches/12/res/res_pjsip/config_auth.c, line 292 https://reviewboard.asterisk.org/r/3104/diff/1/?file=51192#file51192line292 You don't need to store the sorcery instance, you can use ast_sip_get_sorcery to retrieve it. Same goes

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
On Jan. 16, 2014, 8:23 a.m., opticron wrote: branches/12/res/res_pjsip_outbound_registration.c, lines 1164-1167 https://reviewboard.asterisk.org/r/3104/diff/1/?file=51198#file51198line1164 These commands appear to be non-functional on latest Asterisk 12 branch with this patch.

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
On Jan. 16, 2014, 9:32 a.m., Mark Michelson wrote: branches/12/res/res_pjsip_endpoint_identifier_ip.c, line 305 https://reviewboard.asterisk.org/r/3104/diff/1/?file=51197#file51197line305 Why 14? That's the adjustment needed to get the output to line up. On Jan. 16, 2014, 9:32

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/ --- (Updated Jan. 16, 2014, 11:04 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread opticron
On Jan. 16, 2014, 9:23 a.m., opticron wrote: branches/12/res/res_pjsip_outbound_registration.c, lines 1164-1167 https://reviewboard.asterisk.org/r/3104/diff/1/?file=51198#file51198line1164 These commands appear to be non-functional on latest Asterisk 12 branch with this patch.

[asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/ --- Review request for Asterisk Developers. Repository: Asterisk