Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-03-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- (Updated March 6, 2014, 3:42 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-03-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/#review11075 --- Very cool functionality. Could use a mention in CHANGES :-)

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-03-05 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- (Updated March 5, 2014, 4:09 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-03-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/#review11085 --- Ship it! Ship It! - Matt Jordan On March 5, 2014, 5:09

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-28 Thread George Joseph
On Feb. 27, 2014, 10:59 a.m., opticron wrote: branches/12/main/sorcery.c, lines 1101- https://reviewboard.asterisk.org/r/3254/diff/1/?file=54398#file54398line1101 Why not use the newly created ast_variable_list_append() here? George Joseph wrote: ast_variable_list_append

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-28 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- (Updated Feb. 28, 2014, 2:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-27 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/#review10971 --- branches/12/funcs/func_sorcery.c

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-27 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- (Updated Feb. 27, 2014, 1:19 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-27 Thread George Joseph
On Feb. 27, 2014, 10:59 a.m., opticron wrote: branches/12/funcs/func_sorcery.c, line 6 https://reviewboard.asterisk.org/r/3254/diff/1/?file=54393#file54393line6 This might not be correct. Heh, cut and paste. On Feb. 27, 2014, 10:59 a.m., opticron wrote:

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-27 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- (Updated Feb. 27, 2014, 2:45 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254/ --- Review request for Asterisk Developers. Bugs: ASTERISK-22537