Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/#review11723 --- Ship it! Ship It! - Joshua Colp On April 22, 2014, 7:50

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-23 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated April 23, 2014, 3:06 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/#review11714 --- Ship it! branches/12/include/asterisk/spinlock.h

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread George Joseph
On April 22, 2014, 10:58 a.m., rmudgett wrote: branches/12/include/asterisk/spinlock.h, lines 403-405 https://reviewboard.asterisk.org/r/3405/diff/5/?file=57747#file57747line403 This statement isn't quite true since these prototypes are declared after the functions themselves are

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated April 22, 2014, 12:35 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/#review11716 --- branches/12/include/asterisk/spinlock.h

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread rmudgett
On April 22, 2014, 11:58 a.m., rmudgett wrote: branches/12/include/asterisk/spinlock.h, lines 403-405 https://reviewboard.asterisk.org/r/3405/diff/5/?file=57747#file57747line403 This statement isn't quite true since these prototypes are declared after the functions themselves are

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread George Joseph
On April 22, 2014, 12:43 p.m., rmudgett wrote: branches/12/include/asterisk/spinlock.h, lines 445-455 https://reviewboard.asterisk.org/r/3405/diff/5-6/?file=57747#file57747line445 Why did this get moved? cut and paste error. - George

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated April 22, 2014, 1:50 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-19 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated April 19, 2014, 10:57 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/#review11697 --- branches/12/include/asterisk/spinlock.h

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated April 18, 2014, 5:09 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-18 Thread George Joseph
On April 18, 2014, 3:45 p.m., rmudgett wrote: branches/12/include/asterisk/spinlock.h, lines 49-51 https://reviewboard.asterisk.org/r/3405/diff/3/?file=57409#file57409line49 Spinlocks are useless on a non-multicore machines. The assembly versions should have some check to see if

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-17 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated April 17, 2014, 11:26 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-14 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated April 14, 2014, 1:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

2014-03-28 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated March 28, 2014, 10:56 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

2014-03-27 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23553

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

2014-03-27 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated March 27, 2014, 2:47 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

2014-03-27 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated March 27, 2014, 2:57 p.m.) Review request for Asterisk