Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-14 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/ --- (Updated Jan. 14, 2015, 5:14 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-14 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14173 --- Ship it! Ship It! - Joshua Colp On Jan. 9, 2015, 3:37

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread George Joseph
On Jan. 8, 2015, 2:13 p.m., Mark Michelson wrote: branches/13/res/res_pjsip.c, lines 43-45 https://reviewboard.asterisk.org/r/4311/diff/1-2/?file=70130#file70130line43 What caused these dependencies to be added? Kevin Harwell wrote: pjsip_options uses sorcery_memory with

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/ --- (Updated Jan. 9, 2015, 9:37 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread Joshua Colp
On Jan. 8, 2015, 9:13 p.m., Mark Michelson wrote: branches/13/res/res_pjsip.c, lines 43-45 https://reviewboard.asterisk.org/r/4311/diff/1-2/?file=70130#file70130line43 What caused these dependencies to be added? Kevin Harwell wrote: pjsip_options uses sorcery_memory with

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread George Joseph
On Jan. 8, 2015, 2:13 p.m., Mark Michelson wrote: branches/13/res/res_pjsip.c, lines 43-45 https://reviewboard.asterisk.org/r/4311/diff/1-2/?file=70130#file70130line43 What caused these dependencies to be added? Kevin Harwell wrote: pjsip_options uses sorcery_memory with

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread Joshua Colp
On Jan. 8, 2015, 9:13 p.m., Mark Michelson wrote: branches/13/res/res_pjsip.c, lines 43-45 https://reviewboard.asterisk.org/r/4311/diff/1-2/?file=70130#file70130line43 What caused these dependencies to be added? Kevin Harwell wrote: pjsip_options uses sorcery_memory with

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-09 Thread Joshua Colp
On Jan. 8, 2015, 9:13 p.m., Mark Michelson wrote: branches/13/res/res_pjsip.c, lines 43-45 https://reviewboard.asterisk.org/r/4311/diff/1-2/?file=70130#file70130line43 What caused these dependencies to be added? Kevin Harwell wrote: pjsip_options uses sorcery_memory with

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-08 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/ --- (Updated Jan. 8, 2015, 3:50 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-08 Thread Kevin Harwell
On Jan. 8, 2015, 3:13 p.m., Mark Michelson wrote: branches/13/res/res_pjsip.c, lines 43-45 https://reviewboard.asterisk.org/r/4311/diff/1-2/?file=70130#file70130line43 What caused these dependencies to be added? pjsip_options uses sorcery_memory with regards to

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-08 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14126 --- branches/13/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-08 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14125 --- branches/13/res/res_pjsip.c

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14093 --- So, I applied the patch but am having trouble seeing what this

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread Kevin Harwell
On Jan. 5, 2015, 4:47 p.m., Mark Michelson wrote: branches/13/res/res_pjsip/include/res_pjsip_private.h, lines 123-141 https://reviewboard.asterisk.org/r/4311/diff/1/?file=70133#file70133line123 I unnastand the need for these functions, but I feel like they could be named more

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread Mark Michelson
On Jan. 5, 2015, 10:47 p.m., Mark Michelson wrote: branches/13/res/res_pjsip/include/res_pjsip_private.h, lines 123-141 https://reviewboard.asterisk.org/r/4311/diff/1/?file=70133#file70133line123 I unnastand the need for these functions, but I feel like they could be named more

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread George Joseph
On Jan. 6, 2015, 1:34 p.m., George Joseph wrote: So, I applied the patch but am having trouble seeing what this does in real life. res_pjsip can only load by itself if there's no configuration. Even a minimal one requires res_pjsip_session and

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/ --- (Updated Jan. 6, 2015, 3:30 p.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread George Joseph
On Jan. 6, 2015, 1:34 p.m., George Joseph wrote: So, I applied the patch but am having trouble seeing what this does in real life. res_pjsip can only load by itself if there's no configuration. Even a minimal one requires res_pjsip_session and

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread George Joseph
On Jan. 6, 2015, 1:34 p.m., George Joseph wrote: So, I applied the patch but am having trouble seeing what this does in real life. res_pjsip can only load by itself if there's no configuration. Even a minimal one requires res_pjsip_session and

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-06 Thread Kevin Harwell
On Jan. 6, 2015, 2:34 p.m., George Joseph wrote: So, I applied the patch but am having trouble seeing what this does in real life. res_pjsip can only load by itself if there's no configuration. Even a minimal one requires res_pjsip_session and

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-05 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14076 --- branches/13/res/res_pjsip/include/res_pjsip_private.h

Re: [asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-05 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/#review14074 --- I have tested and confirmed no failures under valgrind with

[asterisk-dev] [Code Review] 4311: res_pjsip: make it unloadable

2015-01-02 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4311/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24485