---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/
---
(Updated Jan. 29, 2015, 11:20 a.m.)
Review request for Asterisk
On Jan. 28, 2015, 3:08 p.m., rmudgett wrote:
/branches/13/include/asterisk/bridge.h, line 245
https://reviewboard.asterisk.org/r/4382/diff/4/?file=71156#file71156line245
push_peek should not use push's typedef. It should use its own in case
they need to diverge since they are
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/#review14364
---
Ship it!
Ship It!
- rmudgett
On Jan. 29, 2015, 11:20 a.m.,
On Jan. 28, 2015, 8:15 a.m., Matt Jordan wrote:
/branches/13/res/stasis/stasis_bridge.c, lines 115-133
https://reviewboard.asterisk.org/r/4382/diff/2/?file=71148#file71148line115
You may want to consider the usage of a goto here (gasp!) to reduce
indentation:
if
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/
---
(Updated Jan. 29, 2015, 5:02 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/#review14340
---
/branches/13/res/stasis/stasis_bridge.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/#review14346
---
/branches/13/main/bridge.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/
---
(Updated Jan. 28, 2015, 11:01 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/#review14347
---
/branches/13/include/asterisk/bridge.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/#review14341
---
/branches/13/include/asterisk/bridge.h
On Jan. 28, 2015, 10:42 a.m., rmudgett wrote:
/branches/13/include/asterisk/bridge.h, lines 244-245
https://reviewboard.asterisk.org/r/4382/diff/2/?file=71145#file71145line244
Create a new typedef for the new callback. Also the new callback
doesn't need the swap parameter since
On Jan. 28, 2015, 8:15 a.m., Matt Jordan wrote:
/branches/13/res/stasis/stasis_bridge.c, lines 115-133
https://reviewboard.asterisk.org/r/4382/diff/2/?file=71148#file71148line115
You may want to consider the usage of a goto here (gasp!) to reduce
indentation:
if
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/
---
(Updated Jan. 28, 2015, 1:35 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24649
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/
---
(Updated Jan. 27, 2015, 8:11 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/
---
(Updated Jan. 27, 2015, 8:55 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4382/#review14326
---
/branches/13/main/bridge.c
17 matches
Mail list logo