Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-13 Thread Mark Michelson
On Feb. 12, 2015, 6:42 p.m., Mark Michelson wrote: /asterisk/trunk/lib/python/asterisk/pjsua_mod.py, lines 258-259 https://reviewboard.asterisk.org/r/4413/diff/1/?file=71349#file71349line258 Is this change necessary since you ended up overriding reg_success() in your new

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-13 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/#review14459 --- Ship it! Ship It! - Mark Michelson On Feb. 13, 2015, 3:48

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-13 Thread jbigelow
On Feb. 12, 2015, 12:42 p.m., Mark Michelson wrote: /asterisk/trunk/lib/python/asterisk/pjsua_mod.py, lines 258-259 https://reviewboard.asterisk.org/r/4413/diff/1/?file=71349#file71349line258 Is this change necessary since you ended up overriding reg_success() in your new

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-13 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 13, 2015, 9:48 a.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-13 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 13, 2015, 12:28 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-12 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/#review14450 --- /asterisk/trunk/lib/python/asterisk/phones.py

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-12 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 12, 2015, 6:27 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-12 Thread jbigelow
On Feb. 12, 2015, 12:42 p.m., Mark Michelson wrote: /asterisk/trunk/lib/python/asterisk/phones.py, lines 86-88 https://reviewboard.asterisk.org/r/4413/diff/1/?file=71348#file71348line86 I think this is a good case for using is instead of equality. I imagine that callers of this

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-12 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 12, 2015, 10:25 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-10 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- Review request for Asterisk Developers. Repository: testsuite

Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.

2015-02-10 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 11, 2015, 12:32 a.m.) Review request for Asterisk