Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-06 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 6, 2015, 1:45 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-05 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/#review14600 --- /asterisk/trunk/lib/python/asterisk/pjsua_mod.py

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-05 Thread Ashley Sanders
On March 5, 2015, 1:53 p.m., jbigelow wrote: I see a lot of duplication in the run-test files. I suggest that we refactor and abstract the common pieces of code into a base class somewhere. For instance the check_results function could be abstracted and I saw a couple of more

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-05 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 5, 2015, 8:55 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-05 Thread jbigelow
On March 5, 2015, 1:53 p.m., Ashley Sanders wrote: /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml, line 5 https://reviewboard.asterisk.org/r/4452/diff/2/?file=71751#file71751line5 You are missing the

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-05 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 5, 2015, 8:51 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-04 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 4, 2015, 12:58 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-04 Thread jbigelow
On March 3, 2015, 3:40 p.m., Mark Michelson wrote: /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test, line 291 https://reviewboard.asterisk.org/r/4452/diff/1/?file=71670#file71670line291 Why or 0 ? Isn't that a

Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-03-03 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/#review14583 --- Ship it!

[asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

2015-02-26 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24586