Re: [asterisk-dev] [Code Review] 4454: chan_sip: Fix realtime locking inversion when poking a just built peer.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4454/ --- (Updated March 6, 2015, 1:18 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 432526 Bugs: ASTERISK-24838 https://issues.asterisk.org/jira/browse/ASTERISK-24838 Repository: Asterisk Description --- When a realtime peer is built it can cause a locking inversion when the just built peer is poked. If the CLI command sip show channels is periodically executed a deadlock can happen because of the locking inversion. * Push the peer poke off onto the scheduler thread to avoid the locking inversion of the just built realtime peer. Diffs - /branches/11/channels/chan_sip.c 432422 Diff: https://reviewboard.asterisk.org/r/4454/diff/ Testing --- Compiling and code inspection. I don't have a realtime setup to test with. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4454: chan_sip: Fix realtime locking inversion when poking a just built peer.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4454/#review14584 --- Ship it! Ship It! - Mark Michelson On Feb. 27, 2015, 11:38 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4454/ --- (Updated Feb. 27, 2015, 11:38 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24838 https://issues.asterisk.org/jira/browse/ASTERISK-24838 Repository: Asterisk Description --- When a realtime peer is built it can cause a locking inversion when the just built peer is poked. If the CLI command sip show channels is periodically executed a deadlock can happen because of the locking inversion. * Push the peer poke off onto the scheduler thread to avoid the locking inversion of the just built realtime peer. Diffs - /branches/11/channels/chan_sip.c 432422 Diff: https://reviewboard.asterisk.org/r/4454/diff/ Testing --- Compiling and code inspection. I don't have a realtime setup to test with. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4454: chan_sip: Fix realtime locking inversion when poking a just built peer.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4454/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24838 https://issues.asterisk.org/jira/browse/ASTERISK-24838 Repository: Asterisk Description --- When a realtime peer is built it can cause a locking inversion when the just built peer is poked. If the CLI command sip show channels is periodically executed a deadlock can happen because of the locking inversion. * Push the peer poke off onto the scheduler thread to avoid the locking inversion of the just built realtime peer. Diffs - /branches/11/channels/chan_sip.c 432422 Diff: https://reviewboard.asterisk.org/r/4454/diff/ Testing --- Compiling and code inspection. I don't have a realtime setup to test with. Thanks, rmudgett -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
