Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-12 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/ --- (Updated March 10, 2015, 2:45 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-12 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/ --- (Updated March 11, 2015, 10:19 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/#review14621 --- /branches/13/res/res_pjsip/config_global.c

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread rmudgett
On March 10, 2015, 11:35 a.m., Kevin Harwell wrote: /branches/13/include/asterisk/res_pjsip.h, lines 1628-1643 https://reviewboard.asterisk.org/r/4467/diff/2/?file=71946#file71946line1628 If these are not referenced outside of res_pjsip then they can be moved to

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/#review14634 --- Ship it! Ship It! - Matt Jordan On March 10, 2015, 2:45

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/ --- (Updated March 10, 2015, 10:48 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread Matt Jordan
On March 10, 2015, 8:25 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip/config_global.c, line 229 https://reviewboard.asterisk.org/r/4467/diff/1/?file=71922#file71922line229 Why the change of this from a define to not a device? rmudgett wrote: The define did not help

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread rmudgett
On March 10, 2015, 8:25 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip/config_global.c, line 229 https://reviewboard.asterisk.org/r/4467/diff/1/?file=71922#file71922line229 Why the change of this from a define to not a device? rmudgett wrote: The define did not help

[asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24807