Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-26 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/ --- (Updated March 26, 2015, noon) Status -- This change has been marked

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/#review14786 --- Ship it! Ship It! - Joshua Colp On March 19, 2015, 9:59

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-24 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/#review14797 --- Ship it! - rmudgett On March 19, 2015, 4:59 p.m., Kevin

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-19 Thread Kevin Harwell
On March 18, 2015, 12:39 p.m., rmudgett wrote: branches/11/apps/app_confbridge.c, lines 1847-1853 https://reviewboard.asterisk.org/r/4477/diff/2/?file=72633#file72633line1847 Swaping which plays first will allow the channel's prompt to be interruptable. Although doing this will

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-19 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/ --- (Updated March 19, 2015, 4:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/#review14733 --- branches/11/apps/app_confbridge.c

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-18 Thread Matt Jordan
On March 18, 2015, 12:39 p.m., rmudgett wrote: branches/11/apps/app_confbridge.c, line 676 https://reviewboard.asterisk.org/r/4477/diff/2/?file=72633#file72633line676 Please get out of the habit of assigning in if tests: digit = ast_stream_and_wait(...) if (digit

Re: [asterisk-dev] [Code Review] 4477: app_confbridge (11): file playback blocks dtmf

2015-03-17 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4477/ --- (Updated March 17, 2015, 1 p.m.) Review request for Asterisk Developers.