Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-09 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated April 9, 2015, 7:47 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-07 Thread rmudgett
On March 31, 2015, 8:16 p.m., rmudgett wrote: /branches/13/funcs/func_curl.c, lines 174-175 https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174 Try defining this as: #define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500) This should shut-up

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-07 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated April 8, 2015, 1:26 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-07 Thread Diederik de Groot
On April 1, 2015, 3:16 a.m., rmudgett wrote: /branches/13/funcs/func_curl.c, lines 174-175 https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174 Try defining this as: #define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500) This should shut-up

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-04-07 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated April 8, 2015, 1:25 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/#review15013 --- /branches/13/channels/chan_skinny.c

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated April 1, 2015, 4:52 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated April 1, 2015, 4:54 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
On April 1, 2015, 4:30 a.m., rmudgett wrote: /branches/13/channels/chan_skinny.c, line 2387 https://reviewboard.asterisk.org/r/4533/diff/8/?file=73424#file73424line2387 Guidelines: No space with parens if (a) { } Getting late... - Diederik

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/#review15003 --- /branches/13/channels/chan_skinny.c

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
On April 1, 2015, 3:16 a.m., rmudgett wrote: /branches/13/funcs/func_curl.c, lines 174-175 https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174 Try defining this as: #define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500) This should shut-up

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread rmudgett
On March 31, 2015, 8:16 p.m., rmudgett wrote: /branches/13/funcs/func_curl.c, lines 174-175 https://reviewboard.asterisk.org/r/4533/diff/7/?file=73369#file73369line174 Try defining this as: #define CURLOPT_SPECIAL_HASHCOMPAT ((CURLoption) -500) This should shut-up

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
On April 1, 2015, 3:16 a.m., rmudgett wrote: Thanks for your help on this one ! - Diederik --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/#review15003

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-31 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated April 1, 2015, 3:59 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-30 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 30, 2015, 1:08 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-29 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 29, 2015, 7:10 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 28, 2015, 3:45 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 28, 2015, 3:43 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 28, 2015, 5:28 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 28, 2015, 3:54 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 28, 2015, 3:56 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-28 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 28, 2015, 6:28 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-27 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- (Updated March 27, 2015, 11:42 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-27 Thread Diederik de Groot
On March 26, 2015, 11:13 p.m., Diederik de Groot wrote: /branches/13/channels/pjsip/dialplan_functions.c, line 869 https://reviewboard.asterisk.org/r/4533/diff/1/?file=72956#file72956line869 len is of type size_t, which is unsigned. It will not be able to hold a value 0 Matt

[asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-26 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24917

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-26 Thread Diederik de Groot
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4533/#review14862 --- /branches/13/channels/pjsip/dialplan_functions.c

Re: [asterisk-dev] [Code Review] 4533: clang compiler warning: -Wtautological-compare

2015-03-26 Thread Matt Jordan
On March 26, 2015, 5:13 p.m., Diederik de Groot wrote: /branches/13/channels/pjsip/dialplan_functions.c, line 869 https://reviewboard.asterisk.org/r/4533/diff/1/?file=72956#file72956line869 len is of type size_t, which is unsigned. It will not be able to hold a value 0 Rather