Re: [asterisk-dev] ASTERISK-26978 - rtp: Crash in ast_rtp_codecs_payload_code()

2017-05-24 Thread Joshua Colp
On Wed, May 24, 2017, at 12:12 PM, Ross Beer wrote: > >> > > >> Therefore I have added the following code to check for this: > >> > >> > >> if (format1->codec == NULL || format2->codec == NULL) { > >> return AST_FORMAT_CMP_NOT_EQUAL; > >> } > >> > >> The question is, should 'codec' be

Re: [asterisk-dev] ASTERISK-26978 - rtp: Crash in ast_rtp_codecs_payload_code()

2017-05-24 Thread Ross Beer
>> >> Therefore I have added the following code to check for this: >> >> >> if (format1->codec == NULL || format2->codec == NULL) { >> return AST_FORMAT_CMP_NOT_EQUAL; >> } >> >> The question is, should 'codec' be NULL if 'format1' and 'format2' are .> not NULL? Is adding the above check,

Re: [asterisk-dev] ASTERISK-26978 - rtp: Crash in ast_rtp_codecs_payload_code()

2017-05-24 Thread Joshua Colp
On Wed, May 24, 2017, at 11:13 AM, Ross Beer wrote: > > Therefore I have added the following code to check for this: > > > if (format1->codec == NULL || format2->codec == NULL) { > return AST_FORMAT_CMP_NOT_EQUAL; > } > > The question is, should 'codec' be NULL if 'format1' and

[asterisk-dev] ASTERISK-26978 - rtp: Crash in ast_rtp_codecs_payload_code()

2017-05-24 Thread Ross Beer
Hi, I'm trying to fix a bug within the ast_rtp_codecs_payload_code(), there are multiple crashes in the procedure. The latest being: #0 0x0051f883 in ast_format_cmp (format1=0x2bf73b8, format2=0x151) at format.c:247 This line contains: if (format1->codec != format2->codec) {