Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

2016-11-12 0:45 GMT+01:00 Joshua Colp : > On Fri, Nov 11, 2016, at 07:36 PM, Lorenzo Miniero wrote: > > > > > > > > > > > As a side note, I anticipated the code is ugly in its current form, > and I > > > > haven't checked if there can be leaks as it is. I've been away from > >

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

On Fri, Nov 11, 2016, at 07:36 PM, Lorenzo Miniero wrote: > > > > > > As a side note, I anticipated the code is ugly in its current form, and I > > > haven't checked if there can be leaks as it is. I've been away from > > > Asterisk coding for a while, so fresh eyes can probably help spot

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

2016-11-11 15:19 GMT+01:00 Joshua Colp : > On Fri, Nov 11, 2016, at 10:09 AM, Lorenzo Miniero wrote: > > > > > > > Hi all, > > > > I just completed a tentative patch that implements what we discussed. You > > can find it attached (assuming mailman doesn't strip it), and I used

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

On Fri, Nov 11, 2016, at 10:09 AM, Lorenzo Miniero wrote: > > Hi all, > > I just completed a tentative patch that implements what we discussed. You > can find it attached (assuming mailman doesn't strip it), and I used the > Asterisk 14.1.2 as a basis if you want to try it. Can you give a

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

2016-11-07 16:31 GMT+01:00 Lorenzo Miniero : > 2016-11-07 16:17 GMT+01:00 Joshua Colp : > >> Lorenzo Miniero wrote: >> >>> Hi all, >>> >>> apologies if this has been discussed before, but I couldn't find >>> anything in the recent months on this group so I

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

2016-11-07 16:20 GMT+01:00 Olle E. Johansson : > Let’s extend this “how to communicate with a codec” discussion and add the > need for feedback > on silence. I think there’s an old mail from Matt Jordan touching this > earlier. My code for silence suppression > and comfort noise

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

2016-11-07 16:17 GMT+01:00 Joshua Colp : > Lorenzo Miniero wrote: > >> Hi all, >> >> apologies if this has been discussed before, but I couldn't find >> anything in the recent months on this group so I thought I'd write anyway. >> >> As a few others, I believe, I have been

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

Let’s extend this “how to communicate with a codec” discussion and add the need for feedback on silence. I think there’s an old mail from Matt Jordan touching this earlier. My code for silence suppression and comfort noise adds un-needed transcoding and needed a way for a codec to communicate

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

Lorenzo Miniero wrote: Hi all, apologies if this has been discussed before, but I couldn't find anything in the recent months on this group so I thought I'd write anyway. As a few others, I believe, I have been trying to find a way to make codec modules more aware of what's happening on the

Re: [asterisk-dev] Strategies for handling RTCP feedback in codec modules

2016-11-04 11:28 GMT+01:00 Lorenzo Miniero : > Hi all, > > apologies if this has been discussed before, but I couldn't find anything > in the recent months on this group so I thought I'd write anyway. > > As a few others, I believe, I have been trying to find a way to make

[asterisk-dev] Strategies for handling RTCP feedback in codec modules

Hi all, apologies if this has been discussed before, but I couldn't find anything in the recent months on this group so I thought I'd write anyway. As a few others, I believe, I have been trying to find a way to make codec modules more aware of what's happening on the wire. In particular, the