Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-21 Thread George Joseph
On Thu, Nov 21, 2013 at 7:25 AM, Joshua Colp jc...@digium.com wrote: George Joseph wrote: Just FYI... I've got a whole bunch of pjsip cli stuff waiting on this patch to be committed. Any chance of this happening this week? It'll get reviewed today and pending any other findings arising

[asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-04 Thread George Joseph
://reviewboard.asterisk.org/r/3043/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread George Joseph
://reviewboard.asterisk.org/r/3043/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-05 Thread George Joseph
403390 Diff: https://reviewboard.asterisk.org/r/3043/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

[asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
This continues a conversation kharwell, mjordan and I were having on irc this morning concerning the implementation of the cli output formatting. Basically, I'm thinking that while we should absolutely re-use the underlying plumbing ( we don't need 2 versions of ast_sip_for_each_contact, for

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
On Fri, Dec 6, 2013 at 4:52 PM, Kevin Harwell kharw...@digium.com wrote: On Fri, 2013-12-06 at 14:21 -0700, George Joseph wrote: This continues a conversation kharwell, mjordan and I were having on irc this morning concerning the implementation of the cli output formatting. Basically

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-06 Thread George Joseph
On Fri, Dec 6, 2013 at 10:09 PM, Kevin Harwell kharw...@digium.com wrote: On Fri, Dec 6, 2013 at 7:09 PM, George Joseph george.jos...@fairview5.com wrote: On Fri, Dec 6, 2013 at 4:52 PM, Kevin Harwell kharw...@digium.comwrote: On Fri, 2013-12-06 at 14:21 -0700, George Joseph wrote: snip

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-07 Thread George Joseph
On Fri, Dec 6, 2013 at 11:53 PM, Kevin Harwell kharw...@digium.com wrote: On Fri, Dec 6, 2013 at 11:27 PM, George Joseph george.jos...@fairview5.com wrote: On Fri, Dec 6, 2013 at 10:09 PM, Kevin Harwell kharw...@digium.comwrote: On Fri, Dec 6, 2013 at 7:09 PM, George Joseph george.jos

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-09 Thread George Joseph
On Mon, Dec 9, 2013 at 8:49 AM, Kevin Harwell kharw...@digium.com wrote: On Sat, 2013-12-07 at 09:20 -0700, George Joseph wrote: snip It would be nice if endpoint stored all its object relationships the same way but it doesn't. It stores its related aors as a comma separated string

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-09 Thread George Joseph
On Mon, Dec 9, 2013 at 10:15 AM, Kevin Harwell kharw...@digium.com wrote: On Mon, 2013-12-09 at 09:17 -0700, George Joseph wrote: If Asterisk were completely OO we could create object factories, interfaces and implementation classes that hide all of that. Unfortunately, it's not. Also

[asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-16 Thread George Joseph
, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-17 Thread George Joseph
, 6:18 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3074/ --- (Updated Dec. 16, 2013, 6:18 p.m

[asterisk-dev] [Code Review] 3075: Add support for Lua 5.2

2013-12-17 Thread George Joseph
branches/1.8/configure 404041 Diff: https://reviewboard.asterisk.org/r/3075/diff/ Testing --- Tested configure, compile and basic lua run time with both lua 5.1 and lua 5.2 on Fedora 19 and Fedora 20 respectively. Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-17 Thread George Joseph
--- This patch has been in my production systems since July 2012. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-17 Thread George Joseph
-write out a '\' when we write out the config. George Joseph wrote: Hmmm. So the client would write a correctly escaped '\;', the 1724 patch would strip the backslash, then something later on would write it back again? How would 'something' tell the difference between a ';' that was escaped

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-19 Thread George Joseph
the combinations of actions and objects and made sure at least the correct objects are returned, there are no segfaults, errors, etc. I *think* the formatting is correct but I'll need some feedback. Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-19 Thread George Joseph
need some feedback. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-20 Thread George Joseph
--- On Dec. 19, 2013, 9:24 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043

Re: [asterisk-dev] Additional release checksums?

2013-12-22 Thread George Joseph
The *sum tools will test all lines in a checksum file and will return 0 if any match or 1 if none match. md5sum --quiet -c xxx.asc xxx.tar.gz sha1sum --quiet -c xxx.asc xxx.tar.gz sha256sum --quiet -c xxx.asc xxx.tar.gz where xxx.asc is

Re: [asterisk-dev] Additional release checksums?

2013-12-22 Thread George Joseph
. On 22 December 2013 16:11, George Joseph george.jos...@fairview5.comwrote: The *sum tools will test all lines in a checksum file and will return 0 if any match or 1 if none match. md5sum --quiet -c xxx.asc xxx.tar.gz sha1sum --quiet -c xxx.asc xxx.tar.gz sha256sum --quiet -c xxx.asc

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-01 Thread George Joseph
mimic some of the safe_asterisk settings... Nice=0 UMask=0002 LimitCORE=infinity LimitNOFILE=4096 Restart=always RestartSec=4 - George Joseph On Dec. 24, 2013, 9:49 a.m., Tzafrir Cohen wrote

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-01 Thread George Joseph
On Jan. 1, 2014, 9:43 a.m., George Joseph wrote: One other thing to consider... Unless /etc/asterisk is the working directory (which it shouldn't be), the LUA_PATH is going to need to be set or asterisk won't resolve lua script locations correctly. I handle this like so

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2014-01-01 Thread George Joseph
On Wed, Jan 1, 2014 at 4:31 PM, Oron Peled oron.pe...@xorcom.com wrote: On Wednesday 01 January 2014 10:23:01 Tzafrir Cohen wrote: I looked into running Asterisk as non-root. But I can't find a way to get systemd to generate /var/run/asterisk as a writable directory to the service. I

[asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-06 Thread George Joseph
branches/12/res/res_pjsip/config_auth.c 405000 branches/12/include/asterisk/res_pjsip_cli.h 405000 branches/12/include/asterisk/res_pjsip.h 405000 Diff: https://reviewboard.asterisk.org/r/3104/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3075: Add support for Lua 5.2

2014-01-08 Thread George Joseph
and Fedora 20 respectively. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2014-01-16 Thread George Joseph
--- I've gone through all the combinations of actions and objects and made sure at least the correct objects are returned, there are no segfaults, errors, etc. I *think* the formatting is correct but I'll need some feedback. Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/#review10595 --- On Jan. 6, 2014, 2:49 p.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
--- On Jan. 6, 2014, 2:49 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
--- On Jan. 6, 2014, 2:49 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-16 Thread George Joseph
/config_domain_aliases.c 405643 branches/12/res/res_pjsip/config_auth.c 405643 branches/12/include/asterisk/res_pjsip_cli.h 405643 branches/12/include/asterisk/res_pjsip.h 405643 Diff: https://reviewboard.asterisk.org/r/3104/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same

2014-01-17 Thread George Joseph
a test for disallow in the generic ast_sip_cli_print_sorcery_objset and given the meaning of disallow, the ! doesn't really make sense. It actually negates the disallow. :) - George Joseph On Jan. 17, 2014, 3:46 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same

2014-01-20 Thread George Joseph
On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: Not sure this is a good idea. First, I wouldn't hardcode a test for disallow in the generic ast_sip_cli_print_sorcery_objset and given the meaning of disallow, the ! doesn't really make sense. It actually negates the disallow

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same

2014-01-20 Thread George Joseph
On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: Not sure this is a good idea. First, I wouldn't hardcode a test for disallow in the generic ast_sip_cli_print_sorcery_objset and given the meaning of disallow, the ! doesn't really make sense. It actually negates the disallow

[asterisk-dev] [Code Review] 3143: pjsip_configuration: in ast_sip_auth_array_init, change assert(auths-names == NULL) to ast_sip_auth_array_destroy(auths)

2014-01-20 Thread George Joseph
. Diffs - branches/12/res/res_pjsip/pjsip_configuration.c 405922 Diff: https://reviewboard.asterisk.org/r/3143/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same

2014-01-21 Thread George Joseph
On Jan. 17, 2014, 4:46 p.m., George Joseph wrote: Not sure this is a good idea. First, I wouldn't hardcode a test for disallow in the generic ast_sip_cli_print_sorcery_objset and given the meaning of disallow, the ! doesn't really make sense. It actually negates the disallow

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-01-28 Thread George Joseph
branches/12/res/res_pjsip/config_domain_aliases.c 406802 branches/12/res/res_pjsip/config_auth.c 406802 branches/12/include/asterisk/res_pjsip_cli.h 406802 branches/12/include/asterisk/res_pjsip.h 406802 Diff: https://reviewboard.asterisk.org/r/3104/diff/ Testing --- Thanks, George

[asterisk-dev] Proposal for PJSIP TOS/COS and DSCP

2014-02-03 Thread George Joseph
As I was playing around with TOS/COS in pjsip last week I noticed some inconsistencies that I'd like to correct... There's a 'tos' parameter on the transport object but not only does it actually set DSCP instead of TOS, it sets it in pjproject only and therefore for signalling only. There are

Re: [asterisk-dev] [Code Review] 3136: cli: pjsip show endpoint endpoint shows allow/disallow codecs the same

2014-02-03 Thread George Joseph
. - George Joseph On Feb. 3, 2014, 1:18 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3136

[asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-05 Thread George Joseph
when res_pjsip was reloaded. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-05 Thread George Joseph
was reloaded. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk

Re: [asterisk-dev] [Code Review] 3143: pjsip_configuration: in ast_sip_auth_array_init, change assert(auths-names == NULL) to ast_sip_auth_array_destroy(auths)

2014-02-06 Thread George Joseph
and if not null, calls ast_sip_auth_array_destroy before initializing the array with the new values. Diffs - branches/12/res/res_pjsip/pjsip_configuration.c 405922 Diff: https://reviewboard.asterisk.org/r/3143/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
. Made sure that config_system was properly marked as 'not reloadable' and that it was maintaining it's original values when res_pjsip was reloaded. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
] START /main/sorcery/ - open END/main/sorcery/ - open Time: 1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: 1ms Result: PASS 43 Test(s) Executed 43 Passed 0 Failed Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
--- On Feb. 6, 2014, 12:55 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3184

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
END/main/sorcery/ - open Time: 1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: 1ms Result: PASS 43 Test(s) Executed 43 Passed 0 Failed Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
. - George --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3184/#review10799 --- On Feb. 6, 2014, 1:07 p.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
it to the instances container. Everyone else will search the instances container for the object to get a reference. George Joseph wrote: There's no concept of weak references so when the sorcery instance is linked to the registry container, the refcount gets bumped without the actual

Re: [asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

2014-02-06 Thread George Joseph
/config_domain_aliases.c 406802 branches/12/res/res_pjsip/config_auth.c 406802 branches/12/include/asterisk/res_pjsip_cli.h 406802 branches/12/include/asterisk/res_pjsip.h 406802 Diff: https://reviewboard.asterisk.org/r/3104/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
/sorcery/ - open Time: 1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: 1ms Result: PASS 43 Test(s) Executed 43 Passed 0 Failed Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
: PASS [snip] START /main/sorcery/ - open END/main/sorcery/ - open Time: 1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: 1ms Result: PASS 43 Test(s) Executed 43 Passed 0 Failed Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-06 Thread George Joseph
/ - open Time: 1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: 1ms Result: PASS 43 Test(s) Executed 43 Passed 0 Failed Thanks, George Joseph -- _ -- Bandwidth

[asterisk-dev] [Code Review] 3200: pjsip_cli: Memory leak in ast_sip_cli_print_sorcery_objectset

2014-02-07 Thread George Joseph
the command line. Added the 2 calls before the error and success returns. Diffs - branches/12/res/res_pjsip/pjsip_cli.c 407750 Diff: https://reviewboard.asterisk.org/r/3200/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3200: pjsip_cli: Memory leak in ast_sip_cli_print_sorcery_objectset

2014-02-07 Thread George Joseph
/config.c 407750 Diff: https://reviewboard.asterisk.org/r/3200/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] Proposal for PJSIP TOS/COS and DSCP

2014-02-10 Thread George Joseph
that might be better left as trunk only. Personally, I favor options 2 and 3. If the community feels differently though, I'm open to other approaches. On Mon, Feb 3, 2014 at 11:24 AM, George Joseph george.jos...@fairview5.com wrote: As I was playing around with TOS/COS in pjsip last week I

Re: [asterisk-dev] Proposal for PJSIP TOS/COS and DSCP

2014-02-10 Thread George Joseph
options 2 and 3. If the community feels differently though, I'm open to other approaches. I'd say Option 3 plus the ability to use the strings. They remove the ambiguity of whether a number is a DSCP or TOS value. On Mon, Feb 3, 2014 at 11:24 AM, George Joseph george.jos...@fairview5.com

[asterisk-dev] [Code Review] 3210: PJSIP_CLI: Add 'pjsip show registrations' and 'pjsip show contacts'

2014-02-11 Thread George Joseph
counterparts. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

[asterisk-dev] AMI and Sorcery

2014-02-11 Thread George Joseph
In the process of creating the dialplan function AST_SORCERY (a companion to AST_CONFIG) I've run into an issue with how AMI interacts with sorcery particularly related to objects that can have multiple occurrences of the same field like contact in aor and match in identify. Take a look at the

Re: [asterisk-dev] AMI and Sorcery

2014-02-13 Thread George Joseph
On Thu, Feb 13, 2014 at 5:38 AM, Joshua Colp jc...@digium.com wrote: On 14-02-12 03:26 AM, George Joseph wrote: In the process of creating the dialplan function AST_SORCERY (a companion to AST_CONFIG) I've run into an issue with how AMI interacts with sorcery particularly related

Re: [asterisk-dev] Second thoughts on proposed MWI behavior change in Asterisk 12

2014-02-20 Thread George Joseph
On Thu, Feb 20, 2014 at 8:29 AM, Mark Michelson mmichel...@digium.comwrote: Hi folks, Yesterday afternoon, I put up https://reviewboard.asterisk.org/r/3237/for review, and now I'm starting to question if it's a good idea or not. I suggest reading the full description of the proposed change,

Re: [asterisk-dev] [Code Review] 3210: PJSIP_CLI: Add 'pjsip show registrations' and 'pjsip show contacts'

2014-02-20 Thread George Joseph
/ Testing --- Commands show up in help and tab completion. Commands output the same as their list counterparts. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] [Code Review] 3200: pjsip_cli: Memory leak in ast_sip_cli_print_sorcery_objectset

2014-02-20 Thread George Joseph
/r/3200/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3184: Create sorcery instance registry

2014-02-20 Thread George Joseph
/sorcery/ - open Time: 1ms Result: PASS START /main/sorcery/ - wizard_registration END/main/sorcery/ - wizard_registration Time: 1ms Result: PASS 43 Test(s) Executed 43 Passed 0 Failed Thanks, George Joseph

Re: [asterisk-dev] Asterisk platform

2014-02-21 Thread George Joseph
On Fri, Feb 21, 2014 at 12:12 AM, Frank W. Miller fr...@frankwmiller.netwrote: Greetings, I'm thinking of porting Asterisk to a new ARM based platform. I was wondering if there are any gotchas I need to be aware of as I try it. Thanks, FM If you're compiling natively on the ARM

Re: [asterisk-dev] Asterisk platform

2014-02-21 Thread George Joseph
-- *From:* asterisk-dev-boun...@lists.digium.com [mailto: asterisk-dev-boun...@lists.digium.com] *On Behalf Of *George Joseph *Sent:* Friday, February 21, 2014 8:43 AM *To:* Asterisk Developers Mailing List *Subject:* Re: [asterisk-dev] Asterisk platform On Fri, Feb 21, 2014 at 12:12 AM

[asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-23 Thread George Joseph
one was failing before any changes. Not sure why. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-27 Thread George Joseph
] Tests: 66 Passed: 65 Failed: 1 FAILED: tests/channels/pjsip/hold/run-test The failed one was failing before any changes. Not sure why. Thanks, George Joseph -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-27 Thread George Joseph
--- On Feb. 27, 2014, 2:45 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3254

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-27 Thread George Joseph
] Tests: 66 Passed: 65 Failed: 1 FAILED: tests/channels/pjsip/hold/run-test The failed one was failing before any changes. Not sure why. Thanks, George Joseph -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-28 Thread George Joseph
On Feb. 27, 2014, 10:59 a.m., opticron wrote: branches/12/main/sorcery.c, lines 1101- https://reviewboard.asterisk.org/r/3254/diff/1/?file=54398#file54398line1101 Why not use the newly created ast_variable_list_append() here? George Joseph wrote: ast_variable_list_append

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-02-28 Thread George Joseph
: 66 Passed: 65 Failed: 1 FAILED: tests/channels/pjsip/hold/run-test The failed one was failing before any changes. Not sure why. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided

[asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-02 Thread George Joseph
://reviewboard.asterisk.org/r/3283/diff/ Testing --- Ran all 'pjsip show' and 'pjsip list' commands to make sure the output was correct. Ran testsuite tests/channels/pjsip/ami to make sure the AMI wasn't affected by the buffer and self-assignment fix. Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-03-05 Thread George Joseph
] Tests: 66 Passed: 65 Failed: 1 FAILED: tests/channels/pjsip/hold/run-test The failed one was failing before any changes. Not sure why. Thanks, George Joseph -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3304: pjsip configuration: Make TOS values for transports consistent in behavior to TOS values in endpoints. Allow DSCP strings to be used for TOS configuration. Fix A

2014-03-05 Thread George Joseph
. Looking forward to phase 2! - George Joseph On March 5, 2014, 1:19 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3304

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread George Joseph
by the buffer and self-assignment fix. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3254: sorcery: Create AST_SORCERY dialplan function (et. al.)

2014-03-06 Thread George Joseph
] Tests: 66 Passed: 65 Failed: 1 FAILED: tests/channels/pjsip/hold/run-test The failed one was failing before any changes. Not sure why. Thanks, George Joseph -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-08 Thread George Joseph
tests/channels/pjsip/ami to make sure the AMI wasn't affected by the buffer and self-assignment fix. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3317: pjsip: TOS/DSCP phase 2: Introduce DSCP equivalents to tos/tos_audio/tos_video and deprecate the existing tos options.

2014-03-08 Thread George Joseph
://reviewboard.asterisk.org/r/3317/#comment20790 The formatting now runs long by 2 characters. I'd make the space between cos and dscp only 1 character and adjust the format below to match. - George Joseph On March 7, 2014, 4:51 p.m., Jonathan Rose wrote

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

2014-03-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3324/#review11144 --- Ship it! Ship It! - George Joseph On March 10, 2014, 1:04

[asterisk-dev] [Code Review] 3382: RFC: Weak Reference Containers

2014-03-23 Thread George Joseph
the thrash test. I added 7 additional unit tests specifically for the weak-ref implementation including a performance comparison test that compares both strong and weak ref implementations. A thrash test was also added for weak-ref. Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3382: RFC: Weak Reference Containers

2014-03-23 Thread George Joseph
added for weak-ref. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3382: RFC: Weak Reference Containers

2014-03-24 Thread George Joseph
in test_astobj2 pass including the thrash test. I added 7 additional unit tests specifically for the weak-ref implementation including a performance comparison test that compares both strong and weak ref implementations. A thrash test was also added for weak-ref. Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3382: RFC: Weak Reference Containers

2014-03-25 Thread George Joseph
tests in test_astobj2 pass including the thrash test. I added 7 additional unit tests specifically for the weak-ref implementation including a performance comparison test that compares both strong and weak ref implementations. A thrash test was also added for weak-ref. Thanks, George Joseph

[asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

2014-03-27 Thread George Joseph
/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

2014-03-27 Thread George Joseph
411364 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

2014-03-27 Thread George Joseph
- branches/12/include/asterisk/lock.h 411364 branches/12/include/asterisk/autoconfig.h.in 411364 branches/12/configure.ac 411364 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability to lock.h

2014-03-28 Thread George Joseph
/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] Asterisk Test Suite Git Migration

2014-04-02 Thread George Joseph
On Wed, Apr 2, 2014 at 8:34 AM, Kevin Harwell kharw...@digium.com wrote: Hello everyone, Moving Asterisk to git has been talked about for some time now. However, before doing that we thought it might be easier to move the Asterisk test suite over first. The current plan is to keep

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-14 Thread George Joseph
branches/12/configure.ac 412327 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing (updated) --- See above. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-17 Thread George Joseph
/include/asterisk/autoconfig.h.in 412427 branches/12/configure.ac 412427 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- See above. Thanks, George Joseph

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-18 Thread George Joseph
/autoconfig.h.in 412427 branches/12/configure.ac 412427 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- See above. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-18 Thread George Joseph
--- On April 18, 2014, 5:09 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/ --- (Updated

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-19 Thread George Joseph
branches/12/configure.ac 412427 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- See above. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/#review11714 --- On April 19, 2014, 10:57 a.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread George Joseph
412900 branches/12/configure.ac 412900 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- See above. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/#review11716 --- On April 22, 2014, 12:35 p.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-22 Thread George Joseph
412900 branches/12/configure.ac 412900 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- See above. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-23 Thread George Joseph
/include/asterisk/autoconfig.h.in 412900 branches/12/configure.ac 412900 branches/12/configure UNKNOWN Diff: https://reviewboard.asterisk.org/r/3405/diff/ Testing --- See above. Thanks, George Joseph

[asterisk-dev] [Code Review] 3513: Weak Reference Containers

2014-04-30 Thread George Joseph
is a little more challenging but I at least made sure that all the test that passed before the change still passed after the change. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] Module pbx_lua not loading extensions.lua on startup

2014-05-14 Thread George Joseph
On Wed, May 14, 2014 at 2:58 PM, Dennis Guse dennis.g...@qu.tu-berlin.dewrote: Hi, using the pbx_lua module for almost everything we have found a little annoying bug. On Asterisk startup the module is loaded - however the configuration (extensions.lua) is not loaded and therefore the

Re: [asterisk-dev] URI parsing

2014-05-20 Thread George Joseph
On Tue, May 20, 2014 at 2:33 PM, Kevin Harwell kharw...@digium.com wrote: Greetings, For a task I have been working on in Asterisk I have found myself needing to parse URIs. Luckily, Asterisk is already using such a library [1], albeit limitedly. As the library also may not be installed

  1   2   3   4   5   6   7   8   9   >