Re: [asterisk-users] More issues with Siren14 datalen == 0 packets

2017-04-12 Thread Joshua Colp
On Wed, Apr 12, 2017, at 10:29 AM, Richard Kenner wrote: > > The feed function in slinfactory explicitly does not allow frames > > without a data payload to be added to the queue. It would have prevented > > this crash. > > Ah, so the fix should really be there, righty? Yes, it already takes

Re: [asterisk-users] More issues with Siren14 datalen == 0 packets

2017-04-12 Thread Richard Kenner
> The feed function in slinfactory explicitly does not allow frames > without a data payload to be added to the queue. It would have prevented > this crash. Ah, so the fix should really be there, righty? > I think the underlying issue is that the data pointer is not NULL when > it sanely should

Re: [asterisk-users] More issues with Siren14 datalen == 0 packets

2017-04-12 Thread Joshua Colp
On Wed, Apr 12, 2017, at 10:09 AM, Richard Kenner wrote: > > All patches need to go into JIRA with a license agreement to be > > accepted. > > Understood, but I was using it as an illustration. Note, however, that, > from a legal perspective, a patch such as this has no protectable IP (you >

Re: [asterisk-users] More issues with Siren14 datalen == 0 packets

2017-04-12 Thread Richard Kenner
> All patches need to go into JIRA with a license agreement to be > accepted. Understood, but I was using it as an illustration. Note, however, that, from a legal perspective, a patch such as this has no protectable IP (you can't copyright the only way of doing something) and the GNU projects

Re: [asterisk-users] More issues with Siren14 datalen == 0 packets

2017-04-12 Thread Joshua Colp
On Wed, Apr 12, 2017, at 09:50 AM, Richard Kenner wrote: > Another crash with a packet: > > $10 = {frametype = AST_FRAME_VOICE, subclass = {integer = 0, > format = 0x12c62170, frame_ending = 0}, datalen = 0, samples = 640, > mallocd = 1, mallocd_hdr_len = 324, offset = 64, > src =