Re: [PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

Doh, one small correction: > +@verbatim > +#include > +#ifdef MAJOR_IN_MKDEV > +# include > +#elif MAJOR_IN_SYSMACROS > +# include > +#endif > +@end verbatim That should be `#elif defined MAJOR_IN_SYSMACROS`. This was originally my mistake and I just realized it _was_ a mistake, sorry.

Re: [PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

On 09/14/2016 08:14 PM, Zack Weinberg wrote: > Doh, one small correction: > >> +@verbatim >> +#include >> +#ifdef MAJOR_IN_MKDEV >> +# include >> +#elif MAJOR_IN_SYSMACROS >> +# include >> +#endif >> +@end verbatim > > That should be `#elif defined MAJOR_IN_SYSMACROS`. This was > originally

[PATCH 2/2] sys_types: avoid glibc 2.25 warnings about major()

Todo: tweak sys_types_h.m4 comment before pushing glibc 2.25 is deprecating the namespace pollution of injecting major(), minor(), and makedev() into the compilation environment, with a warning that insists that users include instead. However, because the expansion of AC_HEADER_MAJOR didn't

[gnulib PATCH 0/2] Work around glibc 2.25 deprecation warnings

Fedora rawhide builds of libvirt.git at commit d53fa838^ failed due to the new glibc 2.25 deprecation warning for use of major() from just ; I also found that the same warning is provoked by gnulib's mountlist module. Libvirt commit d53fa838 was a temporary hack to work around the problem, and I

Re: [PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

On Wed, Sep 14, 2016 at 3:00 PM, Eric Blake wrote: > > Thanks for the wordsmithing help, and forcing me to think about > mingw. This version updates some wording, and changes the macro > to leave the relative order of mkdev.h vs. sysmacros.h checking > unchanged (by merely

Re: [PATCH] AC_USE_SYSTEM_EXTENSIONS: port to recent ISO C

On Wed, 14 Sep 2016, Paul Eggert wrote: > > (There are other feature test macros for > > ISO C extensions as well.) > > Thanks, is there a list of these new macros somewhere? I might as well add > them all now. ISO 24747 defines __STDC_WANT_MATH_SPEC_FUNCS__ (must be defined to expand to the

Re: [PATCH] AC_USE_SYSTEM_EXTENSIONS: port to recent ISO C

On 09/14/2016 05:55 AM, Joseph Myers wrote: Why not __STDC_WANT_IEC_60559_TYPES_EXT__ (which makes GCC 7's declare limits for _FloatN and _FloatNx types; not yet anything in glibc, until the float128 work is in)? Sorry, I didn't know about __STDC_WANT_IEC_60559_TYPES_EXT__. I don't have

[PATCH v2] AC_HEADER_MAJOR: port to glibc 2.25

glibc 2.25 is deprecating the namespace pollution of sys/types.h injecting major(), minor(), and makedev() into the compilation environment, with a warning that insists that users include instead. However, because the expansion of AC_HEADER_MAJOR didn't bother checking sys/sysmacros.h until

Re: [PATCH] AC_HEADER_MAJOR: port to glibc 2.25

Hi Eric, On 2016-09-14, Eric Blake wrote: [...] > * lib/autoconf/headers.m4 (AC_HEADER_MAJOR): Check for sysmacros.h > first, rather than after determining if sys/types.h pollutes the > namespace. > * doc/autoconf.texi (Particular Headers) : Expand > details on usage, and on

Re: [PATCH] AC_HEADER_MAJOR: port to glibc 2.25

On 09/14/2016 10:27 AM, Zack Weinberg wrote: > glibc's sys/sysmacros.h _only_ defines major/minor/makedev. What I'd > worry about is whether any other C library has a different header with > the same name; "sysmacros" is pretty generic. I don't have any > evidence either way on that question. >

Re: [PATCH] AC_HEADER_MAJOR: port to glibc 2.25

On Wed, Sep 14, 2016 at 9:26 AM, Eric Blake wrote: > glibc 2.25 is deprecating the namespace pollution of sys/types.h > injecting major(), minor(), and makedev() into the compilation > environment, with a warning that insists that users include > instead. However, because the

[PATCH] AC_HEADER_MAJOR: port to glibc 2.25

glibc 2.25 is deprecating the namespace pollution of sys/types.h injecting major(), minor(), and makedev() into the compilation environment, with a warning that insists that users include instead. However, because the expansion of AC_HEADER_MAJOR didn't bother checking sys/sysmacros.h until

Re: m4_divert_text

On 09/14/2016 07:26 AM, Russell Shaw wrote: > Hi, > > In binutils/configure.ac there is: > > m4_divert_text([PARSE_ARGS], > [case $srcdir in > *" "*) > m4_pushdef([AS_MESSAGE_LOG_FD], [])dnl > AC_MSG_ERROR([path to source, $srcdir, contains spaces]) > m4_popdef([AS_MESSAGE_LOG_FD])dnl >

m4_divert_text

Hi, In binutils/configure.ac there is: m4_divert_text([PARSE_ARGS], [case $srcdir in *" "*) m4_pushdef([AS_MESSAGE_LOG_FD], [])dnl AC_MSG_ERROR([path to source, $srcdir, contains spaces]) m4_popdef([AS_MESSAGE_LOG_FD])dnl ;; esac ac_subdirs_all=`cd $srcdir && echo */configure | sed

Re: [PATCH] AC_USE_SYSTEM_EXTENSIONS: port to recent ISO C

On Tue, 13 Sep 2016, Paul Eggert wrote: > * lib/autoconf/specific.m4 (AC_USE_SYSTEM_EXTENSIONS): > Also define __STDC_WANT_IEC_60559_BFP_EXT__, > __STDC_WANT_IEC_60559_FUNCS_EXT__, and __STDC_WANT_LIB_EXT2__. Why not __STDC_WANT_IEC_60559_TYPES_EXT__ (which makes GCC 7's declare limits for