[FYI] m4sugar: fix AS_VAR_GET regression.

2013-01-29 Thread Gary V. Vaughan
AS_VAR_GET expands AS_ECHO inside en evaled single quoted string, which causes the single quotes in printf '%s\n' to expose the %s\n to the shell which expands \n to simply n before passing it to printf. * lib/m4sugar/m4sh.m4 (AS_ECHO): Use double quotes around the format string. *

Re: [FYI] m4sugar: fix AS_VAR_GET regression.

2013-01-29 Thread Peter Rosin
On 2013-01-29 13:27, Gary V. Vaughan wrote: AS_VAR_GET expands AS_ECHO inside en evaled single quoted string, which causes the single quotes in printf '%s\n' to expose the %s\n to the shell which expands \n to simply n before passing it to printf. * lib/m4sugar/m4sh.m4 (AS_ECHO): Use double

Re: [FYI] m4sugar: fix AS_VAR_GET regression.

2013-01-29 Thread Gary V. Vaughan
Hi Peter, On 29 Jan 2013, at 20:17, Peter Rosin p...@lysator.liu.se wrote: On 2013-01-29 13:27, Gary V. Vaughan wrote: Normally, @command{printf} is safer and easier to use than @command{echo} -and @command{echo -n}. Thus, you should use @command{printf '%s\n'} +and @command{echo -n}.

Re: [FYI] m4sugar: fix AS_VAR_GET regression.

2013-01-29 Thread Peter Rosin
On 2013-01-29 14:31, Gary V. Vaughan wrote: Hi Peter, On 29 Jan 2013, at 20:17, Peter Rosin p...@lysator.liu.se wrote: On 2013-01-29 13:27, Gary V. Vaughan wrote: Normally, @command{printf} is safer and easier to use than @command{echo} -and @command{echo -n}. Thus, you should use

Re: [PATCHv3] m4sugar: factor away _AS_ECHO_PREPARE.

2013-01-29 Thread Stefano Lattarini
Hello everybody, sorry for the late review. On 01/29/2013 07:17 AM, Gary V. Vaughan wrote: Incorporating feedback from Paul and Paul. Thank you both :) Okay to push? printf '%s\n' ... has been a fine replacement for plain echo for at least 5 years (probably more like 10), even with most

Re: [PATCHv3] m4sugar: factor away _AS_ECHO_PREPARE.

2013-01-29 Thread Nick Bowler
On 2013-01-29 19:26 +0100, Stefano Lattarini wrote: On 01/29/2013 07:17 AM, Gary V. Vaughan wrote: [...] # Find who we are. Look in the path if we contain no directory separator. @@ -1023,63 +1025,15 @@ fi # Output WORD followed by a newline. WORD must be a single shell word #

Re: [PATCHv3] m4sugar: factor away _AS_ECHO_PREPARE.

2013-01-29 Thread Stefano Lattarini
On 01/29/2013 08:05 PM, Nick Bowler wrote: On 2013-01-29 19:26 +0100, Stefano Lattarini wrote: On 01/29/2013 07:17 AM, Gary V. Vaughan wrote: [...] # Find who we are. Look in the path if we contain no directory separator. @@ -1023,63 +1025,15 @@ fi # Output WORD followed by a newline.

Re: [PATCHv3] m4sugar: factor away _AS_ECHO_PREPARE.

2013-01-29 Thread Stefano Lattarini
On 01/29/2013 08:59 PM, Eric Blake wrote: On 01/29/2013 11:26 AM, Stefano Lattarini wrote: Hello everybody, sorry for the late review. On 01/29/2013 07:17 AM, Gary V. Vaughan wrote: Incorporating feedback from Paul and Paul. Thank you both :) @@ -461,6 +460,9 @@