bug#7403: Unused variable `$source' in the depcomp script?

2010-11-14 Thread Stefano Lattarini
Hello automakers. In the git master branch: $ grep '\source\' lib/depcomp source Source file read by `PROGRAMS ARGS'. if test -z $depmode || test -z $source || test -z $object; then echo depcomp: Variables source, object and depmode must be set 12 # the object too, otherwise

Re: User extensions

2010-11-14 Thread Stefano Lattarini
Hello Pippijn. On Saturday 13 November 2010, Pippijn van wrote: On Mon, Nov 01, 2010 at 08:18:44PM +0100, Ralf Wildenhues wrote: Ideally, I would like to see testsuite coverage for each code path (branch coverage) for new code. I understand that only Stefano is able to produce this in

[PATCH] {master} Extend and improve tests on DejaGnu support.

2010-11-14 Thread Stefano Lattarini
Another testsuite patch, based off of maint, but to be merged in master only. I will wait the customary 72 hours before pushing. Regards, Stefano -*-*-*- Extend and improve tests on DejaGnu support. * tests/dejagnu.test: Do not create useless dummy test script. Add trailing `:' command.

Re: User extensions

2010-11-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Nov 14, 2010 at 01:36:16PM CET: But it's not like I have a silver bullet to write proper tests which attain complete branch coverage; I just proceed by common sense, trying to maximize such coverage. That's all, sadly. A while ago I posted instructions on how

Re: User extensions

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sun, Nov 14, 2010 at 01:36:16PM CET: But it's not like I have a silver bullet to write proper tests which attain complete branch coverage; I just proceed by common sense, trying to maximize such coverage.

Re: [PATCH 2/3] aclocal: remove @automake_includes

2010-11-14 Thread Ralf Wildenhues
Hi Paolo, * Paolo Bonzini wrote on Tue, Nov 09, 2010 at 08:14:39PM CET: This patch simplifies the overly complicated rules for ACLOCAL_PATH vs. @automake_includes and @system_includes, by stating that ACLOCAL_PATH will override even @automake_includes. The simplest way to achieve this is to

tests: work around dash quoting issue in case statements.

2010-11-14 Thread Ralf Wildenhues
Apparently, dash 0.5.5.1 has some problems with avoiding expansion in case patterns when unusual characters are involved. I'm committing the following patch to maint to let these tests PASS instead of SKIP with this shell. Thanks, Ralf tests: work around dash quoting issue in case

Re: Fix install-strip when $(STRIP) contains several words.

2010-11-14 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Nov 01, 2010 at 10:25:02PM CET: Fix install-strip when $(STRIP) contains several words. * lib/am/install.am (install-strip): Update comment. Use separate sub-make invocations for empty and nonempty $(STRIP), to fix quoting issues. *

Re: [PATCH 2/3] aclocal: remove @automake_includes

2010-11-14 Thread Paolo Bonzini
On 11/14/2010 05:46 PM, Ralf Wildenhues wrote: Hi Paolo, * Paolo Bonzini wrote on Tue, Nov 09, 2010 at 08:14:39PM CET: This patch simplifies the overly complicated rules for ACLOCAL_PATH vs. @automake_includes and @system_includes, by stating that ACLOCAL_PATH will override even

Rebuild menus in the manual.

2010-11-14 Thread Ralf Wildenhues
I'm committing this to maint, and merging to branch-1.11 and master. Thanks, Ralf Rebuild menus in the manual. * doc/automake.texi: Rebuild menus (using ^C ^U ^A in emacs). Thanks to Ian Lance Taylor for the suggestion. diff --git a/doc/automake.texi b/doc/automake.texi index

Re: [PATCH] {maint} Improve and extend tests on de-ansification support.

2010-11-14 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 10:59:22AM CEST: But since we are at it, we can do better, extending coverage and making existing tests more semantic. See the attached patch (for maint). ansi2knr is a really dying (and ugly) feature; when have we last seen a

Re: [PATCH] Enable `set -e' in more tests (plus some tweakings).

2010-11-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Nov 11, 2010 at 03:52:39PM CET: Pinging this patch again, following this: http://lists.gnu.org/archive/html/automake-patches/2010-11/msg3.html Patch is OK. I didn't check whether any of the tests contained constructs problematic for set -e. I'll wait

testsuite results from master

2010-11-14 Thread Ralf Wildenhues
Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. I'd like to ask you to postpone pushes of pending stuff that has a clock ticking, and look at the lots of new failures that a testsuite run shows on a few hosts; you can find them in some

Re: testsuite results from master

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. I'd like to ask you to postpone pushes of pending stuff that has a clock ticking, and look at the lots of new failures that a

Testsuite failures on AIX 5.3 (was: testsuite results from master)

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. I'd like to ask you to postpone pushes of pending stuff that has a clock ticking, and look at the lots of new failures that a

Testsuite failures on Solaris 2.10 on SPARC (was: testsuite results from master)

2010-11-14 Thread Stefano Lattarini
[Reposting with a better subject. Sorry for the noise.] On Sunday 14 November 2010, Ralf Wildenhues wrote: Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. I'd like to ask you to postpone pushes of pending stuff that has a clock

Re: testsuite results from master

2010-11-14 Thread Stefano Lattarini
Please disregard; answer to the message Testsuite failures on Solaris 2.10 on SPARC instead. Sorry for the noise, Stefano

Re: testsuite results from master

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. Do you mean go and fix the newly introduced regressions before doing other testsuite work, or reconsider the advisability of doing

Testsuite failures on HP-UX 11.23 (was: Re: testsuite results from master)

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. I'd like to ask you to postpone pushes of pending stuff that has a clock ticking, and look at the lots of new failures that a

Testsuite results on FreeBSD 6.4 on i386 (was: testsuite results from master)

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. I'd like to ask you to postpone pushes of pending stuff that has a clock ticking, and look at the lots of new failures that a

Re: Testsuite failures on Tru64 OSF 5.1

2010-11-14 Thread Stefano Lattarini
On Monday 15 November 2010, Peter Rosin wrote: Running MSVC on osfX.Y is not interesting. I'd write a patch to skip the test Yeah, I agree this is the best option. but I can't then test the result. Me neither (I don't have access to a True64/OSF system). So I won't... Neither will I ;-)

Testsuite failures on IRIX 6.5 (was: testsuite results from master)

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: Hello Stefano, I think it is time to reevaluate some of the work that has been done in the last few weeks. I'd like to ask you to postpone pushes of pending stuff that has a clock ticking, and look at the lots of new failures that a

[PATCH] tests/yaccdry.test ($required): Require bison. (was: Re: More problems with `make -n' in automake-generated rules.)

2010-11-14 Thread Stefano Lattarini
I'm seeing this failure in test yaccdry.test at the Hydra continuous build system for automake: http://hydra.nixos.org/build/745050/log FAIL: yaccdry.test (exit: 2)

Re: [PATCH] {maint} Improve and extend tests on de-ansification support.

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: Hi Stefano, * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 10:59:22AM CEST: But since we are at it, we can do better, extending coverage and making existing tests more semantic. See the attached patch (for maint). ansi2knr is a

Re: testsuite results from master

2010-11-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 12:19:00AM CET: On Sunday 14 November 2010, Ralf Wildenhues wrote: I think it is time to reevaluate some of the work that has been done in the last few weeks. Do you mean go and fix the newly introduced regressions before doing other

Re: User extensions

2010-11-14 Thread Stefano Lattarini
Hello Pippijn. On Saturday 13 November 2010, Pippijn van wrote: On Mon, Nov 01, 2010 at 08:18:44PM +0100, Ralf Wildenhues wrote: Ideally, I would like to see testsuite coverage for each code path (branch coverage) for new code. I understand that only Stefano is able to produce this in

Re: User extensions

2010-11-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Nov 14, 2010 at 01:36:16PM CET: But it's not like I have a silver bullet to write proper tests which attain complete branch coverage; I just proceed by common sense, trying to maximize such coverage. That's all, sadly. A while ago I posted instructions on how

Re: builddir

2010-11-14 Thread Ralf Wildenhues
Hello Russell, * Russell Shaw wrote on Sun, Nov 14, 2010 at 02:49:07AM CET: In a Makefile.in generated by automake 1.9.6, it defines top_builddir ok, but builddir is used but not defined in there. This causes problems, because the automake manual says: — Variable: builddir Rigorously

Re: User extensions

2010-11-14 Thread Stefano Lattarini
On Sunday 14 November 2010, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Sun, Nov 14, 2010 at 01:36:16PM CET: But it's not like I have a silver bullet to write proper tests which attain complete branch coverage; I just proceed by common sense, trying to maximize such coverage.

Re: builddir

2010-11-14 Thread Russell Shaw
On 15/11/10 01:10, Ralf Wildenhues wrote: Hello Russell, * Russell Shaw wrote on Sun, Nov 14, 2010 at 02:49:07AM CET: In a Makefile.in generated by automake 1.9.6, it defines top_builddir ok, but builddir is used but not defined in there. This causes problems, because the automake manual

Re: ACLOCAL best practice

2010-11-14 Thread Ralf Wildenhues
Hello Ryan, * Ryan Lortie wrote on Sat, Nov 13, 2010 at 05:49:57PM CET: I recently filed a bug against a freedesktop.org component because it didn't honour the ACLOCAL_FLAGS environment variable. That bug got closed, telling me to use ACLOCAL like so: ACLOCAL='aclocal -I

Re: [Vala] automake 1.11.1: unable to build vala project out-of-tree

2010-11-14 Thread Abderrahim Kitouni
Hello, في ح، 07-11-2010 عند 09:12 +0300 ، كتب Andrey Borzenkov: Automake assumes the .c files generated by vala are distributed with the source, and this isn't true when building from git. A solution is to do an in-tree build, make distclean, and re-run your out-of-tree