Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly

2011-02-21 Thread Stefano Lattarini
Stefano Lattarini wrote on Wed, Feb 16, 2011 at 09:26:17PM CET: tests: tempdirs with restrictive permissions are cleaned correctly Before this change, the removal of a temporary test directory containing subdirectories with restrictive permissions (such as 'r--r--r--') could fail. *

Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly

2011-02-21 Thread Eric Blake
On 02/20/2011 04:39 AM, Stefano Lattarini wrote: - find $$@ -type d '!' -perm -200 -exec chmod u+w {} ';'; \ + find $$@ -type d ! -perm -700 -exec chmod u+rwx {} ';'; \ rm -rf $$@; \ fi; please don't remove the quoting from the ! here. It exists to facilitate copy and

Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly

2011-02-21 Thread Stefano Lattarini
Hello Eric. On Monday 21 February 2011, Eric Blake wrote: On 02/20/2011 04:39 AM, Stefano Lattarini wrote: -find $$@ -type d '!' -perm -200 -exec chmod u+w {} ';'; \ +find $$@ -type d ! -perm -700 -exec chmod u+rwx {} ';'; \ rm -rf $$@; \ fi; please don't remove the

Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly

2011-02-20 Thread Stefano Lattarini
On Saturday 19 February 2011, Ralf Wildenhues wrote: Hi Stefano, Hello Ralf. I have a doubt about your objection ... sorry for the silence, I've been traveling. My plan is to do slowly but steady catchup over the next week(end)s ... * Stefano Lattarini wrote on Wed, Feb 16, 2011 at

Re: [PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly

2011-02-19 Thread Ralf Wildenhues
Hi Stefano, sorry for the silence, I've been traveling. My plan is to do slowly but steady catchup over the next week(end)s ... * Stefano Lattarini wrote on Wed, Feb 16, 2011 at 09:26:17PM CET: * tests/defs: Ensure that all the subdirectories of a temporary test directory have the 'read',

[PATCH] {maint} tests: tempdirs with restrictive permissions are cleaned correctly

2011-02-16 Thread Stefano Lattarini
Hello automakers. Before this change, the removal of a temporary test directory containing subdirectories with restrictive permissions (such as 'r--r--r--') could fail. Here is a minimal example of the issue just described. $ cd ~/src/automake/tests $ cat foo.test 'END' . ./defs mkdir