Re: bug#7944: Should AM_PATH_PYTHON call AC_ARG_VAR?

2011-02-15 Thread Stefano Lattarini
On Tuesday 15 February 2011, Ralf Wildenhues wrote: Sorry, I'm probably just making myself not clear. Here's a patch that I would squash in on top of your patch, and that I think addresses all issues that I mention in my review. It basically reverses the doc part of your patch and then

Re: bug#7944: Should AM_PATH_PYTHON call AC_ARG_VAR?

2011-02-14 Thread Stefano Lattarini
On Monday 14 February 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Mon, Feb 14, 2011 at 12:35:17PM CET: On Friday 11 February 2011, Ralf Wildenhues wrote: There are a couple of things that I think could be better. One sentence as a paragraph on its own isn't too pretty.

Re: bug#7944: Should AM_PATH_PYTHON call AC_ARG_VAR?

2011-02-14 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Feb 15, 2011 at 12:37:58AM CET: On Monday 14 February 2011, Ralf Wildenhues wrote: * Stefano Lattarini wrote on Mon, Feb 14, 2011 at 12:35:17PM CET: On Friday 11 February 2011, Ralf Wildenhues wrote: There are a couple of things that I think could

Re: bug#7944: Should AM_PATH_PYTHON call AC_ARG_VAR?

2011-02-11 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Feb 10, 2011 at 10:59:45AM CET: On Sunday 06 February 2011, Ralf Wildenhues wrote: The patch is OK with nits addressed, and without the doc/automake.texi change. I will review that separately later, don't want to delay the good part because of that any

Re: bug#7944: Should AM_PATH_PYTHON call AC_ARG_VAR?

2011-02-07 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Jan 31, 2011 at 09:31:37PM CET: On Monday 31 January 2011, Jack Kelly wrote: I've noticed that if you put AM_PATH_PYTHON in configure.ac, it doesn't add an entry for PYTHON in ./configure --help. Is PYTHON meant to be a user's variable?

Re: bug#7944: Should AM_PATH_PYTHON call AC_ARG_VAR?

2011-01-31 Thread Stefano Lattarini
On Monday 31 January 2011, Jack Kelly wrote: Hi automakers, I've noticed that if you put AM_PATH_PYTHON in configure.ac, it doesn't add an entry for PYTHON in ./configure --help. Is PYTHON meant to be a user's variable? According to the comments in `m4/python.m4' and to the tests

Re: bug#7944: Should AM_PATH_PYTHON call AC_ARG_VAR?

2011-01-31 Thread Stefano Lattarini
On Monday 31 January 2011, Jack Kelly wrote: On Tue, Feb 1, 2011 at 7:31 AM, Stefano Lattarini stefano.lattar...@gmail.com wrote: On Monday 31 January 2011, Jack Kelly wrote: I've noticed that if you put AM_PATH_PYTHON in configure.ac, it doesn't add an entry for PYTHON in ./configure

Re: bug#7944: Should AM_PATH_PYTHON call AC_ARG_VAR?

2011-01-31 Thread Jack Kelly
On Tue, Feb 1, 2011 at 7:31 AM, Stefano Lattarini stefano.lattar...@gmail.com wrote: On Monday 31 January 2011, Jack Kelly wrote: I've noticed that if you put AM_PATH_PYTHON in configure.ac, it doesn't add an entry for PYTHON in ./configure --help. Is PYTHON meant to be a user's variable?