Re: [Ayatana-dev] unity 5.0 and lenses

2012-01-20 Thread Mikkel Kamstrup Erlandsen
On 01/19/2012 11:19 AM, David Callé wrote: On 19/01/2012 01:13, Andrea Pocosgnich wrote: Hi everybody, I have a question for you (I hope this is the right place): i've just installed unity 5.0 on mi Ubuntu 11.10 (3.2.0-9-generic-pae) and i can tell you that is fantastic, very fast, but I

[Ayatana-dev] Home lens status update

2012-01-20 Thread Mikkel Kamstrup Erlandsen
Hey all, Been hacking frantically to get the HomeLens class in UnityCore working smoothly, and I think I am just about there. I'll just add a few more tests and it's ready for mp. If you wanna peek you need all the branches from: https://bugs.launchpad.net/ubuntu/+source/unity/+bug/885738

[Ayatana-dev] libunity-core ABI policy?

2012-01-16 Thread Mikkel Kamstrup Erlandsen
Hi, I am working on a solution to https://bugs.launchpad.net/unity-lens-files/+bug/885738 and I was wondering what ABI policy we have on libunity-core? Specifically; I am implementing a subclass of Lens, HomeLens, that will make it possible to use the standard lens rendering path on the

Re: [Ayatana-dev] Please help to debug Nautilus quicklist patch

2011-12-16 Thread Mikkel Kamstrup Erlandsen
On 12/15/2011 07:05 PM, Dmitry Shachnev wrote: Hello! I've been working on implementing a dynamic bookmarks quicklist [1] for Nautilus, but encountered some problems related to DBusMenu/Unity API. Can someone help me to debug that and say what I'm doing wrong? Here is my patch applied against

Re: [Ayatana-dev] QUnitySettings: managing Unity-2D settings with gconf and gsettings support

2011-12-16 Thread Mikkel Kamstrup Erlandsen
On 12/16/2011 02:27 AM, a.gra...@gmail.com wrote: Hi all, this evening I had a quick chat with Andrea Azzarone and we talked about Unity settings. We both agreed that while Unity has lot of configurable settings (actually done with gconf but you're migrating to gsettings), Unity-2D has not

Re: [Ayatana-dev] Apps searching and X-GNOME-Keywords

2011-12-07 Thread Mikkel Kamstrup Erlandsen
On 12/07/2011 05:38 AM, Marco Trevisan (Treviño) wrote: Il 07 dicembre 2011 01:56, Tim Penheytim.pen...@canonical.com ha scritto: This sounds like an awesome idea. Agree. Does the ubuntu community team have a unity person again? I know they were hiring. That person would be ideal to

[Ayatana-dev] Apps searching and X-GNOME-Keywords

2011-12-06 Thread Mikkel Kamstrup Erlandsen
Hi all, Seems we have a steady flow of bugs coming in from people that can't find their apps despite typing sensible strings into the search box. Fx. internet does not find Firefox and music does not find Banshee. Example bugs: https://bugs.launchpad.net/unity-lens-applications/+bug/833610

Re: [Ayatana] Unity Lenses API: View customization

2011-11-22 Thread Mikkel Kamstrup Erlandsen
On 11/22/2011 11:11 AM, Owas Lone wrote: Hello, With all the cool lensed being made by the likes of David Callé (are you here??), I've felt the the lenses need should allow the the programmer to drop to nux and render the view himself. Seriously, everything doesn't fit in well with an

Re: [Ayatana-dev] ubuntu lacks ideas, firefox is full of ideas

2011-11-21 Thread Mikkel Kamstrup Erlandsen
On 11/18/2011 09:20 PM, Pedro Bessa wrote: Hi Anytana-dev, That would be ayatana-dev :-) I can change Firefox in any way. I can position, edit, remove and add any interface element however I think is useful to the others. So I created two

Re: [Ayatana] Serious issues

2011-11-03 Thread Mikkel Kamstrup Erlandsen
On 11/03/2011 01:50 AM, Jo-Erlend Schinstad wrote: We have really serious issues with Unity. For instance, look at the attached screenshot. Can you please include a descriptive subject line and an actual explanation of the perceived problem in your email another time? Consider that you are

Re: [Ayatana] dash home redesign

2011-10-31 Thread Mikkel Kamstrup Erlandsen
On 10/21/2011 07:36 PM, Josh Strawbridge wrote: the dash home is one of my only 3 gripes about unity in 11.10. i found unity usable but not likable in 11.04 but i find with the added polish it's somewhat enjoyable now. my problem with dash home is that it isn't very useful the way it is

Re: [Ayatana] Music lens - Available for Purchase

2011-10-13 Thread Mikkel Kamstrup Erlandsen
On 10/13/2011 02:40 AM, Remco wrote: On Tue, Oct 11, 2011 at 12:20, a.gra...@gmail.coma.gra...@gmail.com wrote: Hi, On 11 October 2011 00:58, Thibaut Brandscheidrandal...@web.de wrote: Houston, we have a problem I think there should be a section called Privacy in the Control Panel where

Re: [Ayatana] Music lens - Available for Purchase

2011-10-11 Thread Mikkel Kamstrup Erlandsen
On 10/11/2011 02:00 AM, Evan Huus wrote: snip A bigger concern from my point of view though is that all generic searches (using the Home lens) go through the music lens as well, and thus (I assume) through this internet search. This is not the case. The U1 store will only be queried when you

Re: [Ayatana] something wrong ??

2011-10-05 Thread Mikkel Kamstrup Erlandsen
On 10/05/2011 05:03 AM, Jo-Erlend Schinstad wrote: Shouldn't direct hits on package names always be ranked highest? In this case, I think MultiGet should be displayed before others when you type multi. Right now multi is not a direct hit on the string MultiGet as MultiGet is considered when

Re: [Ayatana] something wrong ??

2011-10-05 Thread Mikkel Kamstrup Erlandsen
On 10/04/2011 10:57 AM, Matthew Paul Thomas wrote: Mikkel Kamstrup Erlandsen wrote on 03/10/11 14:16: On 10/03/2011 03:06 PM, Mikkel Kamstrup Erlandsen wrote: On 10/03/2011 01:26 PM, Anup Verma wrote: ... Let us search for MultiGet. When I write Mult in the search MultiGet appears

Re: [Ayatana] RFC: How to handle wine apps in Unity?

2011-10-04 Thread Mikkel Kamstrup Erlandsen
the way to go. The new APIs in 11.10 should make it relatively easy to get a scope and lens up and running. On Mon, Oct 3, 2011 at 02:43, Mikkel Kamstrup Erlandsen mikkel.kamst...@canonical.com mailto:mikkel.kamst...@canonical.com mailto:mikkel.kamst...@canonical.com

Re: [Ayatana] RFC: How to handle wine apps in Unity?

2011-10-04 Thread Mikkel Kamstrup Erlandsen
On 10/04/2011 07:35 PM, Alex Launi wrote: It's probably worth while to CC some wine developers on this. It may be good to work this out with them, because if there's no current way- we can work one out. We have a member of the Ubuntu Wine Team chiming in on the bug. But it may be a god idea

[Ayatana] RFC: How to handle wine apps in Unity?

2011-10-03 Thread Mikkel Kamstrup Erlandsen
Hi all, I am thinking through bug https://bugs.launchpad.net/unity-lens-applications/+bug/753276 Currently no way to find wine apps in dash other than searching them from search bar, and I think it would be helpful with some good suggestions on the matter. Disclaimer: I am not gonna be the

Re: [Ayatana] something wrong ??

2011-10-03 Thread Mikkel Kamstrup Erlandsen
On 10/03/2011 01:26 PM, Anup Verma wrote: Friends, don't you find any problem with the algorithm used to search in the software center. Giving you an example: Let us search for MultiGet. When I write Mult in the search MultiGet appears at the 6th position. As soon as I add 'i', I see that

Re: [Ayatana] something wrong ??

2011-10-03 Thread Mikkel Kamstrup Erlandsen
On 10/03/2011 03:06 PM, Mikkel Kamstrup Erlandsen wrote: On 10/03/2011 01:26 PM, Anup Verma wrote: Friends, don't you find any problem with the algorithm used to search in the software center. Giving you an example: Let us search for MultiGet. When I write Mult in the search MultiGet appears

Re: [Ayatana-dev] Annoying Unity bug - windows moving when on edge of workspace

2011-09-26 Thread Mikkel Kamstrup Erlandsen
On 09/26/2011 02:14 AM, Stephen Rees-Carter wrote: Hi all, There is a Unity bug which has been annoying me since Natty, that I'd love to see get some attention and fixed. https://bugs.launchpad.net/unity/+bug/834248 Non-maximized windows which sit on the bottom edge of the lower workspaces

Re: [Ayatana] Dash search vs Alt+F2 in 11.10

2011-09-26 Thread Mikkel Kamstrup Erlandsen
On 09/22/2011 08:46 PM, Jo-Erlend Schinstad wrote: Den 22. sep. 2011 20:40, skrev Alex Launi: Can someone explain why we think we want the ability to run rm directly from unity anyway? Is there a single person who wants this functionality who doesn't have a terminal open all of the time

Re: [Ayatana] Dash search vs Alt+F2 in 11.10

2011-09-22 Thread Mikkel Kamstrup Erlandsen
On 09/22/2011 01:19 PM, Naba Kumar wrote: Hi, I use Alt+F2 a lot to launch apps and at the same time the dash search to launch apps is an awesome feature. But in 11.10, Alt+f2 is different from dash-search (although they look similar). Dash search is where I click the ubuntu launcher, type the

[Ayatana-dev] More JHBuild Goodness for Unity

2011-09-06 Thread Mikkel Kamstrup Erlandsen
Hi all, With a bit of help from Sam I got the Unity JHBuild module to cleanly build the entire Compiz stack as well - keeping *everything* installed and running cleanly under ~/unity/install. This comes in very handy when fx. debugging branches requiring ABI breaks etc (i am looking at you

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-session/lp747818 into lp:indicator-session

2011-04-14 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve -- https://code.launchpad.net/~ted/indicator-session/lp747818/+merge/57524 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-datetime/update-after-resume into lp:indicator-datetime

2011-04-14 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve This code could be simplified a great deal by just using g_dbus_connection_signal_subscribe() (that would also stop us from leaking that proxy), but probably not a good idea to start a refactoring at this point in the cycle :-) --

Re: [Ayatana] Compiz default animations are too fast

2011-04-06 Thread Mikkel Kamstrup Erlandsen
On Wed, 2011-04-06 at 01:25 -0400, Melvin Garcia wrote: Hi guys/gals. My name is Melvin Garcia, and I'm new to the list. I was comparing Mac's Quartz and Windows' Aero animations to Ubuntu's default animation settings and noticed a few things. First of all Ubuntu's animations are too fast,

Re: [Ayatana] Lenses need a method to provide attribution for APIs

2011-04-06 Thread Mikkel Kamstrup Erlandsen
On Tue, 2011-04-05 at 12:00 +0200, Stefano wrote: It seems that a lot of lenses are going to use various web APIs, some of which require attribution. My hypothesis is that people will start to abuse features, such as groups, to provide attribution when they must. It should therefore be a

Re: [Ayatana] Compiz default animations are too fast

2011-04-06 Thread Mikkel Kamstrup Erlandsen
or something where you can definitely perceive the animations. I am totally with you - animations must be very quick subtle hints. What needs consideration is why we drop frames. Cheers, Mikkel On Apr 6, 2011 1:55 AM, Mikkel Kamstrup Erlandsen mikkel.kamst...@canonical.com wrote: On Wed, 2011-04

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-session/lp745323 into lp:indicator-session

2011-04-05 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve -- https://code.launchpad.net/~ted/indicator-session/lp745323/+merge/56285 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_746962 into lp:indicator-me

2011-04-05 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve -- https://code.launchpad.net/~ken-vandine/indicator-me/lp_746962/+merge/56209 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_739319 into lp:indicator-me

2011-03-29 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve -- https://code.launchpad.net/~ken-vandine/indicator-me/lp_739319/+merge/55367 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/grrr-use-right-interfaces into lp:dbusmenu

2011-03-01 Thread Mikkel Kamstrup Erlandsen
Review: Approve Looks good to me -- https://code.launchpad.net/~ted/dbusmenu/grrr-use-right-interfaces/+merge/51431 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/use-correct-i18n into lp:dbusmenu

2011-03-01 Thread Mikkel Kamstrup Erlandsen
Review: Approve -- https://code.launchpad.net/~ted/dbusmenu/use-correct-i18n/+merge/51430 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/signals-do-crazy-shit into lp:dbusmenu

2011-02-25 Thread Mikkel Kamstrup Erlandsen
Review: Approve -- https://code.launchpad.net/~ted/dbusmenu/signals-do-crazy-shit/+merge/51246 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/handle-event-signal into lp:dbusmenu

2011-02-24 Thread Mikkel Kamstrup Erlandsen
Review: Approve I like! -- https://code.launchpad.net/~ted/dbusmenu/handle-event-signal/+merge/50785 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/handle-event-signal into lp:dbusmenu

2011-02-23 Thread Mikkel Kamstrup Erlandsen
Review: Needs Information It may be a good idea to follow the standard gtk event model here - use a signal which returns a gboolean TRUE if event propogation should be stopped? Now that GLib has a build in accumulator g_signal_accumulator_true_handled this should be fairly easy. --

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/signature-fixes into lp:dbusmenu

2011-02-23 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve -- https://code.launchpad.net/~ted/dbusmenu/signature-fixes/+merge/50767 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-application/love-null-pointers into lp:indicator-application

2011-02-21 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve zomg its teh nul! -- https://code.launchpad.net/~ted/indicator-application/love-null-pointers/+merge/50434 Your team ayatana-commits is subscribed to branch lp:indicator-application. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-datetime/bug714763 into lp:indicator-datetime

2011-02-08 Thread Mikkel Kamstrup Erlandsen
If this happens because geoclue-master crashes then I think it deserves a more sensible error message. It's not a programming error but a runtime error. -- https://code.launchpad.net/~ted/indicator-datetime/bug714763/+merge/48837 Your team ayatana-commits is subscribed to branch

Re: [Ayatana-commits] [Merge] lp:~ted/libindicate/show-hide-signals into lp:libindicate

2011-02-03 Thread Mikkel Kamstrup Erlandsen
Review: Approve The code looks good, but I still don't entirely get why the properties from the GDBusProxy aren't good enough..? -- https://code.launchpad.net/~ted/libindicate/show-hide-signals/+merge/48395 Your team ayatana-commits is subscribed to branch lp:libindicate.

Re: [Ayatana-commits] [Merge] lp:~ted/libindicate/dbus-name-owner into lp:libindicate

2011-02-03 Thread Mikkel Kamstrup Erlandsen
On 2 February 2011 18:28, Ted Gould t...@gould.cx wrote: On Wed, 2011-02-02 at 15:01 +, Mikkel Kamstrup Erlandsen wrote: Eeek! /me goes to check his own code... Exactly.  I can't claim credit though, it was Mike Terry's find.  Do you think we should draft a patch for GDBus?  I figured

Re: [Ayatana-commits] [Merge] lp:~ted/libindicate/dbus-name-owner into lp:libindicate

2011-02-02 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve Eeek! /me goes to check his own code... -- https://code.launchpad.net/~ted/libindicate/dbus-name-owner/+merge/48260 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-datetime/no-error-with-no-proxy into lp:indicator-datetime

2011-02-01 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve Please grep for more g_error()s :-) -- https://code.launchpad.net/~ted/indicator-datetime/no-error-with-no-proxy/+merge/48109 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-datetime/no-crash-geoclue into lp:indicator-datetime

2011-02-01 Thread Mikkel Kamstrup Erlandsen
Review: Approve It's unclear to me exactly what situation these checks guard against. Can you add a code comment explaining the situation before you merge this? -- https://code.launchpad.net/~ted/indicator-datetime/no-crash-geoclue/+merge/48105 Your team ayatana-commits is subscribed to branch

Re: [Ayatana-commits] [Merge] lp:~mterry/dbusmenu/fix-props-return into lp:dbusmenu

2011-02-01 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve good catch! -- https://code.launchpad.net/~mterry/dbusmenu/fix-props-return/+merge/48026 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

Re: [Ayatana-commits] [Merge] lp:~ted/libindicate/dbus-name-owner into lp:libindicate

2011-02-01 Thread Mikkel Kamstrup Erlandsen
Review: Needs Fixing review needsfixing No need to subscribe to NameOwnerChanged. You can simplify the code and save the bus daemon the burden of an extra match rule by just connecting to the notify::g-name-owner signal on your proxy. --

Re: [Ayatana-commits] [Merge] lp:~karl-qdh/ubuntu/natty/indicator-datetime/indicator-datetime.withappointments into lp:indicator-datetime

2011-01-31 Thread Mikkel Kamstrup Erlandsen
Review: Approve Code looks ok to me although I haven't taken for a test run. -- https://code.launchpad.net/~karl-qdh/ubuntu/natty/indicator-datetime/indicator-datetime.withappointments/+merge/47980 Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/serializable-menuitem into lp:dbusmenu

2011-01-27 Thread Mikkel Kamstrup Erlandsen
Review: Needs Fixing The function prototypes DbusmenuClientTypeHandler and DbusmenuClientTypeDestroyHandler needs documentation. Can we avoid double namespacing on these two functions?: dbusmenu_gtk_serializable_menu_item_build_dbusmenu_menuitem()

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/parse-serializable-menuitem into lp:dbusmenu

2011-01-27 Thread Mikkel Kamstrup Erlandsen
Review: Needs Information How does this branch relate to https://code.launchpad.net/~ted/dbusmenu/serializable-menuitem/+merge/47604 ? They look identical? -- https://code.launchpad.net/~ted/dbusmenu/parse-serializable-menuitem/+merge/47605 Your team ayatana-commits is subscribed to branch

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/mem-leaks into lp:dbusmenu

2011-01-24 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve Looks good to me -- https://code.launchpad.net/~ted/dbusmenu/mem-leaks/+merge/47083 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/single-includes into lp:dbusmenu

2011-01-24 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve Looks good -- https://code.launchpad.net/~ted/dbusmenu/single-includes/+merge/47057 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/signal-on-new-menu into lp:dbusmenu

2011-01-19 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve Looks good to me -- https://code.launchpad.net/~ted/dbusmenu/signal-on-new-menu/+merge/46657 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-application/log-and-name into lp:indicator-application

2011-01-18 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve Verified with a grep. -- https://code.launchpad.net/~ted/indicator-application/log-and-name/+merge/46520 Your team ayatana-commits is subscribed to branch lp:indicator-application. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-messages/log-and-name into lp:indicator-messages

2011-01-18 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve Verified with a grep -- https://code.launchpad.net/~ted/indicator-messages/log-and-name/+merge/46511 Your team ayatana-commits is subscribed to branch lp:indicator-messages. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-session/log-and-name into lp:indicator-session

2011-01-18 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve Looks good -- https://code.launchpad.net/~ted/indicator-session/log-and-name/+merge/46504 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits

Re: [Ayatana-commits] [Merge] lp:~ted/appmenu-gtk/dbusmenu-0.4 into lp:appmenu-gtk

2011-01-06 Thread Mikkel Kamstrup Erlandsen
Review: Approve review approve You need to bump deps to glib-2.0 = 2.26 to have GDBus. Other than that looks good to me. -- https://code.launchpad.net/~ted/appmenu-gtk/dbusmenu-0.4/+merge/45455 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk.

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/kill-dbus-glib into lp:dbusmenu

2010-12-07 Thread Mikkel Kamstrup Erlandsen
Review: Approve I haven't looked deeply into this, but it looks very nice at glance. Very good work Ted! :-) Because I on principle *must* comment something on such large reviews here's some feedback. All of these are really just personal programming style preferences, so disregard to your

Re: [Ayatana-commits] [Merge] lp:~ted/dbusmenu/break-abi-for-series-4 into lp:dbusmenu

2010-10-13 Thread Mikkel Kamstrup Erlandsen
review approve Looks good to me. -- https://code.launchpad.net/~ted/dbusmenu/break-abi-for-series-4/+merge/38285 Your team ayatana-commits is subscribed to branch lp:dbusmenu. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana] Fwd: unified system

2010-08-05 Thread Mikkel Kamstrup Erlandsen
On Thu, 2010-08-05 at 00:21 +0200, Frederik Nnaji wrote: is anybody familiar with the spec i mention below!? i asked on the xdg list but nobody responded yet.. perhaps someone here is using some low hanging fruit out of this spec's implementation already in some project? Try looking in

Re: [Ayatana-commits] [Merge] lp:~dbarth/appmenu-gtk/check-property-existence into lp:appmenu-gtk

2010-06-22 Thread Mikkel Kamstrup Erlandsen
Review: Approve Looks good to me -- https://code.launchpad.net/~dbarth/appmenu-gtk/check-property-existence/+merge/28143 Your team ayatana-commits is subscribed to branch lp:appmenu-gtk. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

Re: [Ayatana-commits] [Merge] lp:~bratsche/appmenu-gtk/almost-rewrite into lp:appmenu-gtk

2010-06-15 Thread Mikkel Kamstrup Erlandsen
Forgive me if I don't know exactly how libappmenu is going to be used - it's not mentioned anywhere in any of the distributed files ;-) From the looks I'd say it was the gtk module that we load into all apps to export the menu on the bus? My comments are based on that at least :-) I am a bit

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-sound/thematic_changes_handling_for_blocking into lp:indicator-sound

2010-04-27 Thread Mikkel Kamstrup Erlandsen
Review: Approve Diff looks good. There was one place in src/indicator-sound.c that caught my eye - but it was not related to this diff. The value-change signal connected on line 283 - is there possibility of that firing after newitem has been freed? This would cause a segfault in