[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-datetime/trunk]

2014-12-09 Thread Ted Gould
Status: Mature = Abandoned -- lp:indicator-datetime/0.3 https://code.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk Your team ayatana-commits is subscribed to branch lp:indicator-datetime/0.3. To unsubscribe from this branch go to

[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-messages/trunk]

2013-08-19 Thread Ted Gould
Status: Mature = Abandoned -- lp:indicator-messages/0.5 https://code.launchpad.net/~indicator-applet-developers/indicator-messages/trunk Your team ayatana-commits is subscribed to branch lp:indicator-messages/0.5. To unsubscribe from this branch go to

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/evolution-indicator/evo_3.4 into lp:evolution-indicator

2012-05-30 Thread Ted Gould
Review: Approve The po/Makefile.in.in changes look odd, but they're apparently taken from intltool. -- https://code.launchpad.net/~ken-vandine/evolution-indicator/evo_3.4/+merge/107477 Your team ayatana-commits is subscribed to branch lp:evolution-indicator.

[Ayatana-commits] [Merge] lp:~ken-vandine/evolution-indicator/evo_3.4 into lp:evolution-indicator

2012-05-30 Thread Ted Gould
The proposal to merge lp:~ken-vandine/evolution-indicator/evo_3.4 into lp:evolution-indicator has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/evolution-indicator/evo_3.4/+merge/107477 --

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-860586 into lp:indicator-datetime/0.3

2012-03-08 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/fix-860586 into lp:indicator-datetime/0.3 has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-860586/+merge/79421 --

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-794312 into lp:indicator-datetime/0.3

2012-03-08 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/fix-794312 into lp:indicator-datetime/0.3 has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-794312/+merge/79426 --

[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-datetime/trunk]

2012-02-17 Thread Ted Gould
Status: Development = Mature -- lp:indicator-datetime/0.3 https://code.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk Your team ayatana-commits is subscribed to branch lp:indicator-datetime/0.3. To unsubscribe from this branch go to

[Ayatana-commits] [Branch ~indicator-applet-developers/indicator-messages/trunk]

2011-11-29 Thread Ted Gould
Status: Development = Mature -- lp:indicator-messages/0.5 https://code.launchpad.net/~indicator-applet-developers/indicator-messages/trunk Your team ayatana-commits is subscribed to branch lp:indicator-messages/0.5. To unsubscribe from this branch go to

Re: [Ayatana-commits] [Merge] lp:~jconti/indicator-applet/gnome3 into lp:indicator-applet

2011-11-28 Thread Ted Gould
Review: Approve Great, thanks for the work on this. A few comments: * Please don't change the version number in configure.ac, it really confuses things if there are multiple version numbers in the wild so it's better just to have one place define it. I'll fix this on merge, no worries

[Ayatana-commits] [Merge] lp:~ted/indicator-datetime/geoclue-fix into lp:indicator-datetime

2011-10-23 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-datetime/geoclue-fix into lp:indicator-datetime. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-datetime/geoclue-fix/+merge/80159 Fixing the check

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/remove_libunique into lp:indicator-datetime

2011-10-13 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/remove_libunique into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/remove_libunique/+merge/78240 --

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-740977 into lp:indicator-datetime

2011-10-12 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/fix-740977 into lp:indicator-datetime has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-740977/+merge/78342 --

Re: [Ayatana-commits] [Merge] lp:~kaijanmaki/indicator-datetime/lp-774071 into lp:indicator-datetime

2011-10-12 Thread Ted Gould
Review: Disapprove Hey Antti, it seems that you made your branch off of the packaging branch instead of the development branch. Can you remake it on devel branch please? -- https://code.launchpad.net/~kaijanmaki/indicator-datetime/lp-774071/+merge/77599 Your team ayatana-commits is subscribed

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-session/lp_858798 into lp:indicator-session

2011-10-12 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-session/lp_858798 into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-session/lp_858798/+merge/77952 --

[Ayatana-commits] [Merge] lp:~kaijanmaki/indicator-datetime/lp-774071 into lp:indicator-datetime

2011-10-12 Thread Ted Gould
The proposal to merge lp:~kaijanmaki/indicator-datetime/lp-774071 into lp:indicator-datetime has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~kaijanmaki/indicator-datetime/lp-774071/+merge/77599 --

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-746176 into lp:indicator-datetime

2011-10-11 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/fix-746176 into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-746176/+merge/78347 --

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-session/lp864085 into lp:indicator-session

2011-10-10 Thread Ted Gould
Oh, I hope that no one disables checks... that'd be a really bad idea. But, anyway, fixed. -- https://code.launchpad.net/~ted/indicator-session/lp864085/+merge/78733 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing

[Ayatana-commits] [Merge] lp:~ted/indicator-session/gvariant_fixes into lp:indicator-session

2011-10-09 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/gvariant_fixes into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: Bug #863930 in Session Menu: indicator-session-service crashed with SIGABRT (assertion failed: (0

[Ayatana-commits] [Merge] lp:~ted/indicator-session/lp864085 into lp:indicator-session

2011-10-08 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/lp864085 into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: Bug #867926 in indicator-session (Ubuntu): gtk-logout-helper crashed with SIGSEGV in g_variant_unref

Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/timer-fix-837440 into lp:indicator-datetime

2011-09-30 Thread Ted Gould
Review: Disapprove Indicator-datetime needs to have all contributions be copyright Canonical. I'm guessing those contributors won't sign the CLA :-) -- https://code.launchpad.net/~jjardon/indicator-datetime/timer-fix-837440/+merge/77625 Your team ayatana-commits is subscribed to branch

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/timer-fix-837440 into lp:indicator-datetime

2011-09-30 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/timer-fix-837440 into lp:indicator-datetime has been updated. Status: Needs review = Rejected For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/timer-fix-837440/+merge/77625 --

[Ayatana-commits] [Merge] lp:~robert-ancell/indicator-datetime/lp-861123 into lp:indicator-datetime

2011-09-29 Thread Ted Gould
The proposal to merge lp:~robert-ancell/indicator-datetime/lp-861123 into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~robert-ancell/indicator-datetime/lp-861123/+merge/77275 --

[Ayatana-commits] [Merge] lp:~ted/indicator-session/lp740382 into lp:indicator-session

2011-09-27 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/lp740382 into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: Bug #740382 in Session Menu: gtk-logout-helper crashed with SIGABRT in __libc_start_main() https

[Ayatana-commits] [Merge] lp:~ted/indicator-session/restart-icon-change into lp:indicator-session

2011-09-26 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/restart-icon-change into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: Bug #854292 in Session Menu: indicator-session power menu disappears after running update

[Ayatana-commits] [Merge] lp:~kelemeng/indicator-datetime/bug853130 into lp:indicator-datetime

2011-09-21 Thread Ted Gould
The proposal to merge lp:~kelemeng/indicator-datetime/bug853130 into lp:indicator-datetime has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~kelemeng/indicator-datetime/bug853130/+merge/75889 --

[Ayatana-commits] [Merge] lp:~kelemeng/indicator-datetime/bug853130 into lp:indicator-datetime

2011-09-21 Thread Ted Gould
The proposal to merge lp:~kelemeng/indicator-datetime/bug853130 into lp:indicator-datetime has been updated. Status: Merged = Approved For more details, see: https://code.launchpad.net/~kelemeng/indicator-datetime/bug853130/+merge/75889 --

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-837440 into lp:indicator-datetime

2011-09-16 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/fix-837440 into lp:indicator-datetime has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-837440/+merge/75717 --

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/delay-apt-interaction into lp:indicator-session

2011-09-14 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/delay-apt-interaction/+merge/75376 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/delay-apt-interaction into lp:indicator-session

2011-09-14 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/delay-apt-interaction into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/delay-apt-interaction/+merge/75376 --

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/optional-string-in-switch-item into lp:indicator-session

2011-09-08 Thread Ted Gould
Review: Needs Information Why do we need a preference for this? Can we just use the check for guest function? -- https://code.launchpad.net/~cjcurran/indicator-session/optional-string-in-switch-item/+merge/74598 Your team ayatana-commits is subscribed to branch lp:indicator-session.

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hide-real-name-on-panel-gsetting into lp:indicator-session

2011-09-08 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/hide-real-name-on-panel-gsetting/+merge/74656 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hide-real-name-on-panel-gsetting into lp:indicator-session

2011-09-08 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/hide-real-name-on-panel-gsetting into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/hide-real-name-on-panel-gsetting/+merge/74656 --

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/optional-string-in-switch-item into lp:indicator-session

2011-09-08 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/optional-string-in-switch-item into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/optional-string-in-switch-item/+merge/74598 --

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hasguestaccount-support into lp:indicator-session

2011-09-07 Thread Ted Gould
Review: Approve You technically should have a g_value_unset() after using the value. But since it's a boolean we know that it shouldn't have any memory so it's not a big deal. -- https://code.launchpad.net/~cjcurran/indicator-session/hasguestaccount-support/+merge/74510 Your team

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hasguestaccount-support into lp:indicator-session

2011-09-07 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/hasguestaccount-support into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/hasguestaccount-support/+merge/74510 --

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/cancel-existing-apt-operations into lp:indicator-session

2011-09-07 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/cancel-existing-apt-operations/+merge/74512 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/cancel-existing-apt-operations into lp:indicator-session

2011-09-07 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/cancel-existing-apt-operations into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/cancel-existing-apt-operations/+merge/74512 --

[Ayatana-commits] [Merge] lp:~ted/indicator-session/gtk-logout-debug-messages into lp:indicator-session

2011-09-07 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/gtk-logout-debug-messages into lp:indicator-session. Requested reviews: Conor Curran (cjcurran) For more details, see: https://code.launchpad.net/~ted/indicator-session/gtk-logout-debug-messages/+merge/74541 Some debug messages, let's

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hide-user-menu-via-gsettings-key into lp:indicator-session

2011-09-06 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/hide-user-menu-via-gsettings-key/+merge/74262 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/hide-user-menu-via-gsettings-key into lp:indicator-session

2011-09-06 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/hide-user-menu-via-gsettings-key into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/hide-user-menu-via-gsettings-key/+merge/74262 --

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/null-error-user-dbus-mgr into lp:indicator-session

2011-09-06 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/null-error-user-dbus-mgr/+merge/74080 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/null-error-user-dbus-mgr into lp:indicator-session

2011-09-06 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/null-error-user-dbus-mgr into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/null-error-user-dbus-mgr/+merge/74080 --

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/checkforpow into lp:indicator-datetime

2011-09-06 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/checkforpow into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/checkforpow/+merge/74224 --

Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/checkforpow into lp:indicator-datetime

2011-09-06 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~jjardon/indicator-datetime/checkforpow/+merge/74224 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/remove_death_code into lp:indicator-datetime

2011-09-06 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/remove_death_code into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/remove_death_code/+merge/74227 --

Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/remove_death_code into lp:indicator-datetime

2011-09-06 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~jjardon/indicator-datetime/remove_death_code/+merge/74227 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/optimizations into lp:indicator-datetime

2011-09-06 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~jjardon/indicator-datetime/optimizations/+merge/74210 Your team ayatana-commits is subscribed to branch lp:indicator-datetime. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/optimizations into lp:indicator-datetime

2011-09-06 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/optimizations into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/optimizations/+merge/74210 --

Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-837440 into lp:indicator-datetime

2011-09-06 Thread Ted Gould
Review: Needs Information It seems that the wall-clock isn't in 3.1.91 which is what is in Oneiric: http://packages.ubuntu.com/oneiric/amd64/libgnome-desktop-3-dev/filelist So that would mean the pkgconfig check is wrong there. Also, I'm a little uncomfortable using a schema that isn't in our

[Ayatana-commits] [Merge] lp:~sargentd/libindicate/opional-mono into lp:libindicate

2011-09-06 Thread Ted Gould
The proposal to merge lp:~sargentd/libindicate/opional-mono into lp:libindicate has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~sargentd/libindicate/opional-mono/+merge/73989 --

Re: [Ayatana-commits] [Merge] lp:~sargentd/libindicate/opional-mono into lp:libindicate

2011-09-06 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~sargentd/libindicate/opional-mono/+merge/73989 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-775113 into lp:indicator-datetime

2011-09-06 Thread Ted Gould
No currently a new enough version of GLib in Oneiric to test. Need to circle back when that gets updated. -- https://code.launchpad.net/~jjardon/indicator-datetime/fix-775113/+merge/73846 Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/greeter-icon into lp:indicator-session

2011-09-01 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/greeter-icon into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/greeter-icon/+merge/73705 --

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/fix-793450 into lp:indicator-datetime

2011-08-31 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/fix-793450 into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/fix-793450/+merge/72912 --

Re: [Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/793450 into lp:indicator-datetime

2011-08-31 Thread Ted Gould
Review: Needs Fixing This merge has a conflict in it, could you please update it to the latest version in that branch? Thanks! -- https://code.launchpad.net/~jjardon/indicator-datetime/793450/+merge/72910 Your team ayatana-commits is subscribed to branch lp:indicator-datetime.

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/utf8-guest-fixes into lp:indicator-session

2011-08-30 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/utf8-guest-fixes/+merge/73405 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/gutter-fix into lp:indicator-messages

2011-08-24 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/gutter-fix into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-messages/gutter-fix/+merge/72819 Make it so that we

[Ayatana-commits] [Merge] lp:~ted/indicator-session/activate-prototype into lp:indicator-session

2011-08-23 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/activate-prototype into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-session/activate-prototype/+merge/72595 Fix

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/user-image-panel into lp:indicator-session

2011-08-23 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/user-image-panel into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/user-image-panel/+merge/72615 --

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/user-image-panel into lp:indicator-session

2011-08-23 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/user-image-panel/+merge/72615 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/brand-the-attached-devices-labels into lp:indicator-session

2011-08-23 Thread Ted Gould
Review: Needs Fixing The translation is wrong here. You want to have the _() around the format string. So _(%s scanner) that way the translator can move the name around appropriately for their language. --

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/user-images into lp:indicator-session

2011-08-22 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/user-images into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/user-images/+merge/72493 --

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/user-images into lp:indicator-session

2011-08-22 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/user-images/+merge/72493 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-session/gsettings-port into lp:indicator-session

2011-08-19 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/gsettings-port into lp:indicator-session. Requested reviews: Conor Curran (cjcurran) For more details, see: https://code.launchpad.net/~ted/indicator-session/gsettings-port/+merge/72254 GSettings port. I've updated the ubuntu branch

[Ayatana-commits] [Merge] lp:~ted/indicator-session/ellipsis-test into lp:indicator-session

2011-08-19 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/ellipsis-test into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-session/ellipsis-test/+merge/72281 Fix the last set

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/apt-updates-bug into lp:indicator-session

2011-08-17 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/apt-updates-bug/+merge/71348 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/apt-updates-bug into lp:indicator-session

2011-08-17 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/apt-updates-bug into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/apt-updates-bug/+merge/71348 --

Re: [Ayatana-commits] [Merge] lp:~cimi/indicator-messages/fix-draw-gtk3 into lp:indicator-messages

2011-08-17 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cimi/indicator-messages/fix-draw-gtk3/+merge/71919 Your team ayatana-commits is subscribed to branch lp:indicator-messages. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~cimi/indicator-messages/fix-draw-gtk3 into lp:indicator-messages

2011-08-17 Thread Ted Gould
The proposal to merge lp:~cimi/indicator-messages/fix-draw-gtk3 into lp:indicator-messages has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cimi/indicator-messages/fix-draw-gtk3/+merge/71919 --

[Ayatana-commits] [Merge] lp:~jjardon/indicator-datetime/bug-729056 into lp:indicator-datetime

2011-08-17 Thread Ted Gould
The proposal to merge lp:~jjardon/indicator-datetime/bug-729056 into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~jjardon/indicator-datetime/bug-729056/+merge/71680 --

[Ayatana-commits] [Merge] lp:~sbte/indicator-messages/fix-817504 into lp:indicator-messages

2011-08-17 Thread Ted Gould
The proposal to merge lp:~sbte/indicator-messages/fix-817504 into lp:indicator-messages has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~sbte/indicator-messages/fix-817504/+merge/69775 --

[Ayatana-commits] [Merge] lp:~ted/indicator-session/actually-get-sessions into lp:indicator-session

2011-08-17 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/actually-get-sessions into lp:indicator-session. Requested reviews: Conor Curran (cjcurran) For more details, see: https://code.launchpad.net/~ted/indicator-session/actually-get-sessions/+merge/71950 Makes it so that when we create

Re: [Ayatana-commits] [Merge] lp:~ted/libindicate/gtk3-and-stuff-like-that into lp:libindicate

2011-07-28 Thread Ted Gould
Okay, updated. -- https://code.launchpad.net/~ted/libindicate/gtk3-and-stuff-like-that/+merge/69173 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/libindicate/gtk3-and-stuff-like-that into lp:libindicate

2011-07-25 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/gtk3-and-stuff-like-that into lp:libindicate. Requested reviews: Ken VanDine (ken-vandine) For more details, see: https://code.launchpad.net/~ted/libindicate/gtk3-and-stuff-like-that/+merge/69173 Porting this to use GTK3 and having to bump

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/suspend-updates-in-progress into lp:indicator-session

2011-07-22 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~cjcurran/indicator-session/suspend-updates-in-progress/+merge/68854 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

Re: [Ayatana-commits] [Merge] lp:~chrisccoulson/indicator-messages/dont-hardcode-evolution into lp:indicator-messages

2011-07-22 Thread Ted Gould
I fixed a couple of little things including putting found as a condition for the for loop and using the G_N_ELEMENTS() macro. Then merged. Also, do you think we could do this for the other items in the menu at the distro level. Define types for them so people could set default IM and

[Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/split-out-users into lp:indicator-session

2011-07-18 Thread Ted Gould
The proposal to merge lp:~cjcurran/indicator-session/split-out-users into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~cjcurran/indicator-session/split-out-users/+merge/68110 --

Re: [Ayatana-commits] [Merge] lp:~cjcurran/indicator-session/split-out-session into lp:indicator-session

2011-07-18 Thread Ted Gould
Review: Approve Just a couple of comments that should be deletes. 726 +//#include gconf-helper.h 737 +//#include lock-helper.h -- https://code.launchpad.net/~cjcurran/indicator-session/split-out-session/+merge/68282 Your team ayatana-commits is subscribed to branch lp:indicator-session.

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/remove_about_me into lp:indicator-me

2011-06-28 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-me/remove_about_me into lp:indicator-me has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/remove_about_me/+merge/66023 --

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/remove_about_me into lp:indicator-me

2011-06-28 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-me/remove_about_me/+merge/66023 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/gtk3 into lp:indicator-me

2011-06-22 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-me/gtk3/+merge/65543 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-session/gtk3 into lp:indicator-session

2011-06-09 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~mterry/indicator-session/gtk3/+merge/62515 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~mterry/indicator-session/gtk3 into lp:indicator-session

2011-06-09 Thread Ted Gould
The proposal to merge lp:~mterry/indicator-session/gtk3 into lp:indicator-session has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mterry/indicator-session/gtk3/+merge/62515 --

Re: [Ayatana-commits] [Merge] lp:~sargentd/indicator-datetime/fix-spelling into lp:indicator-datetime

2011-06-09 Thread Ted Gould
Review: Approve Wow, I'm a little scared that Lintian can catch spelling errors. Does not bode well for any software I write getting packaged for Debian/Ubuntu ;-) -- https://code.launchpad.net/~sargentd/indicator-datetime/fix-spelling/+merge/63499 Your team ayatana-commits is subscribed to

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me

2011-05-31 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/gsettings/+merge/58065 --

[Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me

2011-05-31 Thread Ted Gould
The proposal to merge lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/indicator-me/gsettings/+merge/58065 --

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/gsettings into lp:indicator-me

2011-05-31 Thread Ted Gould
Review: Approve Looks good. -- https://code.launchpad.net/~ken-vandine/indicator-me/gsettings/+merge/58065 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ken-vandine/libindicate/server_add_annotations into lp:libindicate

2011-05-31 Thread Ted Gould
The proposal to merge lp:~ken-vandine/libindicate/server_add_annotations into lp:libindicate has been updated. Status: Needs review = Work in progress For more details, see: https://code.launchpad.net/~ken-vandine/libindicate/server_add_annotations/+merge/58133 --

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/libindicate/server_add_annotations into lp:libindicate

2011-05-31 Thread Ted Gould
Review: Needs Fixing -- https://code.launchpad.net/~ken-vandine/libindicate/server_add_annotations/+merge/58133 Your team ayatana-commits is subscribed to branch lp:libindicate. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-session/gtk3 into lp:indicator-session

2011-05-31 Thread Ted Gould
Review: Needs Fixing Hmm, it seems that session-service.c needs the same header check. But, it seems more likely that Dbusmenu is broken there. Are other libraries requiring that change? Seems it should be /usr/lib/libdbusmenu3-0.4/libdbusmenu-gtk, eh? --

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-messages/gtk3 into lp:indicator-messages

2011-05-31 Thread Ted Gould
Review: Approve Code looks fine. Worried about the dbusmenu-gtk3 includes though :-/ (see last review's comment). -- https://code.launchpad.net/~mterry/indicator-messages/gtk3/+merge/62527 Your team ayatana-commits is subscribed to branch lp:indicator-messages.

[Ayatana-commits] [Merge] lp:~mterry/indicator-messages/gtk3 into lp:indicator-messages

2011-05-31 Thread Ted Gould
The proposal to merge lp:~mterry/indicator-messages/gtk3 into lp:indicator-messages has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~mterry/indicator-messages/gtk3/+merge/62527 --

[Ayatana-commits] [Merge] lp:~ted/indicator-session/classic-session into lp:indicator-session

2011-05-12 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/classic-session into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) For more details, see: https://code.launchpad.net/~ted/indicator-session/classic-session/+merge/60746 Add

[Ayatana-commits] [Merge] lp:~ken-vandine/libindicate/vapi_fixes into lp:libindicate

2011-04-18 Thread Ted Gould
The proposal to merge lp:~ken-vandine/libindicate/vapi_fixes into lp:libindicate has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~ken-vandine/libindicate/vapi_fixes/+merge/57959 --

[Ayatana-commits] [Merge] lp:~karl-qdh/indicator-datetime/appointmentwidth into lp:indicator-datetime

2011-04-18 Thread Ted Gould
The proposal to merge lp:~karl-qdh/indicator-datetime/appointmentwidth into lp:indicator-datetime has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~karl-qdh/indicator-datetime/appointmentwidth/+merge/58098 --

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_754524 into lp:indicator-me

2011-04-14 Thread Ted Gould
Review: Approve -- https://code.launchpad.net/~ken-vandine/indicator-me/lp_754524/+merge/57713 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-session/lp747818 into lp:indicator-session

2011-04-13 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/lp747818 into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: Bug #747818 in Session Menu: indicator-session-service crashed with SIGABRT in g_closure_invoke() https

Re: [Ayatana-commits] [Merge] lp:~mterry/indicator-datetime/locale-and-version into lp:indicator-datetime

2011-04-06 Thread Ted Gould
Review: Approve On Wed, 2011-04-06 at 15:08 +, Michael Terry wrote: + version = ; This needs to be g_strdup() so that we can free it later. I'll fix on merge. review approve merge approve -- https://code.launchpad.net/~mterry/indicator-datetime/locale-and-version/+merge/56586

[Ayatana-commits] [Merge] lp:~ted/indicator-datetime/full-day-events into lp:indicator-datetime

2011-04-05 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-datetime/full-day-events into lp:indicator-datetime. Requested reviews: Karl Lattimer (karl-qdh) For more details, see: https://code.launchpad.net/~ted/indicator-datetime/full-day-events/+merge/56464 I think this handles the full day events

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-me/lp_746962 into lp:indicator-me

2011-04-04 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~ken-vandine/indicator-me/lp_746962/+merge/56209 Your team ayatana-commits is subscribed to branch lp:indicator-me. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

  1   2   3   4   5   6   >