[Ayatana-commits] [Merge] lp:~ted/dbusmenu/imageitem into lp:dbusmenu

2009-09-03 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/imageitem into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Adds support for image menu items. They're fun! -- https://code.launchpad.net/~ted/dbusmenu/imageitem/+merge/11141 Your team ayatana-commits is subscribed to branch

[Ayatana-commits] [Merge] lp:~ted/indicator-applet/messages-blacklist into lp:indicator-applet/messages0.2 updated

2009-09-04 Thread Ted Gould
The proposal to merge lp:~ted/indicator-applet/messages-blacklist into lp:indicator-applet/messages0.2 has been updated. Status: Needs review = Merged -- https://code.edge.launchpad.net/~ted/indicator-applet/messages-blacklist/+merge/10527 Your team ayatana-commits is subscribed to branch

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/newapi.ubuntu into lp:indicator-messages updated

2009-09-07 Thread Ted Gould
The proposal to merge lp:~ted/indicator-messages/newapi.ubuntu into lp:indicator-messages has been updated. Status: Needs review = Rejected -- https://code.edge.launchpad.net/~ted/indicator-messages/newapi.ubuntu/+merge/11317 Your team ayatana-commits is subscribed to branch

Re: [Ayatana-commits] [Merge] lp:~indicator-applet-developers/evolution-indicator/fix-preferences into lp:evolution-indicator

2009-09-08 Thread Ted Gould
Review: Approve Looks good to me. review approve -- https://code.launchpad.net/~indicator-applet-developers/evolution-indicator/fix-preferences/+merge/11351 Your team ayatana-commits is subscribed to branch lp:evolution-indicator. ___ Mailing

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/reorder into lp:dbusmenu

2009-09-09 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/reorder into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Fixing the reordering for the messaging menu. -- https://code.launchpad.net/~ted/dbusmenu/reorder/+merge/11492 Your team ayatana-commits is subscribed to branch

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/lift-and-separate into lp:indicator-messages

2009-09-09 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/lift-and-separate into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Adding separators between the entries. Really needs the dbusmenu patch to make it work well. -- https

[Ayatana-commits] [Merge] lp:~ted/libindicate/propfix into lp:libindicate

2009-09-11 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/propfix into lp:libindicate. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Fixing so we can get the count property. -- https://code.launchpad.net/~ted/libindicate/propfix/+merge/11641 Your team ayatana-commits

[Ayatana-commits] [Merge] lp:~ted/libindicate/helpers into lp:libindicate

2009-09-14 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/helpers into lp:libindicate. Requested reviews: Aurélien Gâteau (agateau) -- https://code.launchpad.net/~ted/libindicate/helpers/+merge/11704 Your team ayatana-commits is subscribed to branch lp:libindicate. === modified file 'libindicate

Re: [Ayatana-commits] [Merge] lp:~indicator-applet-developers/evolution-indicator/blacklist-support into lp:evolution-indicator

2009-09-16 Thread Ted Gould
On Wed, 2009-09-16 at 15:53 +, David Barth wrote: blacklist management should really be something done by the indicator-messages itself then. We've discussed making a utility to do it so there'd be something like: $ indicator-messages-blacklist-add /path/to/my/desktopfile.desktop and

[Ayatana-commits] [Merge] lp:~ted/indicator-session/available into lp:indicator-session

2009-09-16 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/available into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Changing the icon name to the proper one in the updated icon-naming spec. -- https://code.launchpad.net/~ted/indicator

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/panel-above into lp:xsplash

2009-09-16 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/panel-above/+merge/11944 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-applet/python-v2work into lp:indicator-applet/python0.2

2009-09-16 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-applet/python-v2work into lp:indicator-applet/python0.2. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Making it so that the bindings work with libindicate v2 -- https://code.launchpad.net/~ted/indicator-applet

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/remove-scaling into lp:xsplash

2009-09-17 Thread Ted Gould
Review: Approve Looks like that should remove it, but I'm curious if we can not scale at all resolutions? It seems like at least in some cases we'd have to scale some. Or atleast fill the background black or something. It seems like there'd need to be some programatic defense against crazy

Re: [Ayatana-commits] [Merge] lp:~ken-vandine/indicator-applet/python-v2work into lp:indicator-applet/python0.2

2009-09-22 Thread Ted Gould
Review: Approve On Tue, 2009-09-22 at 14:45 +, Ken VanDine wrote: lp:~ken-vandine/indicator-applet/python-v2work Looks good. review approve -- https://code.launchpad.net/~ken-vandine/indicator-applet/python-v2work/+merge/12228 Your team ayatana-commits is subscribed to branch

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/path-change into lp:indicator-messages

2009-09-23 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/path-change into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Adding an additional path for launchers and making it so that if a desktop file is given that is not valid, we hide

[Ayatana-commits] [Merge] lp:~ted/indicator-session/mc5 into lp:indicator-session

2009-09-23 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/mc5 into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) This links to libempathy to get MC5 support. -- https://code.launchpad.net/~ted/indicator-session/mc5/+merge/12306 Your team

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/min-width into lp:indicator-messages

2009-09-23 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/min-width into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Puts a min width on the menu so that descriptions that are reasonable don't elipsize. -- https://code.launchpad.net

Re: [Ayatana-commits] [Merge] lp:~bratsche/indicator-session/users-service into lp:indicator-session

2009-09-24 Thread Ted Gould
On Thu, 2009-09-24 at 06:31 +, Cody Russell wrote: * There should be icons on the users if they are set (probably should go in another branch/bug) TODO. Can we do this in a separate branch? Yeah, sounds good. * The guest user needs to be handled as well. If

Re: [Ayatana-commits] [Merge] lp:~bratsche/indicator-session/users-service into lp:indicator-session

2009-09-24 Thread Ted Gould
On Thu, 2009-09-24 at 04:37 +, Cody Russell wrote: * I was looking at CanActivateSessions call to ConsoleKit. Do you think we should check this earlier and make the menu items sensitive or insensitive based on this? Should the menuitems even be there if you can

Re: [Ayatana-commits] [Merge] lp:~bratsche/indicator-session/users-service into lp:indicator-session

2009-09-24 Thread Ted Gould
On Thu, 2009-09-24 at 14:09 +, Matthew Paul Thomas wrote: Ted Gould wrote on 24/09/09 14:59: On Thu, 2009-09-24 at 04:37 +, Cody Russell wrote: ... Should the menuitems even be there if you can never click them? I went ahead and made an API on UsersServiceDbus that can check

[Ayatana-commits] [Merge] lp:~ted/indicator-session/gdm-check-lock into lp:indicator-session

2009-09-24 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/gdm-check-lock into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Checking GDM before locking. -- https://code.launchpad.net/~ted/indicator-session/gdm-check-lock/+merge/12360

[Ayatana-commits] [Merge] lp:~ted/indicator-session/no-check-pk into lp:indicator-session

2009-09-24 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/no-check-pk into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Removing the PK Check to see if the dialog needs to show. CK bug :( -- https://code.launchpad.net/~ted

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/reordering-all-over-again into lp:dbusmenu

2009-09-24 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/reordering-all-over-again into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Adds revision tracking of the layout to help fix some of the reordering bugs. -- https://code.launchpad.net/~ted/dbusmenu/reordering-all-over

Re: [Ayatana-commits] [Merge] lp:~bratsche/indicator-session/clear-menu into lp:indicator-session

2009-09-24 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/indicator-session/clear-menu/+merge/12387 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/icons-fix into lp:indicator-messages

2009-09-24 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/icons-fix into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Fix for the icons being put into the wrong directory. -- https://code.launchpad.net/~ted/indicator-messages

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/timeout-option-fix into lp:xsplash

2009-09-28 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/timeout-option-fix/+merge/12532 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/improve-logging into lp:xsplash

2009-09-28 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/improve-logging/+merge/12552 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-session/launch-errors into lp:indicator-session

2009-09-28 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/launch-errors into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Redo'ing startup to hopefully make it purdy. -- https://code.launchpad.net/~ted/indicator-session/launch

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/trim-some-image-fat into lp:xsplash

2009-09-28 Thread Ted Gould
Review: Needs Information Don't you need to keep one of each aspect ratio at least? -- https://code.edge.launchpad.net/~bratsche/xsplash/trim-some-image-fat/+merge/12557 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list:

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/throbber-xtra-large-filename into lp:xsplash

2009-09-29 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/throbber-xtra-large-filename/+merge/12600 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/monitors into lp:xsplash

2009-09-29 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/monitors/+merge/12613 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/disappearing-menu into lp:indicator-messages

2009-09-29 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/disappearing-menu into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Fix for an issue where the icon will disappear with items blacklisted on login. -- https

[Ayatana-commits] [Merge] lp:~ted/indicator-session/lock-insensitively into lp:indicator-session

2009-09-29 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/lock-insensitively into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Make it so that the lock screen item's sensitivity is also controlled by the gdm autologin setting

[Ayatana-commits] [Merge] lp:~ted/indicator-session/guest-no-lockie into lp:indicator-session

2009-09-29 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/guest-no-lockie into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) We shouldn't allow locking with the guest account. -- https://code.launchpad.net/~ted/indicator-session

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/errr-reordering into lp:dbusmenu

2009-10-02 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/errr-reordering into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Fixes reordering by adding a case in the new item where we notice that it's already been realized. Also, fixes some other problems by removing the item

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/setgid into lp:xsplash

2009-10-02 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/setgid/+merge/12788 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/setgid into lp:xsplash

2009-10-05 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/setgid/+merge/12788 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/indicator-session/async-menu into lp:indicator-session

2009-10-05 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/async-menu into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Better handling of menus. -- https://code.launchpad.net/~ted/indicator-session/async-menu/+merge/12869 Your team

[Ayatana-commits] [Merge] lp:~ted/indicator-session/bad-window-icon into lp:indicator-session

2009-10-05 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/bad-window-icon into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) The window icon was incorrect when the property was changed, it needs to change there also. -- https

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/monitors-changed into lp:xsplash

2009-10-05 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/monitors-changed/+merge/12833 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/dump-tool into lp:dbusmenu

2009-10-05 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/dump-tool into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) New tool, to dump the dbusmenu state. -- https://code.launchpad.net/~ted/dbusmenu/dump-tool/+merge/12899 Your team ayatana-commits is subscribed to branch

[Ayatana-commits] [Merge] lp:~ted/indicator-session/mc5fix into lp:indicator-session

2009-10-08 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/mc5fix into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) -- https://code.launchpad.net/~ted/indicator-session/mc5fix/+merge/13104 Your team ayatana-commits is subscribed

[Ayatana-commits] [Merge] lp:~ted/cape-girardeau/dbus-interfaces into lp:~ted/cape-girardeau/trunk

2009-10-15 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/cape-girardeau/dbus-interfaces into lp:~ted/cape-girardeau/trunk. Requested reviews: Cape Girardeau Team (cape-girardeau-team) -- https://code.launchpad.net/~ted/cape-girardeau/dbus-interfaces/+merge/13453 Your team ayatana-commits is subscribed

[Ayatana-commits] [Merge] lp:~ted/cape-girardeau/libinterface into lp:~ted/cape-girardeau/trunk

2009-10-16 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/cape-girardeau/libinterface into lp:~ted/cape-girardeau/trunk. Requested reviews: Cape Girardeau Team (cape-girardeau-team) Building up the library and it's interface. A little trick due to enums :-/ -- https://code.launchpad.net/~ted/cape

[Ayatana-commits] [Merge] lp:~ted/cape-girardeau/libinterface into lp:~ted/cape-girardeau/trunk

2009-10-16 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/cape-girardeau/libinterface into lp:~ted/cape-girardeau/trunk. Requested reviews: Cape Girardeau Team (cape-girardeau-team) -- https://code.launchpad.net/~ted/cape-girardeau/libinterface/+merge/13503 Your team ayatana-commits is subscribed

[Ayatana-commits] [Merge] lp:~ted/indicator-applet/nice-name into lp:indicator-applet

2009-10-26 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-applet/nice-name into lp:indicator-applet. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: #449036 Have more human friendly application name in about dialog https://bugs.launchpad.net/bugs

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/translator-comments into lp:indicator-messages

2009-10-26 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/translator-comments into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Related bugs: #456437 Translator comments for strings containing h m (for hours minutes?) https

Re: [Ayatana-commits] [Merge] lp:~lifeless/notify-osd/tests into lp:notify-osd

2009-11-24 Thread Ted Gould
On Tue, 2009-11-24 at 13:06 +, Mirco Müller wrote: What's test-support.am doing exactly? In particular how does Xvfb work and what are all those XIDs good for? Its just machinery to get an X server up and running without linear probing for available server slots. Is that

[Ayatana-commits] [Merge] lp:~ted/indicator-applet/dynamic-allocation into lp:indicator-applet

2009-11-24 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-applet/dynamic-allocation into lp:indicator-applet. Requested reviews: Indicator Applet Developers (indicator-applet-developers) This patch makes it so that the indicator applet can respond to entries being added and removed. -- https

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-applet/dynamic-allocation into lp:indicator-applet

2009-11-25 Thread Ted Gould
On Wed, 2009-11-25 at 05:36 +, Robert Collins wrote: On Wed, 2009-11-25 at 03:35 +, Ted Gould wrote: + if (entry-image != NULL) { + gtk_box_pack_start(GTK_BOX(hbox), GTK_WIDGET(entry-image), FALSE, FALSE, 0); + } + if (entry-label != NULL

Re: [Ayatana-commits] [Merge] lp:~agateau/dbusmenu/new-api into lp:dbusmenu

2009-11-28 Thread Ted Gould
On Fri, 2009-11-27 at 16:56 +, Aurélien Gâteau wrote: Other than this, the definitions seem fine - but where is the matching code changes? They do not exist right now. When Ted asked me to create a merge request for these changes, I told him it would break the build, but I think he

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/help-fix into lp:xsplash

2009-12-08 Thread Ted Gould
Review: Approve -- https://code.edge.launchpad.net/~bratsche/xsplash/help-fix/+merge/14443 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to :

[Ayatana-commits] [Merge] lp:~ted/dbus-test-runner/mass-bustling into lp:dbus-test-runner

2009-12-09 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbus-test-runner/mass-bustling into lp:dbus-test-runner. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Fixes a bug where when enough bustle data accumulates it caused dbus-test-runner to hang. Also added a test

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/v2work into lp:dbusmenu

2009-12-21 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/v2work into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Update to do a replace instead of an insert that was causing crashes. Whoo, hoo! Required a lot of tests to be written to find. -- https://code.launchpad.net

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/dbusmenu-0.2 into lp:indicator-messages

2009-12-22 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/dbusmenu-0.2 into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) -- https://code.launchpad.net/~ted/indicator-messages/dbusmenu-0.2/+merge/16504 Your team ayatana-commits

[Ayatana-commits] [Merge] lp:~agateau/dbusmenu/GetChildren into lp:dbusmenu

2010-01-04 Thread Ted Gould
Ted Gould has proposed merging lp:~agateau/dbusmenu/GetChildren into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) -- https://code.launchpad.net/~agateau/dbusmenu/GetChildren/+merge/16791 Your team ayatana-commits is subscribed to branch lp:dbusmenu. === modified file

[Ayatana-commits] [Merge] lp:~ted/indicator-applet/code-unification into lp:indicator-applet

2010-01-04 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-applet/code-unification into lp:indicator-applet. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Makes it so the majority of code is all in one file, then #defined off into the different applets that we

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/icon-padding into lp:dbusmenu

2010-01-11 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/icon-padding into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Adding a check of the horizontal padding and using that to space out the icon and the label. -- https://code.launchpad.net/~ted/dbusmenu/icon-padding/+merge

Re: [Ayatana-commits] [Merge] lp:~bratsche/xsplash/undefine-cursor into lp:xsplash

2010-01-15 Thread Ted Gould
Review: Approve Seems straight forward. -- https://code.edge.launchpad.net/~bratsche/xsplash/undefine-cursor/+merge/16355 Your team ayatana-commits is subscribed to branch lp:xsplash. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

[Ayatana-commits] [Merge] lp:~ted/indicator-applet/indicator-sorting into lp:indicator-applet

2010-01-18 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-applet/indicator-sorting into lp:indicator-applet. Requested reviews: Indicator Applet Developers (indicator-applet-developers) This branch adds support for indicators being placed inside the applet in a specific order. It also does

[Ayatana-commits] [Merge] lp:~ted/indicator-applet/log-to-file into lp:indicator-applet

2010-01-19 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-applet/log-to-file into lp:indicator-applet. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Making it so the logs go out to a file in an async fashion. This should get us some debug info as things come up

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/remove-revision-from-xml into lp:dbusmenu

2010-01-21 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/remove-revision-from-xml into lp:dbusmenu with lp:~ted/dbusmenu/bug510887 as a prerequisite. Requested reviews: DBus Menu Team (dbusmenu-team) This removes the revision property from the XML file representing the layout. -- https

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/event-timestamp into lp:dbusmenu

2010-01-22 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/event-timestamp into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) This branch adds a property to the event function to have a constant timestamp parameter. It also changes the GTK implementation to use this by calling

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/annoying-image-error into lp:dbusmenu

2010-01-22 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/annoying-image-error into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Changes a g_return_if_fail to be a traditional check. The message that is printed isn't useful and unnecessarily scary. -- https

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/layout-updated into lp:dbusmenu

2010-01-22 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/layout-updated into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Changing all instances of 'LayoutUpdate' to 'LayoutUpdated' as discussed on the dbusmenu list. -- https://code.launchpad.net/~ted/dbusmenu/layout-updated

[Ayatana-commits] [Merge] lp:~ted/libindicate/variable-variants into lp:libindicate

2010-01-31 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/variable-variants into lp:libindicate. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Making the dbus protocol use variants. -- https://code.launchpad.net/~ted/libindicate/variable-variants/+merge/18367

[Ayatana-commits] [Merge] lp:~ted/indicator-session/dbusmenu-activate-change into lp:indicator-session

2010-02-02 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/dbusmenu-activate-change into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Changing prototypes to match the new activate signal. -- https://code.launchpad.net/~ted/indicator

Re: [Ayatana-commits] [Merge] lp:~agateau/dbusmenu/interop into lp:dbusmenu

2010-02-03 Thread Ted Gould
Review: Needs Information On Wed, 2010-02-03 at 01:09 +, Aurélien Gâteau wrote: Implement the agreed property changes. Code looks good, but you need to update the test suite also to match the property changes. It gets very confused right now :) review needs-information --

[Ayatana-commits] [Merge] lp:~ted/libindicate/ayatanize into lp:libindicate

2010-02-03 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/ayatanize into lp:libindicate. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Changing to org.ayatana namespace. -- https://code.launchpad.net/~ted/libindicate/ayatanize/+merge/18554 Your team ayatana

[Ayatana-commits] [Merge] lp:~ted/libindicate/enum-generation into lp:libindicate

2010-02-03 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/enum-generation into lp:libindicate. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Switching everything enum/marshal based to be *much* cleaner. -- https://code.launchpad.net/~ted/libindicate/enum

[Ayatana-commits] [Merge] lp:~ted/libindicate/activate-time-stamp into lp:libindicate

2010-02-03 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/activate-time-stamp into lp:libindicate with lp:~ted/libindicate/ayatanize as a prerequisite. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Adds timestamps to the activate signal. -- https

[Ayatana-commits] [Merge] lp:~indicator-applet-developers/libindicate/ubuntu into lp:libindicate

2010-02-04 Thread Ted Gould
Ted Gould has proposed merging lp:~indicator-applet-developers/libindicate/ubuntu into lp:libindicate. Requested reviews: Sebastien Bacher (seb128) 0.3.0 -- https://code.launchpad.net/~indicator-applet-developers/libindicate/ubuntu/+merge/18649 Your team ayatana-commits is subscribed

[Ayatana-commits] [Merge] lp:~ted/indicator-session/screensaver-proxy-on-request into lp:indicator-session

2010-02-08 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/screensaver-proxy-on-request into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Only building the proxy when we try to do something with the proxy. -- https

[Ayatana-commits] [Merge] lp:~ted/indicator-session/gdm-proxy-remove into lp:indicator-session

2010-02-08 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/gdm-proxy-remove into lp:indicator-session with lp:~ted/indicator-session/screensaver-proxy-on-request as a prerequisite. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Removes a GDM proxy that we

Re: [Ayatana-commits] [Merge] lp:~bratsche/indicator-session/lockdown into lp:indicator-session

2010-02-08 Thread Ted Gould
Review: Approve review approve Small fix, the guest item should also be hidden if there is no user switching. Long term we probably need to refactor so that all the checks for user switching are in one place for both the Switch User... item, the Guest items and the individual user names. --

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/sir-crash-o-lot into lp:indicator-messages

2010-02-08 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/sir-crash-o-lot into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Removing the in brackets creation of a variable that also existed in the function, thus creating a NULL

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/menu-repeat-repeat-repeat into lp:dbusmenu

2010-02-09 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/menu-repeat-repeat-repeat into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) Removing an extra ref to the root item. -- https://code.launchpad.net/~ted/dbusmenu/menu-repeat-repeat-repeat/+merge/18922 Your team ayatana

Re: [Ayatana-commits] [Merge] lp:~dbarth/indicator-session/updated-messages into lp:indicator-session

2010-02-12 Thread Ted Gould
Review: Needs Information On Fri, 2010-02-12 at 08:52 +, David Barth wrote: Reading https://bugs.edge.launchpad.net/hundredpapercuts/+bug/495127 i went on to update messages to reflect the specification at https://wiki.ubuntu.com/SessionTerminationConfirmation. I couldn't find in the

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/default-xml-id into lp:dbusmenu

2010-02-12 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/default-xml-id into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) This patch changes the default XML file sent with the layout to have an ID on it. It really always should have, and since the root item has a fixed ID

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/menuitem-proxy into lp:dbusmenu

2010-02-12 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/menuitem-proxy into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) This branch adds in proxy menu item support. Basically it's just a menu item that looks like the one it's mimicing. But this allows for the menu item

Re: [Ayatana-commits] [Merge] lp:~agateau/libindicate/gvalue into lp:libindicate

2010-02-15 Thread Ted Gould
Review: Needs Information On Mon, 2010-02-15 at 14:48 +, Aurélien Gâteau wrote: Make it possible to get the GValue for a property. Oops, can't believe I forgot this. I also removed the return which prevented the property callback from being called when there is an error (such as a

[Ayatana-commits] [Merge] lp:~dbarth/indicator-session/updated-messages into lp:indicator-session updated

2010-02-16 Thread Ted Gould
The proposal to merge lp:~dbarth/indicator-session/updated-messages into lp:indicator-session has been updated. Status: Needs review = Rejected -- https://code.edge.launchpad.net/~dbarth/indicator-session/updated-messages/+merge/19162 Your team ayatana-commits is subscribed to branch

[Ayatana-commits] [Merge] lp:~ted/indicator-applet/sound-support into lp:indicator-applet

2010-02-16 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-applet/sound-support into lp:indicator-applet. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Need to make sure the sound menu gets in the right place! -- https://code.launchpad.net/~ted/indicator-applet

Re: [Ayatana-commits] [Merge] lp:~pitti/indicator-session/libupower-glib into lp:indicator-session

2010-02-16 Thread Ted Gould
On Tue, 2010-02-16 at 15:28 +, Martin Pitt wrote: Review: Resubmit It uses the _sync calls, but we have a requirement to make all DBus operations async in the various indicator code. I'm unclear whether up_client_get_can_suspend is sync or async. It gets the property synchronously

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/dynamic-commands into lp:indicator-messages

2010-02-17 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/dynamic-commands into lp:indicator-messages with lp:~ted/indicator-messages/static-commands as a prerequisite. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Adds dynamic menu items from

[Ayatana-commits] [Merge] lp:~ted/libindicate/im-client-menu into lp:libindicate

2010-02-17 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/im-client-menu into lp:libindicate. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Adding the ability in the sample code to set dynamic menus. -- https://code.launchpad.net/~ted/libindicate/im-client

[Ayatana-commits] [Merge] lp:~pitti/indicator-session/libupower-glib into lp:indicator-session updated

2010-02-17 Thread Ted Gould
The proposal to merge lp:~pitti/indicator-session/libupower-glib into lp:indicator-session has been updated. Status: Needs review = Rejected -- https://code.edge.launchpad.net/~pitti/indicator-session/libupower-glib/+merge/19392 Your team ayatana-commits is subscribed to branch

Re: [Ayatana-commits] [Merge] lp:~pitti/indicator-session/libupower-glib into lp:indicator-session

2010-02-17 Thread Ted Gould
Accepted merge 19472 so this one is not valid. -- https://code.edge.launchpad.net/~pitti/indicator-session/libupower-glib/+merge/19392 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list:

[Ayatana-commits] [Merge] lp:~ted/indicator-messages/application-active-icon into lp:indicator-messages

2010-02-17 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-messages/application-active-icon into lp:indicator-messages. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Adds an icon to show which applications are running and which ones are not in the menu. -- https

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-messages/dynamic-commands into lp:indicator-messages

2010-02-18 Thread Ted Gould
On Thu, 2010-02-18 at 09:02 +, Neil J. Patel wrote: - You could just send (GFunc)g_object_unref instead of having an explicit func_unref function to the g_list_foreach (though I see why you may not want to). Yeah, I think the problem there is that it's hard to see what you're casting to

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-messages/static-commands into lp:indicator-messages

2010-02-18 Thread Ted Gould
On Thu, 2010-02-18 at 09:22 +, Neil J. Patel wrote: - (desktop_file_from_keyfile) g_key_file_get_string returns a allocated string, so should either free it or just return that Fixed r177 -- https://code.launchpad.net/~ted/indicator-messages/static-commands/+merge/19528 Your team

Re: [Ayatana-commits] [Merge] lp:~dbarth/indicator-session/no-gdm-fix into lp:indicator-session

2010-02-19 Thread Ted Gould
Review: Approve review approve -- https://code.launchpad.net/~dbarth/indicator-session/no-gdm-fix/+merge/19702 Your team ayatana-commits is subscribed to branch lp:indicator-session. ___ Mailing list: https://launchpad.net/~ayatana-commits Post to

[Ayatana-commits] [Merge] lp:~ted/dbusmenu/gi-generation into lp:dbusmenu

2010-02-28 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/dbusmenu/gi-generation into lp:dbusmenu. Requested reviews: DBus Menu Team (dbusmenu-team) This patch adds in GObject introspection to the dbusmenu-glib and -gtk libraries. Wasn't able to figure out how to turn these then into VAPI files

[Ayatana-commits] [Merge] lp:~ted/libindicate/gi-fix-up into lp:libindicate

2010-03-01 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/libindicate/gi-fix-up into lp:libindicate. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Fixing the GObject Introspection. Pulling in the Dbusmenu gir file and removing the GdkPixbuf one that is unneeded. -- https

[Ayatana-commits] [Merge] lp:~ted/indicator-session/free-layout into lp:indicator-session

2010-03-01 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/free-layout into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Fixing a missing unref. -- https://code.launchpad.net/~ted/indicator-session/free-layout/+merge/20418 Your team

[Ayatana-commits] [Merge] lp:~ted/indicator-session/no-ck-errors-for-you into lp:indicator-session

2010-03-01 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/no-ck-errors-for-you into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Switching the get sessions function to using the dbus-glib generated interface to get rid of an error

[Ayatana-commits] [Merge] lp:~ted/indicator-session/removing-me into lp:indicator-session

2010-03-02 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/removing-me into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) This branch started with just wanting to ensure that there isn't a menu item for the currently logged in user

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-session/no-ck-errors-for-you into lp:indicator-session

2010-03-02 Thread Ted Gould
On Tue, 2010-03-02 at 20:23 +, David Barth wrote: Still it feels strange that the xml service definition file is not an external -dev dependency. Ie you have to maintain it in sync with upstream. Is there a way around that? Or then couldn't you trim down the file to just declare the

[Ayatana-commits] [Merge] lp:~ted/indicator-session/real-name-sorting-and-conflicts into lp:indicator-session

2010-03-02 Thread Ted Gould
Ted Gould has proposed merging lp:~ted/indicator-session/real-name-sorting-and-conflicts into lp:indicator-session. Requested reviews: Indicator Applet Developers (indicator-applet-developers) Making it so that the entires are sorted by real name. And if they get in conflict

Re: [Ayatana-commits] [Merge] lp:~ted/indicator-session/removing-me into lp:indicator-session

2010-03-03 Thread Ted Gould
On Tue, 2010-03-02 at 23:12 +, David Barth wrote: Ok, this is a dynamic account... But that loop means that it's going to be very costly on system connected to directories with thousands of entries. I think you should exploit that fact that a guest account is a system one, ie with an

  1   2   3   4   5   6   >