On Thu, Oct 19, 2023, at 8:24 AM, Martin Simmons wrote:
> 28bbfcdc0ed54d5498e82a773e3bf2ed100a9c7c is the commit for the Release-13.0.3
> tag, not the "most recent commit" for either bxattr_freebsd.c or the
> repository as a whole, so I think that is where the misunderstanding started.
>
>
28bbfcdc0ed54d5498e82a773e3bf2ed100a9c7c is the commit for the Release-13.0.3
tag, not the "most recent commit" for either bxattr_freebsd.c or the
repository as a whole, so I think that is where the misunderstanding started.
c0e27eca4f29dfcc000b2156094b867e995a2f64 was the first attempt to fix
Oh wait, I now understanding the misunderstanding.
I went looking for the commit.
https://gitlab.bacula.org/bacula-community-edition/bacula-community/-/commits/c0e27eca4f29dfcc000b2156094b867e995a2f64
I found the most recent commit and clicked on it.
See Fix compilation on FreeBSD
On Wed, Oct 18, 2023, at 4:56 PM, Dan Langille wrote:
> I don't see a reply to my question.
>
> The patch is wrong. The build still fails.
>
> I call again: bring back regression testing for users. Host a cdash instance.
> We have bugs going 5+ months undetected.
>
> This is the correct patch
I don't see a reply to my question.
The patch is wrong. The build still fails.
I call again: bring back regression testing for users. Host a cdash instance.
We have bugs going 5+ months undetected.
This is the correct patch (pasted, so errors may be with tabs)
---
NOTE: the patch in git uses bRC_XATTR_ok
The patch I have uses bRC_BXATTR_ok (note the extra B in my version). My patch
is below.
This patch builds. The patch in git does not. Please advise.
[11:45 pkg01 dan ~/ports/head] % cat
sysutils/bacula13-server/files/patch-src_filed_bxattr_freebsd.c
For those looking for the commit:
https://gitlab.bacula.org/bacula-community-edition/bacula-community/-/commit/c0e27eca4f29dfcc000b2156094b867e995a2f64
Is that the right change?
If I use bRC_XATTR_ok instead, it does compile, but I don't know if that's the
right value.
I ask because.
Hello Dan,
Thanks for the report, I have pushed a fix.
Best Regards,
Eric
On 26.05.23 14:18, Dan Langille wrote:
Hello,
When building bacula13-client-13.0.3 on FreeBSD, I encountered this error.
Compiling bacl.c
Compiling bxattr.c
--- bxattr_freebsd.o ---
bxattr_freebsd.c:106:18: error:
Hello,
When building bacula13-client-13.0.3 on FreeBSD, I encountered this error.
Compiling bacl.c
Compiling bxattr.c
--- bxattr_freebsd.o ---
bxattr_freebsd.c:106:18: error: use of undeclared identifier 'bRC_XACL_ok'; did
you mean 'bRC_BXATTR_ok'?
rc = bRC_XACL_ok;
