Hi Nicklas, I had some time and implemented the 'ServiceFactory' functionality. Gzipped java files are attached. To summarize changes:
1) three new classes/interfaces were created (I put them in net.sf.basedb.ws.client.added package):a) RPCServiceClientCreator - interface containing RPCServiceClient getService(String serviceUrl) method for creating RPCServiceClient objects b) DefaultRPCServiceClientCreator - factory class implementing interface above. It creates RPCServiceClient objects in the way they were created in AbstractRPCClient.getService() method. c) NoChunkRPCServiceClientCreator - the same as above but with CHUNK option set to false.
2) AbstractRPCClient class uses own RPCServiceClientCreator object to create objects in getService() method. Creator object is initialized in constructor (type of creator is an argument of additional constructor). The creator type can be chosen between values supported by AbstractRPCClient, available as public static constants (currently only DEFAULT_RPC_SERVICE_CLIENT and NO_CHUNK_RPC_SERVICE_CLIENT). If no creator type is supplied, default one is used.
3) all the subclasses of AbstractRPCClient have additional constructor with last argument being type of RPCServiceClientCreator which refers to constructor in superclass. This makes possible to choose creator type when programming BASE2 webservices clients.
I attached diffs.txt file which contains diff output onnet/sf/basedb/ws/client/ folders for my version and 2.7.1. Just thought, it might be helpful.
I hope the code will be useful. Best wishes, Pawel Nicklas Nordborg wrote:
Pawel Sztromwasser wrote:Hello BASE developers, We have been recently trying to enable retrieving some data from BASE2 installation directly into our 'home made' analysis tool. We use webservices for that and have to say that you are doing a great job.Thanks.We are really looking forward to use them more extensively.Recently, when I started testing the tool not only within the local network I noticed that the webservice client does not switch off chunking. It results in attached exception cascade. Chunking is on by default in axis2 and some servers (i.e. our gateway to BASE which apparently uses HTTP1.0 and not 1.1) have problems with it. Theremedy is to use options.setProperty(HTTPConstants.CHUNKED, false); in net.sf.basedb.ws.client.AbstractRPCClient.getService(). I don't know what are the drawbacks of it, but that was the only way I could run the services in our current setup (BASE2.6 accessible by proxypass from exposed webserver). Could this option be set off by default or configurable somewhere? Or maybe there is some other workaround?I am afraid that I am not very familiar with all possible options that is available in the Axis API:s. There seems to be a lot of them and their Javadoc is not very informative about what many of the options are used for. The CHUNKED option seems to be related to the way HTTP requests are made, but I have to admit that this is the first time I have heard of it. This means that I probably know even less than you about this.I think that, in the future, there may be more requests about being able to set other options. So, it may be better to think ahead and try to figure out some way to be able to do this as easy as possible. With the current BASE API the only workaround that doesn't involve changing the BASE code is to subclass all AbstractRPCClient subclasses and override the 'getService()' method. This is not very elegent since there are several such classes and the new 'getService()' will be added to each one of them.A better approach may be to create a 'ServiceFactory' interface which has a 'createService()' method. The default implementation would then work as the AbstractRPCClient.getService() does today. The last step is to figure out a way to switch to another 'ServiceFactory' implementation either by having a configuration file or by being able to specify it programmatically.I have opened a ticket for this issue http://base.thep.lu.se/ticket/1057. It falls under the 'contributions welcome' category since right now we are forced to prioritize other things./Nicklas ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ basedb-devel mailing list basedb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/basedb-devel
new_client_package.tar.gz
Description: GNU Zip compressed data
diff net/sf/basedb/ws/client/AbstractRPCClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/AbstractRPCClient.java
32,35d31
< import net.sf.basedb.ws.client.added.DefaultRPCServiceClientCreator;
< import net.sf.basedb.ws.client.added.NoChunkRPCServiceClientCreator;
< import net.sf.basedb.ws.client.added.RPCServiceClientCreator;
<
38a35,36
> import org.apache.axis2.addressing.EndpointReference;
> import org.apache.axis2.client.Options;
50,60d47
< /**
< * Client will use default
org.apache.axis2.rpc.client.RPCServiceClient, no options set
< */
< public static final int DEFAULT_RPC_SERVICE_CLIENT = 1;
<
< /**
< * The same type of RPCServiceClient as default, but with chunked
option set to false
< */
< public static final int NO_CHUNK_RPC_SERVICE_CLIENT = 2;
<
<
63,71d49
< /**
< * RPCServiceClientCreator used in getService() method to create
RPCServiceClient
< */
< private final RPCServiceClientCreator serviceCreator;
<
<
< /**
< * The same as AbstractRPCClient(String, String, int type) with
type=DEFAULT_RPC_SERVICE_CLIENT
< */
74,78d51
< this(url, service, DEFAULT_RPC_SERVICE_CLIENT);
< }
<
< protected AbstractRPCClient(String url, String service, int clientType)
< {
80,87d52
<
< switch (clientType) {
< case NO_CHUNK_RPC_SERVICE_CLIENT:
< serviceCreator = new
NoChunkRPCServiceClientCreator();
< break;
< default:
< serviceCreator = new
DefaultRPCServiceClientCreator();
< }
126d90
< /*
131d94
< options.setProperty(HTTPConstants.CHUNKED, false);
133,134d95
< */
< return serviceCreator.getService(serviceUrl);
Only in net/sf/basedb/ws/client/: added
diff net/sf/basedb/ws/client/AnnotationTypeClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/AnnotationTypeClient.java
48,54c48
< this(session, DEFAULT_RPC_SERVICE_CLIENT);
< }
<
<
< public AnnotationTypeClient(SessionClient session, int clientType)
< {
< super(session.getUrl(), "AnnotationType", clientType);
---
> super(session.getUrl(), "AnnotationType");
58d51
<
diff net/sf/basedb/ws/client/ArrayDesignClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/ArrayDesignClient.java
57,63c57
< this(session, DEFAULT_RPC_SERVICE_CLIENT);
< }
<
<
< public ArrayDesignClient(SessionClient session, int clientType)
< {
< super(session.getUrl(), "ArrayDesign", clientType);
---
> super(session.getUrl(), "ArrayDesign");
66d59
<
diff net/sf/basedb/ws/client/BioAssaySetClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/BioAssaySetClient.java
51,57c51
< this(session, DEFAULT_RPC_SERVICE_CLIENT);
< }
<
<
< public BioAssaySetClient(SessionClient session, int clientType)
< {
< super(session.getUrl(), "BioAssaySet", clientType);
---
> super(session.getUrl(), "BioAssaySet");
61d54
<
diff net/sf/basedb/ws/client/ExperimentClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/ExperimentClient.java
52,57c52
< this(session, DEFAULT_RPC_SERVICE_CLIENT);
< }
<
< public ExperimentClient(SessionClient session, int clientType)
< {
< super(session.getUrl(), "Experiment", clientType);
---
> super(session.getUrl(), "Experiment");
diff net/sf/basedb/ws/client/ProjectClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/ProjectClient.java
48,54c48
< this(session, DEFAULT_RPC_SERVICE_CLIENT);
< }
<
<
< public ProjectClient(SessionClient session, int clientType)
< {
< super(session.getUrl(), "Project", clientType);
---
> super(session.getUrl(), "Project");
diff net/sf/basedb/ws/client/RawBioAssayClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/RawBioAssayClient.java
60,66c60
< this(session, DEFAULT_RPC_SERVICE_CLIENT);
< }
<
<
< public RawBioAssayClient(SessionClient session, int clientType)
< {
< super(session.getUrl(), "RawBioAssay", clientType);
---
> super(session.getUrl(), "RawBioAssay");
diff net/sf/basedb/ws/client/ReporterClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/ReporterClient.java
54,59c54
< this(session, DEFAULT_RPC_SERVICE_CLIENT);
< }
<
< public ReporterClient(SessionClient session, int clientType)
< {
< super(session.getUrl(), "Reporter", clientType);
---
> super(session.getUrl(), "Reporter");
diff net/sf/basedb/ws/client/SessionClient.java
/Home/bccs/pawels/base2/base-2.7.1-src/src/webservices/client/java/net/sf/basedb/ws/client/SessionClient.java
52,54d51
<
< this(url, ID, externalClientId, DEFAULT_RPC_SERVICE_CLIENT);
< /*
58d54
< */
61,70d56
<
< public SessionClient(String url, String ID, String externalClientId,
int clientType)
< throws AxisFault
< {
< super(url, "Session", clientType);
< this.url = url;
< this.ID = ID != null ? ID : invokeBlocking("newSession",
String.class, externalClientId);
< }
<
<
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ basedb-devel mailing list basedb-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/basedb-devel
