Re: [Bash-completion-devel] Bump match_max for test suite?

2010-02-02 Thread Freddy Vulto
On 10:38, Guillaume Rousse wrote: Le 20/01/2010 22:27, Freddy Vulto a écrit : What are your ideas on creating a constant test environment? Would chroot be useful? It seems a bit oversized, and requires root privileges morevoer. I was more thinking about abusing environment variables

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-31 Thread Guillaume Rousse
Le 20/01/2010 22:27, Freddy Vulto a écrit : On 100116 13:51, Guillaume Rousse wrote: Avoiding assumptions whenever possible ensure consistent results, that's my point. The test you describe will fail, without added value to anyone, when run by a user with a 'locanything' host in its

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-16 Thread Crestez Dan Leonard
On Sat, 2010-01-09 at 13:02 +0100, Guillaume Rousse wrote: I guess it's because you have a large rpm db, right ? Should we not try to provide a constant test environement, instead of relying of tester one ? It may be difficult in some case (such as creating a fake rpm db here), but others

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-16 Thread Ville Skyttä
On Friday 15 January 2010, Freddy Vulto wrote: On 100114 20:45, Ville Skyttä wrote: If I'm right, should whitespace be left-trimmed when chunking, or the regexp be changed to tolerate leading whitespace? Yes, I think you're right. `expect' does 'eager matching', so head whitespace on

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-16 Thread Guillaume Rousse
Le 16/01/2010 10:39, Crestez Dan Leonard a écrit : On Sat, 2010-01-09 at 13:02 +0100, Guillaume Rousse wrote: I guess it's because you have a large rpm db, right ? Should we not try to provide a constant test environement, instead of relying of tester one ? It may be difficult in some case

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-15 Thread Freddy Vulto
On 100114 20:45, Ville Skyttä wrote: If I'm right, should whitespace be left-trimmed when chunking, or the regexp be changed to tolerate leading whitespace? Yes, I think you're right. `expect' does 'eager matching', so head whitespace on chunks 1 should be allowed. Maybe somethink like

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-14 Thread Ville Skyttä
On Sunday 10 January 2010, Freddy Vulto wrote: On 100109 13:21, Ville Skyttä wrote: Expect's default buffer size is too small - 2000 bytes according to the man page here - for cases where we have a lot of completions. In addition to rpm, there are at least pkg_info, portupgrade,

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-10 Thread Freddy Vulto
On 100109 13:21, Ville Skyttä wrote: Expect's default buffer size is too small - 2000 bytes according to the man page here - for cases where we have a lot of completions. In addition to rpm, there are at least pkg_info, portupgrade, portinstall, and probably quite a few other tests that

[Bash-completion-devel] Bump match_max for test suite?

2010-01-09 Thread Ville Skyttä
On Saturday 09 January 2010, Ville Skyttä wrote: The following commit has been merged in the master branch: commit 66f5c11ab7894125039fc366c80d651f06587c43 Author: Ville Skyttä ville.sky...@iki.fi Date: Sat Jan 9 11:44:36 2010 +0200 (testsuite) Add simple rpm completion tests. [...]

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-09 Thread Guillaume Rousse
Le 09/01/2010 12:21, Ville Skyttä a écrit : On Saturday 09 January 2010, Ville Skyttä wrote: The following commit has been merged in the master branch: commit 66f5c11ab7894125039fc366c80d651f06587c43 Author: Ville Skyttä ville.sky...@iki.fi Date: Sat Jan 9 11:44:36 2010 +0200

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-09 Thread Ville Skyttä
On Saturday 09 January 2010, Guillaume Rousse wrote: Le 09/01/2010 12:21, Ville Skyttä a écrit : Opinions, should we fiddle with match_max where needed (like lib/completions/rpm.exp above), or should we just bump it to a large value (10?) for all tests? I'm leaning towards the latter.

Re: [Bash-completion-devel] Bump match_max for test suite?

2010-01-09 Thread Guillaume Rousse
Le 09/01/2010 19:54, Ville Skyttä a écrit : On Saturday 09 January 2010, Guillaume Rousse wrote: Le 09/01/2010 12:21, Ville Skyttä a écrit : Opinions, should we fiddle with match_max where needed (like lib/completions/rpm.exp above), or should we just bump it to a large value (10?) for