Re: [Bash-completion-devel] TCL styleguide?

2010-02-06 Thread Freddy Vulto
Ville Skyttä ville.skytta at iki.fi writes: On Friday 05 February 2010, Freddy Vulto wrote: Just to be sure, does that mean we're also not commenting end-of-functions anymore, like: proc assert_complete {} { }; # assert_complete() I wouldn't mind dropping them

Re: [Bash-completion-devel] TCL styleguide?

2010-02-05 Thread Freddy Vulto
On 100204 08:41, Crestez Dan Leonard wrote: What about some guidelines for TCL test code? I only found one style guide floating around: http://wiki.tcl.tk/708 . Good to have one. I added a reference to this Tcl Style Guide to the documentation. ___

Re: [Bash-completion-devel] TCL styleguide?

2010-02-05 Thread Freddy Vulto
On 100205 11:43, Freddy Vulto wrote: On 100204 08:41, Crestez Dan Leonard wrote: There are actually only two things that bug me: 1) Ending blocks with }; # if 2) ... Just to be sure, does that mean we're also not commenting end-of-functions anymore, like: proc assert_complete {} {

Re: [Bash-completion-devel] TCL styleguide?

2010-02-05 Thread Ville Skyttä
On Friday 05 February 2010, Freddy Vulto wrote: On 100205 11:43, Freddy Vulto wrote: On 100204 08:41, Crestez Dan Leonard wrote: There are actually only two things that bug me: 1) Ending blocks with }; # if 2) ... Just to be sure, does that mean we're also not commenting

Re: [Bash-completion-devel] TCL styleguide?

2010-02-04 Thread Freddy Vulto
On 03:05, Crestez Dan Leonard wrote: http://wiki.debian.org/Teams/BashCompletion/Proposals/Roadmap mentions something about merging bash-completion-lib's test suite and it's not marked at done. Mangling library.exp with sed would probably not help. Merging is done actually: I updated the wiki.

Re: [Bash-completion-devel] TCL styleguide?

2010-02-04 Thread Ville Skyttä
On Thursday 04 February 2010, Freddy Vulto wrote: On 08:41, Crestez Dan Leonard wrote: There are actually only two things that bug me: 1) Ending blocks with }; # if 2) Comments that are indented more than the code. This makes code harder to read; only control structures should affect