Re: [BBDB] ChangeLog 2016-10-02: Use lexical binding

2016-10-02 Thread Roland Winkler 
On Sun Oct 2 2016 Sam Steingold wrote:
> I think if you add
> 
> (defvar diary-date-forms)
> 
> to bbdb-anniv.el, it will work with lexical-binding too.

This variable contains forms that are evaluated using `eval',
assuming that the variables appearing in this form are bound
dynamically.  - I believe that old coding schemes like this one,
which are frequently used by the calendar / diray package are a
major reason why emacs has not completely switched to lexical
binding.  If bbdb-anniv.el hooks into the calendar /dirary package,
it needs to follow the conventions of this package till we get a
more complete overhaul of this package (which in turn is hampered by
the fact that calendar /diary has been around for a long time, and
substantial changes in its mode of operation might break more user
customizations).

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/

Re: [BBDB] ChangeLog 2016-10-02: Use lexical binding

2016-10-02 Thread Sam Steingold 
> * Roland Winkler  [2016-10-02 00:20:17 -0500]:
>
> I switched to lexical binding for all elisp files of BBDB except
> for bbdb-anniv.el (which relies on `diary-date-forms' that is not
> compatible with lexical binding).

I think if you add

(defvar diary-date-forms)

to bbdb-anniv.el, it will work with lexical-binding too.

-- 
Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1404
http://steingoldpsychology.com http://www.childpsy.net 
http://thereligionofpeace.com
http://americancensorship.org http://www.dhimmitude.org http://think-israel.org
If you want to shoot yourself, it is YOUR responsibility to wear armor.


--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/