2009/8/10 Larry Finger larry.fin...@lwfinger.net:
Gábor Stefanik wrote:
Implement LP-PHY baseband table init for all revisions.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
Sorry for the size; it's difficult to cut short changes like this
(most of the patch is just table
On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote:
+static const u16 lpphy_sw_control_table[] = {
+ 0x0128,
+ 0x0128,
+ 0x0009,
+ 0x0009,
+ 0x0028,
+ 0x0028,
Is it possible to use more than one value per line for all these tables?
Make sure to make best use of
2009/8/10 Michael Buesch m...@bu3sch.de:
On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote:
+static const u16 lpphy_sw_control_table[] = {
+ 0x0128,
+ 0x0128,
+ 0x0009,
+ 0x0009,
+ 0x0028,
+ 0x0028,
Is it possible to use more than one value per line for all
On Monday 10 August 2009 14:49:31 Gábor Stefanik wrote:
2009/8/10 Michael Buesch m...@bu3sch.de:
On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote:
+static const u16 lpphy_sw_control_table[] = {
+ 0x0128,
+ 0x0128,
+ 0x0009,
+ 0x0009,
+ 0x0028,
+
Well, I converted the tables directly from the Wikitext on
bcm-v4.sipsolutions.net using regex searchreplace - if you
know a good regex to convert the tables to use multiple values
on each line, please post it.
An emacs macro ?
Or use any other editor with an macro capability.
--
Gábor Stefanik wrote:
2009/8/10 Larry Finger larry.fin...@lwfinger.net:
Gábor Stefanik wrote:
Implement LP-PHY baseband table init for all revisions.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
Sorry for the size; it's difficult to cut short changes like this
(most of the
2009/8/10 Larry Finger larry.fin...@lwfinger.net:
Gábor Stefanik wrote:
2009/8/10 Larry Finger larry.fin...@lwfinger.net:
Gábor Stefanik wrote:
Implement LP-PHY baseband table init for all revisions.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
Sorry for the size; it's
Gábor Stefanik wrote:
2009/8/10 Larry Finger larry.fin...@lwfinger.net:
Yes, that would work for the 2.4 GHz band, and I guess there could be
similar routines or macros to split the 5 GHz band into low, medium
and high channels.
AFAIK there is no need to do that - using current_band for
Gábor Stefanik wrote:
+ 0x0128,
+ 0x0128,
+ 0x0009,
+ 0x0009,
+ 0x0028,
+ 0x0028,
Is it possible to use more than one value per line for all these
tables?
if you know a good regex to convert the tables to use multiple
values on each line, please post
On Monday 10 August 2009 14:52:49 Michael Buesch wrote:
On Monday 10 August 2009 14:49:31 Gábor Stefanik wrote:
2009/8/10 Michael Buesch m...@bu3sch.de:
On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote:
+static const u16 lpphy_sw_control_table[] = {
+ 0x0128,
+ 0x0128,
The rev2+ BB init spec has changed behind us, and thus the code is
no longer up to date. Update the code to match the current specs.
Also implement save/restore dig filt state, as required by the
new specification (implemented as 2 separate functions).
Signed-off-by: Gábor Stefanik
On Monday 10 August 2009 20:39:47 Gábor Stefanik wrote:
Implement LP-PHY baseband table init for all revisions.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
Changes from RFC:
-Improved table formatting in the code.
-The 2GHz check in adjust_gain_table now uses
On Monday 10 August 2009 20:42:33 Gábor Stefanik wrote:
+static void lpphy_save_dig_flt_state(struct b43_wldev *dev)
+{
+ static const u16 addr[] = {
+ B43_PHY_OFDM(0xC1),
+ B43_PHY_OFDM(0xC2),
+ B43_PHY_OFDM(0xC3),
+ B43_PHY_OFDM(0xC4),
Also add a SPEX32 macro for extracting 32-bit SPROM variables.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
I'm not quite sure that the SPEX32 macro is sane endianness-wise;
please review it carefully. (In the future, we will probably need
a SPEX64 macro too, to correctly extract
Gábor Stefanik wrote:
Implement LP-PHY baseband table init for all revisions.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
Changes from RFC:
-Improved table formatting in the code.
-The 2GHz check in adjust_gain_table now uses b43_current_band.
-Added a comment to
2009/8/10 Larry Finger larry.fin...@lwfinger.net:
Gábor Stefanik wrote:
Implement LP-PHY baseband table init for all revisions.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
Changes from RFC:
-Improved table formatting in the code.
-The 2GHz check in adjust_gain_table now uses
On Monday 10 August 2009 20:49:02 Gábor Stefanik wrote:
Also add a SPEX32 macro for extracting 32-bit SPROM variables.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
I'm not quite sure that the SPEX32 macro is sane endianness-wise;
please review it carefully. (In the future, we
On Monday 10 August 2009 20:57:06 Gábor Stefanik wrote:
The rev2+ BB init spec has changed behind us, and thus the code is
no longer up to date. Update the code to match the current specs.
Also implement save/restore dig filt state, as required by the
new specification.
Signed-off-by: Gábor
2009/8/10 Michael Buesch m...@bu3sch.de:
On Monday 10 August 2009 20:49:02 Gábor Stefanik wrote:
Also add a SPEX32 macro for extracting 32-bit SPROM variables.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
I'm not quite sure that the SPEX32 macro is sane endianness-wise;
please
On Monday 10 August 2009 21:07:45 Gábor Stefanik wrote:
Also, it seems you need +1 instead of +2 (it is an u16 pointer).
I'm adding to _offset, not to SPOFF(_offset). AFAICS _offset is not an
u16 pointer, it's a plain #defined number, unlike SPOFF(_offset).
Ah ok. All those parenthesis are a
Also add a SPEX32 macro for extracting 32-bit SPROM variables.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
Changes from RFC:
-Fixed a bug in the SPEX32 macro.
-in[SPOFF...] is now cast to u32 to be extra-safe.
The macro still extracts little-endian, as that is probably
what the
2009/8/10 John W. Linville linvi...@tuxdriver.com:
On Mon, Aug 10, 2009 at 08:58:44PM +0200, Gábor Stefanik wrote:
2009/8/10 Larry Finger larry.fin...@lwfinger.net:
Gábor Stefanik wrote:
Implement LP-PHY baseband table init for all revisions.
Signed-off-by: Gábor Stefanik
Some of the new variables in b43_phy_lp appear to be dead code in
the vendor driver; they will be removed if they remain unused when
LP-PHY implementation is finished.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
I've added a few FIXME comments, please review them.
Also please check
I completely missed the one's complement instruction from the specs.
Signed-off-by: Gábor Stefanik netrolller...@gmail.com
---
drivers/net/wireless/b43/phy_lp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/b43/phy_lp.c
24 matches
Mail list logo
