[PATCH] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-12 Thread Gábor Stefanik
Also implement get/set BB mult, get/set TX gain, set RX gain, disable/restore CRS, run/stop DDFS, RX IQ est and QDIV roundup in the process. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Larry, please review the SPEC FIXME comments! drivers/net/wireless/b43/phy_lp.c | 414

Re: [PATCH] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-12 Thread Michael Buesch
On Wednesday 12 August 2009 19:56:25 Gábor Stefanik wrote: + b43_phy_maskset(dev, B43_LPPHY_RF_OVERRIDE_2, 0xFEFF, 18); + b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0x80FF, incr2 3); Can you try to stick to one style? a b is our coding style. +static void

[PATCH v2] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-12 Thread Gábor Stefanik
Also implement get/set BB mult, get/set TX gain, set RX gain, disable/restore CRS, run/stop DDFS, RX IQ est and QDIV roundup in the process. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Changes from v1-v2: -Coding style fixes as suggested by Michael. -Added missing static to

[PATCH] b43: Update dummy transmission to match V4 specs

2009-08-12 Thread Gábor Stefanik
The V4 dummy transmission function has two extra bools in its prototype, so add a wrapper function for callers that expect the V3 version. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/main.c | 60 ---

Re: [PATCH] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-12 Thread Larry Finger
Michael Buesch wrote: On Wednesday 12 August 2009 19:56:25 Gábor Stefanik wrote: + b43_phy_mask(dev, B43_LPPHY_AFE_DDFS_POINTER_INIT, 0x80FF); + b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0xFF80, incr1); + b43_phy_maskset(dev, B43_LPPHY_AFE_DDFS_INCR_INIT, 0x80FF,

Re: [PATCH v2] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-12 Thread Larry Finger
Gábor Stefanik wrote: Also implement get/set BB mult, get/set TX gain, set RX gain, disable/restore CRS, run/stop DDFS, RX IQ est and QDIV roundup in the process. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Changes from v1-v2: -Coding style fixes as suggested by Michael.