Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio

2009-08-14 Thread Gábor Stefanik
2009/8/14 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: Rev0/1/B2062 will now hopefully show some signs of life, though it won't work at full performance, as calibration is still missing. Just compiled wireless-testing.git**, enabled LP phy support in config, to see how far it

Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio

2009-08-14 Thread Mark Huijgen
Gábor Stefanik wrote: ifconfig wlan0 wlan0 Link encap:Ethernet HWaddr FF:FF:FF:FF:FF:FF BROADCAST MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0

Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio

2009-08-14 Thread Gábor Stefanik
2009/8/14 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: ifconfig wlan0 wlan0     Link encap:Ethernet  HWaddr FF:FF:FF:FF:FF:FF          BROADCAST MULTICAST  MTU:1500  Metric:1          RX packets:0 errors:0 dropped:0 overruns:0 frame:0          TX packets:0 errors:0 dropped:0

[Fwd: Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio]

2009-08-14 Thread Mark Huijgen
Sent from wrong email address, so didn't made it to the list. Original Message Subject:Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio Date: Fri, 14 Aug 2009 13:34:34 +0200 Mark Huijgen wrote: Gábor Stefanik wrote: ifconfig wlan0

Re: [PATCH] b43: Add LP-PHY firmware loading support

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 22:20:55 Gábor Stefanik wrote: 2009/8/14 Michael Buesch m...@bu3sch.de: On Friday 14 August 2009 13:51:59 Gábor Stefanik wrote: Add support for loading LP-PHY firmware to b43_try_request_fw. Signed-off-by: Gábor Stefanik netrolller...@gmail.com ack --

Re: [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration

2009-08-14 Thread Larry Finger
Gábor Stefanik wrote: Call set_tx_power_control with a LPPHY_TXPCTL rather than an LPPHY_TX_PWR_CTL_CMD_MODE. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- This should fix the WARN_ON testers were seeing during init. drivers/net/wireless/b43/phy_lp.c |2 +- 1 files

Re: [PATCH] ssb: Fix e typo in the rev8 SPROM extraction routine

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 14:11:53 Gábor Stefanik wrote: No comment. :-) Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Mark, this should fix your MAC address bug. Anyone else testing LP-PHY should also apply this. drivers/ssb/pci.c |2 +- 1 files changed, 1

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch wrote: - b43_phy_mask(dev, 0x048A, (u16)~0x8000); + b43_phy_mask(dev, 0x048A, (u16)(~0x8000 0x)); I would just use 0x7fff here. That does not

[PATCH] b43: LP-PHY: Fix another TX power control abuse

2009-08-14 Thread Gábor Stefanik
This should fix the remaining WARN_ON. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Gábor Stefanik
On Fri, Aug 14, 2009 at 11:00 PM, Michael Bueschm...@bu3sch.de wrote: On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch wrote: -                 b43_phy_mask(dev, 0x048A, (u16)~0x8000); +                 b43_phy_mask(dev, 0x048A,

Re: [PATCH] b43: LP-PHY: Fix another TX power control abuse

2009-08-14 Thread Larry Finger
Gábor Stefanik wrote: This should fix the remaining WARN_ON. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Larry Finger
Michael Buesch wrote: On Friday 14 August 2009 00:15:07 Larry Finger wrote: The b43 driver generates the following sparse warnings: CHECK drivers/net/wireless/b43/phy_g.c drivers/net/wireless/b43/phy_g.c:974:35: warning: cast truncates bits from constant value (7fff becomes 7fff)

Re: [PATCH] b43: LP-PHY: Fix another TX power control abuse

2009-08-14 Thread Gábor Stefanik
2009/8/14 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: This should fix the remaining WARN_ON. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |    7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] b43: LP-PHY: Fix another TX power control abuse

2009-08-14 Thread Larry Finger
Gábor Stefanik wrote: 2009/8/14 Larry Finger larry.fin...@lwfinger.net: Yes, this one got rid of the warnings. Larry I guess the device still doesn't TX/RX. Not yet. The fact that it keeps getting shut down/restarted indicates that the TX operations are not completing. I'm currently

[PATCH] b43: Handle B43_PHYTYPE_LP in RX path

2009-08-14 Thread Gábor Stefanik
Don't drop all packets received from an LP-PHY with WARN_ON. Also update a comment with LP-specific information. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/wa.c |2 +- drivers/net/wireless/b43/xmit.c |1 + 2 files changed, 2 insertions(+), 1