[PATCH] b43: Enable LP-PHY support by default and remove Kconfig warning

2009-08-27 Thread Gábor Stefanik
The most common LP-PHY device, BCM4312, is now fully functional. So, no need to say probably won't work for you anymore. It's also not for debuggers and developers only, as it is perfectly usable for end-users now (at least for BCM4312). Signed-off-by: Gábor Stefanik netrolller...@gmail.com ---

Re: [PATCH] b43: Enable LP-PHY support by default and remove Kconfig warning

2009-08-27 Thread Larry Finger
Gábor Stefanik wrote: The most common LP-PHY device, BCM4312, is now fully functional. So, no need to say probably won't work for you anymore. It's also not for debuggers and developers only, as it is perfectly usable for end-users now (at least for BCM4312). Signed-off-by: Gábor Stefanik

[PATCH v2] b43: Enable LP-PHY support by default and remove Kconfig warning

2009-08-27 Thread Gábor Stefanik
The most common LP-PHY device, BCM4312, is now fully functional. So, no need to say probably won't work for you anymore. It's also not for debuggers and developers only, as it is perfectly usable for end-users now (at least for BCM4312). Signed-off-by: Gábor Stefanik netrolller...@gmail.com ---

[RFC/RFT] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Gábor Stefanik
Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- This intentionally deviates slightly from the spec (writing the antenna ID in one pass instead of two) - please test if this works. (I don't have the tools to test if it actually selects the right antenna.) The A/G-PHY changes are fallout

[PATCH] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Gábor Stefanik
The A/G-PHY changes are fallout fixes from the enum change, which in turn allows the LP-PHY code to be much simpler. The antenna_to_phyctl change is a fix for a potential existing bug that this patch may otherwise trigger. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Note that

Re: [PATCH] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Michael Buesch
On Thursday 27 August 2009 20:56:22 Gábor Stefanik wrote: The A/G-PHY changes are fallout fixes from the enum change, which in turn allows the LP-PHY code to be much simpler. The antenna_to_phyctl change is a fix for a potential existing bug that this patch may otherwise trigger.

Re: [PATCH] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Gábor Stefanik
2009/8/27 Michael Buesch m...@bu3sch.de: On Thursday 27 August 2009 20:56:22 Gábor Stefanik wrote: The A/G-PHY changes are fallout fixes from the enum change, which in turn allows the LP-PHY code to be much simpler. The antenna_to_phyctl change is a fix for a potential existing bug that this

[PATCH v2] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Gábor Stefanik
The A/G-PHY changes are fallout fixes from the enum change, which in turn allows the LP-PHY code to be much simpler. The antenna_to_phyctl change is a fix for a potential existing bug that this patch may otherwise trigger. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- v2: Fix a typo.

Re: [PATCH] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Larry Finger
Gábor Stefanik wrote: static void b43_lpphy_op_set_rx_antenna(struct b43_wldev *dev, int antenna) { -//TODO +int autodiv = ; + +if (dev-phy.rev = 2) +return; // rev2+ doesn't support antenna diversity + +if (B43_WARN_ON(antenna B43_ANTENNA_AUTO1)) +