Re: [PATCH] b43: Fix sparse warnings

2009-08-18 Thread Michael Buesch
On Monday 17 August 2009 22:30:41 Pavel Roskin wrote: On Sat, 2009-08-15 at 12:04 +0200, Michael Buesch wrote: I still do not understand why it does complain about an _explicit_ truncation. That's simply stupid. If I program an explicit truncation I _do_ mean to truncate the value.

Re: [PATCH] b43: Fix sparse warnings

2009-08-15 Thread Michael Buesch
On Friday 14 August 2009 23:35:29 Pavel Roskin wrote: On Fri, 2009-08-14 at 23:04 +0200, Gábor Stefanik wrote: On Fri, Aug 14, 2009 at 11:00 PM, Michael Bueschm...@bu3sch.de wrote: On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch

Re: [PATCH] b43: Fix sparse warnings

2009-08-15 Thread Michael Buesch
On Friday 14 August 2009 23:46:54 Pavel Roskin wrote: On Fri, 2009-08-14 at 17:29 -0400, Pavel Roskin wrote: On Fri, 2009-08-14 at 23:00 +0200, Michael Buesch wrote: On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch wrote:

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Michael Buesch
On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch wrote: - b43_phy_mask(dev, 0x048A, (u16)~0x8000); + b43_phy_mask(dev, 0x048A, (u16)(~0x8000 0x)); I would just use 0x7fff here. That does not

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Gábor Stefanik
On Fri, Aug 14, 2009 at 11:00 PM, Michael Bueschm...@bu3sch.de wrote: On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch wrote: -                 b43_phy_mask(dev, 0x048A, (u16)~0x8000); +                 b43_phy_mask(dev, 0x048A,

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Larry Finger
Michael Buesch wrote: On Friday 14 August 2009 00:15:07 Larry Finger wrote: The b43 driver generates the following sparse warnings: CHECK drivers/net/wireless/b43/phy_g.c drivers/net/wireless/b43/phy_g.c:974:35: warning: cast truncates bits from constant value (7fff becomes 7fff)

[PATCH] b43: Fix sparse warnings.

2007-09-19 Thread Michael Buesch
The remaining warning in phy.c will be fixed later. Signed-off-by: Michael Buesch [EMAIL PROTECTED] Index: wireless-dev/drivers/net/wireless/b43/pio.c === --- wireless-dev.orig/drivers/net/wireless/b43/pio.c2007-09-19