[PATCH RFC] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Gábor Stefanik
Also add a SPEX32 macro for extracting 32-bit SPROM variables. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- I'm not quite sure that the SPEX32 macro is sane endianness-wise; please review it carefully. (In the future, we will probably need a SPEX64 macro too, to correctly extract

Re: [PATCH RFC] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 20:49:02 Gábor Stefanik wrote: Also add a SPEX32 macro for extracting 32-bit SPROM variables. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- I'm not quite sure that the SPEX32 macro is sane endianness-wise; please review it carefully. (In the future, we

Re: [PATCH RFC] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Gábor Stefanik
2009/8/10 Michael Buesch m...@bu3sch.de: On Monday 10 August 2009 20:49:02 Gábor Stefanik wrote: Also add a SPEX32 macro for extracting 32-bit SPROM variables. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- I'm not quite sure that the SPEX32 macro is sane endianness-wise; please

Re: [PATCH RFC] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Michael Buesch
On Monday 10 August 2009 21:07:45 Gábor Stefanik wrote: Also, it seems you need +1 instead of +2 (it is an u16 pointer). I'm adding to _offset, not to SPOFF(_offset). AFAICS _offset is not an u16 pointer, it's a plain #defined number, unlike SPOFF(_offset). Ah ok. All those parenthesis are a