[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12313080
]
daryoush mehrtash commented on BEEHIVE-717:
---
Thanks eddie for the commit and the Asserts you added improved the code, well
except this one (line 82 on Control
[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12313093
]
Eddie O'Neil commented on BEEHIVE-717:
--
Daryoush--
Hey, so the reason I changed that is because of the comment Should not happen,
just being paranoid.
In general,
[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12313100
]
daryoush mehrtash commented on BEEHIVE-717:
---
In this case I think we should not do assert. You do have a good point on
Asserts in general.
minor
[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12313112
]
Eddie O'Neil commented on BEEHIVE-717:
--
Okay, so, we'll remove the check (assert and conditional) entirely then? Or is
this an expected case that needs to be
[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12313117
]
daryoush mehrtash commented on BEEHIVE-717:
---
my suggestion is to remove the assert leave the code in.
minor non-conformance of exceptions to JSR-181 / JAX-RPC
[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12312937
]
daryoush mehrtash commented on BEEHIVE-717:
---
Daryoush -- Hey; thanks for the patch! A couple of comments:
- the AxisFaultAdaptor seems to be missing the ASF
[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12312940
]
Eddie O'Neil commented on BEEHIVE-717:
--
Daryoush--
Gotcha -- one question I have is about whether the ControlProvider would ever
throw an AxisFault and if it did why
[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12312819
]
daryoush mehrtash commented on BEEHIVE-717:
---
There are two problems with Faults.
If the JWS is called from the URL, Axis would not serialize the fault properly
[
http://issues.apache.org/jira/browse/BEEHIVE-717?page=comments#action_12312826
]
Eddie O'Neil commented on BEEHIVE-717:
--
Daryoush -- Hey; thanks for the patch! A couple of comments:
- the AxisFaultAdaptor seems to be missing the ASF copyright /
