Re: [Bitcoin-development] bitcoin pull requests

2013-04-03 Thread grarpamp
gpg signing commits, like the Linux kernel Though, honestly, when I ACK that means I read the code, which is more important than the author really. github seems fine for that still, though I do wonder if there is a race possible, * just before I click pull, sneak rebases the branch to

Re: [Bitcoin-development] bitcoin pull requests

2013-04-03 Thread Gavin Andresen
I would rather we spend time working to make users' bitcoins safe EVEN IF their bitcoin software is compromised. Eliminate the if you get a bad bitcoin-qt.exe somehow you're in big trouble risk entirely, instead of worrying about unlikely scenarios like a timing attack in between ACKs/pulls.

Re: [Bitcoin-development] bitcoin pull requests

2013-04-03 Thread grarpamp
Users will have available multisig addresses which require transactions to be signed off by a wallet HSM. (E.g. a keyfob Hardware is a good thing. But only if you do the crypto in the hardware and trust the hardware and its attack models ;) For instance, the fingerprint readers you see