[blink-dev] Re: Intent to Ship: Allow top layer elements to be nested within popovers

2024-03-26 Thread Domenic Denicola
LGTM1. I think there is a small compat risk here but it should be manageable via the combination of: low popover + dialog usage so far, presumably by actively-updated sites, and a Finch flag if something breaks really badly. On Wednesday, March 27, 2024 at 2:58:51 AM UTC+9 Mason Freed wrote:

[blink-dev] Re: Intent to Ship: visualViewport.onscrollend Support

2024-03-26 Thread Domenic Denicola
LGTM1, this is a very small change that IMO does not require any signals or TAG review. It's just bringing this event in line with all other events on the platform. (It would be cool if there were some automated way of preventing this kind of omission in the future.) On Wednesday, March 27,

Re: [blink-dev] Intent to Ship: Add JavaScript timer wake up alignment for unimportant cross-origin frames

2024-03-26 Thread Domenic Denicola
LGTM3. With my HTML Standard editor hat on, I agree that this area does not benefit from tight specification. However, in the past we've seen web developers be pretty confused by what each browser's behavior is, for this and other inactive-tab / offscreen-iframe / etc. throttling behaviors.

LRe: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-26 Thread Domenic Denicola
LGTM3 On Wednesday, March 27, 2024 at 4:45:08 AM UTC+9 Mike Taylor wrote: > LGTM2 > On 3/26/24 1:25 PM, Yoav Weiss (@Shopify) wrote: > > LGTM1 once the fix > to > the above issue lands. > > On Monday, March 18, 2024 at 7:56:52 

[blink-dev] Intent to Ship: visualViewport.onscrollend Support

2024-03-26 Thread David Awogbemila
Contact emailsawogbem...@google.com ExplainerNone Specification https://drafts.csswg.org/cssom-view/#the-visualviewport-interface Summary Scrollend is a JavaScript event that fires to signal that a scrolling operation has come to an end. Similar to the Element interface[1], the visualViewport

[blink-dev] Intent to Implement and Ship: OpusEncoderConfig `signal` and `application` parameters

2024-03-26 Thread Thomas Guilbert
Contact emailstguilb...@chromium.org ExplainerNone Specification https://w3c.github.io/webcodecs/opus_codec_registration.html#dom-opusencoderconfig-signal Summary `OpusEncoderConfig.signal` and `OpusEncoderConfig.application` were recently added to the WebCodecs spec [1]. Both parameters are

[blink-dev] Intent for Reverse Origin Trial: Media Previews opt-out

2024-03-26 Thread mark a. foltz
Contact emailsmfo...@chromium.org, bryantchand...@chromium.org ExplainerNone Specification https://docs.google.com/document/d/1ZnX2JROjr9l4y2_OPMpfVlLOo-A5cQzD4mWarj9kXQ0/edit Design docs https://docs.google.com/document/d/1ZnX2JROjr9l4y2_OPMpfVlLOo-A5cQzD4mWarj9kXQ0/edit Summary Allow

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-26 Thread Mike Taylor
LGTM2 On 3/26/24 1:25 PM, Yoav Weiss (@Shopify) wrote: LGTM1 once the fix to the above issue lands. On Monday, March 18, 2024 at 7:56:52 PM UTC+1 yshal...@microsoft.com wrote: Yes, I believe the bug [1] is a blocker.

Re: [blink-dev] Intent to Ship: Add JavaScript timer wake up alignment for unimportant cross-origin frames

2024-03-26 Thread Mike Taylor
LGTM2 On 3/26/24 1:27 PM, Yoav Weiss (@Shopify) wrote: LGTM1 On Monday, March 25, 2024 at 4:42:55 PM UTC+1 Mike Taylor wrote: Thank you for the answers Etienne. Once the Testing bit has been requested, I'm happy to give an LGTM. On 3/25/24 11:08 AM, Etienne Pierre-doray wrote:

[blink-dev] Re: Intent to Ship: Attribution Reporting Feature Bundle: Header Error Debug Reports, Preferred Platform field, Changing Source Deactivation

2024-03-26 Thread 'Akash Nadan' via blink-dev
Hi Yoav, the reasoning behind this change is that there is a privacy gap with the current attribution flow and position of the source deactivation logic. The current position of the source deactivation logic makes it possible for API callers to identify when a source is noise (versus a real

Re: [blink-dev] Intent to Ship: CSS view-transition-class and class VT argument syntax

2024-03-26 Thread Yoav Weiss (@Shopify)
LGTM3 On Friday, March 22, 2024 at 8:01:46 PM UTC+1 Chris Harrelson wrote: > LGTM2 > > On Fri, Mar 22, 2024 at 11:46 AM Mike Taylor > wrote: > >> LGTM1 >> On 3/20/24 2:27 PM, Vladimir Levin wrote: >> >> Contact emails vmp...@chromium.org, nrosent...@chromium.org >> >> Explainer >>

[blink-dev] Intent to Ship: Allow top layer elements to be nested within popovers

2024-03-26 Thread Mason Freed
Contact emailsmas...@chromium.org ExplainerNone Specificationhttps://github.com/whatwg/html/pull/10116 Summary The prior behavior caused issues if a top layer element (dialog, fullscreen, etc.) was DOM-nested within a popover. The inner element, when promoted to the top layer, would cause the

[blink-dev] Re: Intent to Ship: Attribution Reporting Feature Bundle: Header Error Debug Reports, Preferred Platform field, Changing Source Deactivation

2024-03-26 Thread Yoav Weiss (@Shopify)
On Tuesday, March 19, 2024 at 12:18:00 AM UTC+1 Akash Nadan wrote: Contact emails akashna...@google.com, lin...@chromium.org, johni...@chromium.org Explainer Attribution Reporting with event-level reports Attribution

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-26 Thread Stefan Zager
On Tue, Mar 26, 2024 at 10:33 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM3 assuming that the gradients bug mentioned upthread is resolved in > https://issues.chromium.org/issues/40362923#comment36 > Yes, it is fixed. > > On Friday, March 22, 2024 at 8:00:56 PM UTC+1 Chris

Re: [blink-dev] Intent to Ship: SVG context-fill and context-stroke

2024-03-26 Thread Yoav Weiss (@Shopify)
LGTM3 assuming that the gradients bug mentioned upthread is resolved in https://issues.chromium.org/issues/40362923#comment36 On Friday, March 22, 2024 at 8:00:56 PM UTC+1 Chris Harrelson wrote: > LGTM2 > > On Fri, Mar 22, 2024 at 11:47 AM Mike Taylor > wrote: > >> LGTM1 >> On 3/18/24 10:53

Re: [blink-dev] Intent to Ship: Add JavaScript timer wake up alignment for unimportant cross-origin frames

2024-03-26 Thread Yoav Weiss (@Shopify)
LGTM1 On Monday, March 25, 2024 at 4:42:55 PM UTC+1 Mike Taylor wrote: > Thank you for the answers Etienne. Once the Testing bit has been > requested, I'm happy to give an LGTM. > On 3/25/24 11:08 AM, Etienne Pierre-doray wrote: > > Right - that's my question. I also asked how similar this

Re: [blink-dev] Intent to Ship: Used color scheme root scrollbars

2024-03-26 Thread Yoav Weiss (@Shopify)
LGTM1 once the fix to the above issue lands. On Monday, March 18, 2024 at 7:56:52 PM UTC+1 yshal...@microsoft.com wrote: > Yes, I believe the bug [1] is a blocker. > > [1] https://issues.chromium.org/issues/328102503. > > On