Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-09-06 Thread Yoav Weiss
SG! My LGTM still stands :) On Tue, Sep 6, 2022 at 3:52 PM Dave Tapuska wrote: > BFCache has different behavior. Pages are evicted if an extension tries to > communicate with something that is in the cache. We did outreach to help > increase BFCache rates because we know what extensions cause

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-09-06 Thread Dave Tapuska
BFCache has different behavior. Pages are evicted if an extension tries to communicate with something that is in the cache. We did outreach to help increase BFCache rates because we know what extensions cause eviction. In terms of prerender it is different because extensions can modify/block

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-09-05 Thread Yoav Weiss
Thanks!! Were extensions affected by previous multi-page arch shipped features, such as BFCache? Is there a way for us to scan the various extension stores, look for patterns that would be affected by this change and notify the extension's authors ahead of time? On Thu, Sep 1, 2022 at 4:23 PM

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-09-01 Thread Dave Tapuska
I drafted a blog post highlighting the additions/changes to the extension APIs. It is just going through reviews before being posted to developer.chrome.com, hopefully sometime next week. dave. On Thu, Sep 1, 2022 at 2:49 AM Yoav Weiss wrote: > > > On Thu, Sep 1, 2022 at 8:24 AM Takashi

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-09-01 Thread Yoav Weiss
On Thu, Sep 1, 2022 at 8:24 AM Takashi Toyoshima wrote: > Thank you for the feedback. > > Yes, the Extensions is the thing we have paid the biggest attention to > support Prerendering on Desktop. > > https://docs.google.com/document/d/16Sy2Xq-AcnhwnpC0q232OMSmxTpQYDANRAO-zJ8DKiA/edit?usp=sharing

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-09-01 Thread Takashi Toyoshima
Thank you for the feedback. Yes, the Extensions is the thing we have paid the biggest attention to support Prerendering on Desktop. https://docs.google.com/document/d/16Sy2Xq-AcnhwnpC0q232OMSmxTpQYDANRAO-zJ8DKiA/edit?usp=sharing This is the document we discussed especially on Prerendering and

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-31 Thread Daniel Bratell
In addition to the LGTM, I want to point out that during our discussion among the API Owners, we did specifically wonder about extension compatibility. Since this will change things for extensions, I think it will be important to look for compatibility problems popping up, and, if necessary,

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-31 Thread Daniel Bratell
LGTM3 /Daniel On 2022-08-30 10:58, Yoav Weiss wrote: LGTM2 to expand support for desktop. On Tue, Aug 30, 2022 at 8:53 AM TAMURA, Kent wrote: LGTM1. It's pretty safe to expand support to desktop platforms, and it seemsĀ there are no negative signals. On Thu, Aug 18, 2022 at

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-30 Thread Yoav Weiss
LGTM2 to expand support for desktop. On Tue, Aug 30, 2022 at 8:53 AM TAMURA, Kent wrote: > LGTM1. > It's pretty safe to expand support to desktop platforms, and it > seems there are no negative signals. > > On Thu, Aug 18, 2022 at 4:07 PM 'Angel Raposo' via blink-dev < > blink-dev@chromium.org>

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-30 Thread TAMURA, Kent
LGTM1. It's pretty safe to expand support to desktop platforms, and it seems there are no negative signals. On Thu, Aug 18, 2022 at 4:07 PM 'Angel Raposo' via blink-dev < blink-dev@chromium.org> wrote: > Contact emails > > toyos...@chromium.org, angelrapo...@google.com > > Explainer > > This I2S

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-29 Thread Takashi Toyoshima
Hi, Joe. Thank you for your feedback. On Thu, Aug 25, 2022 at 2:06 AM 'Joe Medley' via blink-dev < blink-dev@chromium.org> wrote: > I think you did everything as right as anyone could. Chrome Status is a > bit confusing when it comes to shipping milestones and flags. > > The only thing required

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-24 Thread 'Joe Medley' via blink-dev
I think you did everything as right as anyone could. Chrome Status is a bit confusing when it comes to shipping milestones and flags. The only thing required for a finch experiment is the "Finch experiment:" field, which takes a CR bug. Edit your feature, click "Edit all fields", then search for

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-24 Thread 'Angel Raposo' via blink-dev
Hi Joe, We started the beta behind a finch flag with m105. Can you point me out to where I need to replace the DevTile milestone? I'm quite new on the role, helping the team on a 20% capacity so I may have misconfigured something in the Chromestatus entry before generating this template? Thanks,

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-23 Thread 'Angel Raposo' via blink-dev
Hi Joe, Thanks for your questions, Let me share some background of the project situation: Prerender loads and renders high-likely to be visited web pages before the user actually navigates to them, based on different triggers. We've already launched a few triggers for Android in stable, e.g.:

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-23 Thread 'Joe Medley' via blink-dev
I think I know why I'm confused, please tell me if this is correct. Did you label this as being behind a flag (DevTrial) because it's under a Finch flag? The DevTile milestone fields do not apply to finch flags. In which version of beta did the Finch experiment start? Joe Medley | Technical

Re: [blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-22 Thread 'Joe Medley' via blink-dev
Angel, Can you please clarify a few things for me. I'm trying to work out whether this is eligible for listing in the beta announcement . You said this shipped in Android already. I only see that it is behind a flag in Android. When was this enabled

[blink-dev] Intent to Ship: Prerender2 for Desktop

2022-08-18 Thread 'Angel Raposo' via blink-dev
Contact emails toyos...@chromium.org, angelrapo...@google.com Explainer This I2S aims to expand our efforts on Prerender2 (currently shipped only on Android) to Desktop. The full prerendering revamped explainer can be found at https://github.com/WICG/nav-speculation/blob/main/README.md