Hi Ikumi and Uwe,
Thanks to both of you for your feedback.
I agree that it's better to have begin/end line up when all else is
equal, but with the current state of AUCTeX (since this bug was
introduced), it is a severe user error to put \begin{array} on a line
following non-whitespace. The
Hi Uwe,
> Just a short comment, why don't to combine both package to one single
> repository, since czm-tex-edit.el requires dynexp.el?
> That would make it a bit easier to install.
>
>
> I will try to test them in the coming days.
>
Thanks for your feedback on this. I only recently got around
Hi Uwe,
Thanks for your response. First I'll respond to the minor points:
> You say indent-region
>
> I am referring here to the LaTeX-filling-functions, such as
> LaTeX-fill-environment, LaTeX-fill-section etc
There's no important difference here between indent-region and the
LaTeX fill
Looks good to me (I prefer it over my original suggestion). Thanks!
On Sat, Sep 9, 2023 at 8:52 AM Ikumi Keita wrote:
> Hi Paul and Uwe,
>
> >>>>> Paul Nelson writes:
> > As for the "always-align t" case, there are still some natural "broken"
Hi Uwe,
I don't see the behavior you describe; on my end, filling does not change
the latex you provided. I've tried it with LaTeX-fill-environment and
indent-region.
Also, with this patch, the setting LaTeX-indent-always-align-end-with-begin
no longer seems relevant. Maybe you tried applying
Take a LaTeX buffer with a nested environment where the inner \begin{}
follows some non-whitespace:
#+begin_src latex
\begin{equation*}
g=\begin{pmatrix}
a & b \\
c & d \\
\end{pmatrix}
\end{equation*}
#+end_src
After =M-x mark-whole-buffer= and =M-x indent-region=, the outer
\end{}
Hi Ikumi,
Thanks for sharing your tentative patch.
The "always-align nil" behavior looks good to me.
As for the "always-align t" case, there are still some natural "broken"
examples, as you know:
#+begin_src latex
\begin{equation*}
g = \begin{pmatrix}
a & b \\
c & d \\
R
-DNOPLATFONTS -dPrinted -dTextAlphaBits\=4 -dGraphicsAlphaBits\=4
-sDEVICE\=pnmraw -r238.169x239.282''
Preview-Ghostscript finished at Sat Mar 25 17:42:58
On Sat, Mar 25, 2023 at 5:41 PM David Kastrup wrote:
> Paul Nelson writes:
>
> > Emacs : GNU Emacs 29.0.50 (build 3, x86_64-a
Emacs : GNU Emacs 29.0.50 (build 3, x86_64-apple-darwin21.6.0, NS
appkit-2113.60 Version 12.6 (Build 21G115))
of 2022-11-06
Package: 13.1.10
Take the following document:
#+begin_src latex
\documentclass{amsart}
\begin{document}
$x$ $x$
\end{document}
#+end_src
Run ~preview-region~ on the
Hello,
This patch has no effect on current behavior, but introduces a
variable preview-find-end-function that would allow (e.g.) an external
package to modify how previews overlays are placed, without resorting
to advice.
The code needed to be rearranged a bit because the implementation of
Hello,
Steps to reproduce:
- Disable transient-mark-mode.
- Create test.tex containing "\emph{foo} \emph{bar}".
- Move point inside "foo" and set the mark (C-SPC). Note that this
does not "activate the region".
- TeX-fold-buffer (C-c C-o C-b).
- Move the point into "bar".
What should happen is
Hi Arash,
> How do you generate the changelog above? When I paste the entry in my
> ChangeLog inside my local repo and re-fill, it looks like this:
>
> * tex-fold.el (TeX-fold-hide-item): Call folding spec with point
> at beginning of item.
> * doc/auctex.texi (Folding): Mention the new
Hello,
This patch adds section folding commands, so as to bring the interface
for folding more in line with that for previewing.
Thanks, best,
Paul
0001-Add-section-folding-commands.patch
Description: Binary data
___
bug-auctex mailing list
Hi Arash, sorry, must have messed up - I’ll be happy to redo and resend
it. Thanks, best, Paul
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
See attached, and let me know if I missed anything else. Thanks, best, Paul
0001-Make-preview-placement-more-flexible.patch
Description: Binary data
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
Whew, thanks. (I was about to respond with "Hmm, with this one, the
patch works for me, and when I attempt to regenerate the patch using
the latest fetch from master, the resulting patch is identical to the
one that I had sent." Glad it worked out!)
On Wed, Apr 17, 2024 at 10:35 PM Arash Esbati
I'm checking the other patches I sent to see if I messed any of them
up, and noticed that I did with this one. Attaching the fixed patch
0001-Make-locating-previews.-message-configurable.patch
Description: Binary data
___
bug-auctex mailing list
Steps to reproduce:
- Create test.tex with a valid equation environment.
- Put the point inside the equation environment.
- preview-buffer
When the preview generates, the point is ejected from the equation
environment due to the new overlay.
With this patch, the preview instead temporarily
This patch makes the following changes, having no effect on behavior:
- The variable preview--region-begin, introduced in the fix to
Bug#62445, is replaced with preview-current-region, which is a cons
cell (begin . end) keeping track of the complete region.
- That variable is set to nil in
Sorry about that, I was sloppy in splitting up a commit. The fix is:
(setq close-data (nconc ovl close-data))
->
(setq close-data (nconc ovl close-data)))
If it's easier for you, I'm happy to resend the patch.
___
bug-auctex mailing list
> Sorry about that, I was sloppy in splitting up a commit. The fix is:
In more detail, the "fix" is contained in the patch I submitted later
at #70442, and the issue arose when I split some commit into this
patch and that one. One way to proceed would be to squash those two
patches, if the
Hi Arash, sure thing. I'll use "preview-protect-point" for the name
of the user option unless you can immediately think of something
better, and send the patch in a bit. Thanks, Paul
___
bug-auctex mailing list
bug-auctex@gnu.org
Actually, I'll wait until the correction for the parenthesis from
bug#70348 is available on master, so as to avoid faulty patches.
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
Thanks, I see it now. Please see attached.
0001-Add-new-custom-option-preview-protect-point.patch
Description: Binary data
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
le'.
Thanks, best,
Paul
From acd41e3a761b5140055e2ea8cf500a15f747bf76 Mon Sep 17 00:00:00 2001
From: Paul Nelson
Date: Thu, 11 Apr 2024 23:09:28 +0200
Subject: [PATCH] Allow opened previews to remain visible
* preview.el.in (preview-leave-open-previews-visible): New user
option.
(preview-gs-place, preview-di
Hi Arash, many thanks for taking a look. Regarding cl-find-if, I have
no strong feelings, but have attached the modified patch without it in
case that simplifies matters. Thanks, best, Paul
0001-Allow-opened-previews-to-remain-visible.patch
Description: Binary data
Hi Ikumi,
> >> - When you enter a preview, it remains visible. The tex code appears
> >> below the preview.
>
> The TeX code appears _to right of_ the preview for inline math
> expression for me. Is this a misbehavior? Or does your above sentence
> miss this case?
You're right, for inlined
> Thanks for clarification. If I understand correctly, "use the image from
> the old overlay in place of the construction symbol" means that the user
> can't tell whether a particular preview image is to be updated
> afterwards or has already been updated, by its appearance only, during
> the
Hi Ikumi,
> Ah, I see. Thanks for confirmation. I didn't try region preview. The
> previews do appear in the indirect buffer if I type C-c C-p C-b etc.
>
> I expect you see what I described if you type C-c C-p C-d in the
> indirect buffer.
OK, good -- we're on the same page then.
For whatever
Sounds good, thanks! Paul
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
to a list, (defcustom preview-auto-reveal-commands).
Similarly for TeX-fold-auto-reveal.
Thanks, best,
Paul
From 69772c95c0a0eb7b417bbf1e7e5f295a8868575c Mon Sep 17 00:00:00 2001
From: Paul Nelson
Date: Tue, 23 Apr 2024 05:49:01 +0200
Subject: [PATCH] Make auto-reveal customizations easier
Hello,
This patch makes the "locating previews..." message displayed by
preview-parse-messages configurable via a variable.
The motivation is that the package
https://github.com/ultronozm/czm-preview.el has a minor mode that
calls preview-region on a timer. That package advises
Hello,
preview-section and preview-clearout-section activate the region, but
I don't think they should, hence this patch.
Thanks, best,
Paul
0001-Make-preview-section-commands-preserve-mark.patch
Description: Binary data
___
bug-auctex mailing list
s?
Thanks, best,
Paul
On Sun, Apr 14, 2024 at 3:42 PM Arash Esbati wrote:
>
> Hi Paul,
>
> Paul Nelson writes:
>
> > I've generally been trying to remember to set fill-column to 63
> > (following my interpretation of
> > https://git.savannah.gnu.org/cgit/emacs
(directory-file-name root)))
(assn (assoc name git-fill-column-alist)))
(setq fill-column (cdr assn
(add-hook 'git-commit-mode-hook 'set-git-commit-fill-column)
Paul
From 367a6c4d81cb60e075b26018f1d2a1669de0043f Mon Sep 17 00:00:00 2001
From: Paul Nelson
Date: Sun, 14 Apr 202
> I can't tell why Emacs sets `fill-column' to 64 in `log-edit-mode', but
> I'd like to follow this convention until Emacs changes it. So I'd be
> grateful if you could stick to 64 in your config as well.
Will do - I guess my point is then that if you want your own edits in
ChangeLog to behave
Hello,
This patch adds a hook TeX-fold-region-functions, called at the end of
TeX-fold-region.
The motivation is that this can be used to fold miscellaneous tex
stuff. For example, in https://github.com/ultronozm/czm-tex-fold.el,
I have used similar functionality, implemented via :after advice,
Hello,
As you know, one way to customize TeX-fold-mode is to supply functions
to the variables TeX-fold-*-spec-list, which are then called by
TeX-fold-hide-item. This patch introduces the convention that such
functions are called with point positioned at the beginning of the
item to be folded.
> @Paul: Do you have any other patches pending? I think you're also
> waiting for 14.0.5 in order to start the ELPA release of your packages,
> right?
>
> Best, Arash
Yes and yes. I have three further minor patches, one of which builds
on #70525, the other two of which are very minor. Could
I have more than one package in mind that could use the preview-region
preprocessor introduced in 49c9feb133e38a34d4eacbce248bc46e5c315715
(bug#70295). It seemed best to address this now with the attached
patch, so as to avoid later version mismatch issues.
Thanks, best,
Paul
> Great, bring 'em on :-)
I sent a couple just now. I have a couple more ready to go, but they
would likely produce conflicts unless the submitted patches are
accepted exactly as is, so I'll wait.
Thanks, best,
Paul
___
bug-auctex mailing list
This patch has no effect on existing behavior (in LaTeX-mode), but
makes it so that preview-region works in any non-LaTeX-mode buffer for
which TeX-master has been set to a valid tex file. This is intended
for internal use by other packages. For example, I've been using
something equivalent to
Hi Arash, see attached, and let me know if I missed anything. Thanks,
best, Paul
0001-Add-new-custom-option-TeX-fold-region-functions.patch
Description: Binary data
___
bug-auctex mailing list
bug-auctex@gnu.org
Yes, good for me. Thanks
>
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
(I checked that this bug predates my recent patches, including that
for bug#62445.)
Steps to reproduce: create test.tex with contents
--8<---cut here---start->8---
\documentclass{amsart}
\begin{document}
$\mathbf{U}(\mathbb{A}) \mathbf{A}(\mathbb{Q})
Sorry, my email client may have ruined the example by inserting
newlines. I attach a tex file for convenience.
example.tex
Description: Binary data
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
> Can you try the following command on terminal? Replace auctex-dir below with
> our auctex directory.
> patch -ruN -d auctex-dir < indirect2.patch
I'm trying this from the latest origin/master, but happy to try
something else if you think that'd be a good idea.
auctex % patch -ruN -d . <
> I'd like to have updates in the documentation. New customize option is
> probably overkilling.
>
> > (presumably by sending a patch on top of the current one, to this
> > thread?)
>
> Yes, please.
Please see attached. Thanks, best, Paul
0001-Adjust-docs.patch
Description: Binary data
> Sorry, I forgot to reply all in my previous email. The patch is attached here.
>
Sorry to turn this thread into "git tech support", but when I try
applying this patch using "magit-apply", I get the error:
128 git … am --3way --
/Users/au710211/.emacs.d/elpaca/repos/auctex/indirect2.patch
> A brief testing didn't show fatal behavior. Here are two notes I noticed:
> 1. In indirect buffer, preview-latex doesn't work. All preview images
>appear in the base buffer.
> 2. TeX Fold mode works independently in indirect and base buffers.
>
> I suppose there will be dissatisfied users
I think that a function as in the attached patch, which wraps the
function TeX--master-output-dir introduced along with TeX-output-dir,
would be a useful addition to the public-facing API. For example, I
would use it in both of the packages that I recently shared on the
devel list (these would
irect buffers when the master file does not appear in the
same folder as the current tex file, but that's also not quite what
you're encountering.
Paul
From c59e27287116c4873748868686e69b7edff06145 Mon Sep 17 00:00:00 2001
From: Paul Nelson
Date: Tue, 23 Apr 2024 15:53:52 +0200
Subject: [PATC
Hi Arash,
> Thanks. In this case, I think we can have a sort of API by patching the
> function `TeX-fold-auto-reveal-p' and declaring a standard var like this:
>
> --8<---cut here---start->8---
> (defvar-local TeX-fold-auto-reveal-external-commands nil
>
Hi Arash,
> --8<---cut here---start->8---
> (defun TeX-fold-auto-reveal-p (mode)
> "Decide whether to auto-reveal.
> Return non-nil if folded region should be auto-opened.
> See `TeX-fold-auto-reveal' for definitions of MODE."
> (cond ((symbolp mode)
>
This patch should not affect existing behavior, but introduces a
variable that would allow (e.g.) an external package to do so.
One way for an external package to terminate an ongoing preview
generation is via (TeX-kill-job). This approach is unreliable: if the
timing is just right, then the
> --8<---cut here---start->8---
> diff --git a/tex-fold.el b/tex-fold.el
> index 62f0834c..cb0f4592 100644
> --- a/tex-fold.el
> +++ b/tex-fold.el
> @@ -910,6 +910,11 @@ See `TeX-fold-auto-reveal' for definitions of MODE."
> Return non-nil if called by one of
(Sorry Arash, I noticed just now that I forgot to reply-all)
On Tue, Apr 30, 2024 at 12:55 PM Arash Esbati wrote:
>
> Paul Nelson writes:
>
> > I think essentially the same criticism applies. What if the user has
> > customized *-reveal to, say, '(eval (my-cool-function (
-up to this patch that I hoped to submit, and
then a bug-fix that I'll submit (after bug#70607 is closed, to avoid
merge conflicts), and then (fingers crossed) will lay off with the
patches for a bit.
Thanks again and best,
Paul
On Wed, May 1, 2024 at 3:58 PM Arash Esbati wrote:
>
> Paul
> So bug#70607 is the next to tackle?
[thumbs up emoji, in case it doesn't render]
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
This patch adds the commands #'undo and #'pop-to-mark-command to the
defaults for revealing folds and previews. I think there is no downside to
this, and clear benefit. (Indeed, in the years before I stumbled upon this
customization, I was often annoyed by the fact that previews didn't reveal
in
for "on input line X". This
patch generalizes that regular expression so that it matches such output.
Thanks, best,
Paul
From 83407c567891a213935c991e39a94d61ae17eeb8 Mon Sep 17 00:00:00 2001
From: Paul Nelson
Date: Sun, 5 May 2024 01:26:33 +0200
Subject: [PATCH] Generalize some error d
Somewhere between when I tried Vangelis's patch (earlier in this
thread) and when it was installed, it seems that a further change was
made to preview-region that breaks previews in indirect buffers.
Specifically, the substitution buffer-file-name ->
(TeX-buffer-file-name) was applied where it
Hi Arash, OK, thanks for your response, please feel free to close. Thanks,
best, Paul
On Sat, 4 May 2024 at 15:59, Arash Esbati wrote:
> Hi Paul,
>
> Paul Nelson writes:
>
> > This patch has no effect on existing behavior (in LaTeX-mode), but
> > makes it so that pre
in my own code) would allow me to do so.
Of course, if you have other suggestions, they'd be very welcome.
Thanks, best,
Paul
On Tue, May 7, 2024 at 8:43 AM Arash Esbati wrote:
> Hi Paul,
>
> Paul Nelson writes:
>
> > This patch introduces a dynamic variable that
>
>
> @Paul: Do you have any other patches pending? I think you're also
> waiting for 14.0.5 in order to start the ELPA release of your packages,
> right?
>
> Best, Arash
>
It looks like I've gone a solid week now without submitting any patches,
which suggests that things are now a "go" on my
Steps to reproduce:
Emacs -Q
M-: (package-initialize)
M-: (describe-package 'auctex)
These give an error with the following backtrace:
#+begin_src elisp
Debugger entered--Lisp error: (wrong-type-argument listp "
auctex-de...@gnu.org")
describe-package-1(auctex)
#f(compiled-function () #)()
Hi Arash,
> thanks for the patch. I have one question: You suggest we introduce a
> new custom option `TeX-fold-auto-reveal-commands' which will be used in
> another custom option `TeX-fold-auto-reveal' in the setter? Is the plan
> that users add functions provided by external packages to
>
This patch introduces a dynamic variable that allows suppression of the
messages "Type (...) to display results of compilation."
Thanks, best,
Paul
0001-Allow-compilation-messages-to-be-suppressed.patch
Description: Binary data
___
bug-auctex mailing
Hi Arash,
I'm not a Magit user, hence the question: Does Magit use a special mode
> for writing commit logs, like `log-edit-mode'? Maybe we can put that
> entry somewhere else in .dir-locals.el, next to
>
>
Unfortunately, it uses text-mode (and I don't know of any way to associate
.dir-locals
Ah, I see. OK, what you suggest sounds good, please feel free to close.
Thanks, best, Paul
On Sun, May 5, 2024 at 3:14 PM Arash Esbati wrote:
> Paul Nelson writes:
>
> > Unfortunately, it uses text-mode (and I don't know of any way to
> > associate .dir-locals entrie
This patch uses .dir-locals.el to set the magit commit summary maximum
length to 50.
Thanks, best,
Paul
0001-Set-magit-commit-summary-length-in-dir-locals.patch
Description: Binary data
___
bug-auctex mailing list
bug-auctex@gnu.org
Hi all,
It would be useful to be able to customize when TeX-fold-mode
auto-reveals. I attach a patch with my best attempt at this,
imitating what is done in preview.el.
Thanks, best,
Paul
0001-Add-defcustom-TeX-fold-auto-reveal-controlling-when-.patch
Description: Binary data
Hi Arash,
Yes, I have a copyright assignment for emacs and auctex as of Sept 18 2023.
Thanks, best,
Paul
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
Hi Arash,
I'll be happy to provide a patch for this.
Before doing so, let me clarify my motivation and ask for some advice.
I (and at least 6 others) have been using the package
https://github.com/ultronozm/czm-preview.el, which implements this fix
together with some other features. The
Hi Arash,
Yes, your suggestion sounds good. One other quick thought: maybe it'd
be bad design to have an external variable like this that can only
really be used by one package at a time? Would something like the
following be preferred?
(defvar preview-preprocess-functions nil
"List of
Hi Arash, see attached. Thanks, best, Paul
0001-Allow-preprocessing-of-previews.patch
Description: Binary data
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
Hello,
This patch allows preview.el to work in LaTeX-mode non-file buffers
for which TeX-master has been set to the name of a valid tex file.
This patch might appear to be adding a new feature, but if I
understand correctly, it's really fixing an ancient bug. From what I
can tell, preview.el
Hello,
The attached patch introduces an optional preprocessing step to preview-region.
As motivation, I've been using such functionality (implemented via
advice) in https://github.com/ultronozm/czm-preview.el to give correct
equation numbers in previews. This patch would allow me to excise the
Hi Ikumi,
Looks good to me!
Thanks, best,
Paul
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
Create a tex file with the following contents:
\newcommand{\ifs}{\text{if }}
\newcommand{\foo}{\text{foo}}
M-x mark-whole-buffer, M-x indent-region yields the following:
\newcommand{\ifs}{\text{if }}
\newcommand{\foo}{\text{foo}}
The issue is that LaTeX-indent-level-count returns 2 for the
It occurred to me that a better solution would be to constrain the
"if*" commands matched by the regexp produced by
LaTeX-indent-commands-regexp-make. My earlier patch fixed the
preamble definition, which was all that mattered for the specific tex
file that I was editing, but it is more natural
Hi Arash,
Thanks, that makes sense, and LaTeX-indent-begin-exceptions-list
indeed addresses the issue.
Paul
___
bug-auctex mailing list
bug-auctex@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-auctex
Hi Arash,
OK, very well. Please find attached my best attempt at a patch for
this (any feedback or corrections welcome).
Thanks, best,
Paul
From 9d3266304f62fa3b21751b27200aab17454add6c Mon Sep 17 00:00:00 2001
From: Paul Nelson
Date: Mon, 8 Apr 2024 13:11:52 +0200
Subject: [PATCH] fix bug
ny further feedback is welcome.
Thanks, best,
Paul
On Mon, Apr 8, 2024 at 2:44 PM Arash Esbati wrote:
>
> Hi Paul,
>
> Paul Nelson writes:
>
> > OK, very well. Please find attached my best attempt at a patch for
> > this (any feedback or corrections welcome).
>
Another workaround might be M-: (font-lock-set-defaults).
It seems that font-lock-set-defaults is typically not called in LaTeX-mode
initialization (see the final comment in font-latex-setup, addressing
bug#65912), but instead via global-font-lock-mode, which I guess you've
disabled.
Paul
> Functionally, version 14.0.5 has at least one shortcoming that makes it
> unusable for me: invoking org-edit-special from an org-mode latex src block
> opens a buffer in latex-mode (not LaTeX-mode). This is a change from
> version 13.3.
In case it's of any help, I've been using (add-hook
86 matches
Mail list logo
