Re: gcc -Wall warning for minmax.h

2005-06-10 Thread Derek Price
Stepan Kasal wrote: After that fix, we could also remove the AS_LITERAL_IF with m4_fatal. I'm not sure what you were referring to here so I've attached a patch to document AS_LITERAL_IF as you requested a few days ago. I will commit it in a few days if there are no objections. It looks

Re: gcc -Wall warning for minmax.h

2005-06-10 Thread Derek Price
Paul Eggert wrote: I'm not sure about the documentation change. It's not yet clear to me that we want to document AS_LITERAL_IF (the above example being one of the gotchas). If we do want to document it we probably need to be more systematic about it and its friends. So I left that alone for

Re: gcc -Wall warning for minmax.h

2005-06-10 Thread Paul Eggert
Derek Price [EMAIL PROTECTED] writes: + [test ${$1+set} = set], + [{ as_var=$1; eval test \\${$as_var+set}\ = set; }])]) That change looks like it can do only good, so I installed it into Autoconf. Thanks. I'm not sure about the documentation change. It's not yet clear to me that we

Re: [bug-gnulib] Handling of invalid multibyte character sequences in fnmatch()

2005-06-10 Thread Paul Eggert
James Youngman [EMAIL PROTECTED] writes: I was testing on a Glibc system, and so wasn't picking up the gnulib version of fnmatch(). Silly me. Won't other people have the same problem? Can you modify m4/fnmatch.m4 to detect the problem, and if so then use the gnulib version instead of the