Hi Simon,
inet_ntop already uses LGPLv2+, but inet_pton uses LGPL.
May I change the latter to LGPLv2+? It's glibc-derived, after all.
Motivation: I would like to use it from libvirt,
which is limited to LGPLv2+.
Jim Meyering [EMAIL PROTECTED] writes:
Hi Simon,
inet_ntop already uses LGPLv2+, but inet_pton uses LGPL.
May I change the latter to LGPLv2+? It's glibc-derived, after all.
Motivation: I would like to use it from libvirt,
which is limited to LGPLv2+.
Hi Jim! That's fine with me, please
Simon Josefsson [EMAIL PROTECTED] wrote:
Jim Meyering [EMAIL PROTECTED] writes:
inet_ntop already uses LGPLv2+, but inet_pton uses LGPL.
May I change the latter to LGPLv2+? It's glibc-derived, after all.
...
Hi Jim! That's fine with me, please go ahead.
Done. Thanks!
I actually noticed these in a profile!
1) sysconf (_SC_OPEN_MAX) is slow, it's better to cache it.
2) division by 1000 is slow, and in my code the timeout was always 0.
3) access to thread-local errno is slow, it's also better to cache it.
Ciao,
Paolo
2008-08-06 Paolo Bonzini [EMAIL
Hi Simon,
I'd like to make this change, so that inet_pton's parsing is
locale-independent. No real risk of problem, but this change does get me
past a failure of a relatively strict make syntax-check test in libvirt.
And besides, we certainly don't need locale-related conversions to map
A-F to
Jim Meyering [EMAIL PROTECTED] writes:
Hi Simon,
I'd like to make this change, so that inet_pton's parsing is
locale-independent. No real risk of problem, but this change does get me
past a failure of a relatively strict make syntax-check test in libvirt.
And besides, we certainly don't
Hi Paolo,
* Paolo Bonzini wrote on Wed, Aug 06, 2008 at 10:28:00AM CEST:
--- a/lib/poll.c
+++ b/lib/poll.c
#ifdef _SC_OPEN_MAX
- if (nfd sysconf (_SC_OPEN_MAX))
+ static int sc_open_max = -1;
+
+ if (nfd 0
+ || (nfd sc_open_max
+ (sc_open_max != -1
+ ||
Simon Josefsson [EMAIL PROTECTED] wrote:
Hi! Looks fine to me. It would be a diversion from upstream glibc, but
I don't care strongly.
Thanks. Pushed.
#ifdef _SC_OPEN_MAX
- if (nfd sysconf (_SC_OPEN_MAX))
+ static int sc_open_max = -1;
+
+ if (nfd 0
+ || (nfd sc_open_max
+ (sc_open_max != -1
+ || nfd (sc_open_max = sysconf (_SC_OPEN_MAX)
Doesn't this make poll non-reentrant?
Are there systems where
Paolo Bonzini wrote:
I actually noticed these in a profile!
What tool do you use for doing profiling on a per-line or per-instruction
basis? The Google profiler?
3) access to thread-local errno is slow, it's also better to cache it.
Pheww! That is micro-optimization indeed.
Do you have an
3) access to thread-local errno is slow, it's also better to cache it.
Pheww! That is micro-optimization indeed.
Well, thread-local errno might involve a function call on some systems.
If the function call is not CSE'd by the compiler, it means half a
dozen function calls.
Do you have
Coverity reported some bugs in man-db which are in fact gnulib bugs. I'd
like to clear these up. This is the most obvious installment, mainly
representing real bugs; I still need to investigate several items which
are essentially false positives and see if it's worth adjusting code to
avoid
In man-db's apropos program, I use the following doc string:
static const char apropos_doc[] = \v N_(The --regex option is enabled by
default.);
The argp documentation says nothing to suggest that I can't leave the
part of argp-doc before \v empty, to provide only extra text to be
printed
inet_ntop already uses LGPLv2+, but inet_pton uses LGPL.
Just to mention it since the subject came up -- as far as I know, no GNU
software should be L(GPL)vanything-only, but always or later.
If anyone here ever sees any, please let me know, it's something that
should be followed up on.
I am looking for the binary of gnulib-tool for HP-UX 11.11
I tried downloading the sources using git. Three times this has happened
$ git clone git://git.savannah.gnu.org/gnulib.git
Initialized empty Git repository in /home/mtayler/git/gnulib/.git/
remote: Counting objects: 62559, done.
remote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Tayler, Mark [ITSUS] on 8/6/2008 1:49 PM:
| I am looking for the binary of gnulib-tool for HP-UX 11.11
gnulib-tool is actually a script, not a binary.
| Receiving objects: 100% (62559/62559), 11.17 MiB | 1450 KiB/s, done.
| fatal:
16 matches
Mail list logo