Re: [PATCH] posixtm: don't reject a time with 60 as the number of seconds

2009-09-16 Thread Jim Meyering
Paolo Bonzini wrote: Going backwards from cal 1 1 you can see that in the Julian calendar 01-Jan- was a Thursday, but that's not so relevant. However cal can help seeing that 01-Jan- is a Saturday in Gregorian proleptic calendar (i.e. extending Gregorian calendar before the day when

Re: canonicalize-lgpl bug

2009-09-16 Thread Jim Meyering
Eric Blake wrote: Jim Meyering jim at meyering.net writes: Eric Blake (6): canonicalize-lgpl: reject non-directory with trailing slash stdlib: sort witness names canonicalize: leave canonicalize_file_name to canonicalize-lgpl canonicalize-lgpl: use native

Re: [PATCH] posixtm: don't reject a time with 60 as the number of seconds

2009-09-16 Thread Jim Meyering
Jim Meyering wrote: Paolo Bonzini wrote: Going backwards from cal 1 1 you can see that in the Julian calendar 01-Jan- was a Thursday, but that's not so relevant. However cal can help seeing that 01-Jan- is a Saturday in Gregorian proleptic calendar (i.e. extending Gregorian calendar

Re: canonicalize-lgpl bug

2009-09-16 Thread Eric Blake
Jim Meyering jim at meyering.net writes: [3/11] canonicalize: don't lose errno glibc still has a bug in realpath/c_f_n where errno could be inadvertently changed by a call to free() during an error return, but canonicalize-lgpl was immune, and now canonicalize is fixed. I guess

Re: [PATCH] posixtm: don't reject a time with 60 as the number of seconds

2009-09-16 Thread Paolo Bonzini
{ 12131415.16, 13, 1039788916 Fri Dec 13 14:15:16 2002 }, { 12131415.16, 13, 1039788916 Fri Dec 13 14:15:16 2002 }, Uhm, why 2002? You could pre-generate all possible outputs from 2009 to 2038 and only one of them will be checked. Paolo

Re: [PATCH] posixtm: don't reject a time with 60 as the number of seconds

2009-09-16 Thread Jim Meyering
Paolo Bonzini wrote: { 12131415.16, 13, 1039788916 Fri Dec 13 14:15:16 2002 }, { 12131415.16, 13, 1039788916 Fri Dec 13 14:15:16 2002 }, Uhm, why 2002? You could pre-generate all possible outputs from 2009 to 2038 and only one of them will be checked. Good idea.

Re: mingw remove bug

2009-09-16 Thread Eric Blake
Eric Blake ebb9 at byu.net writes: I'm arguing that the second program should also report No such file or directory. Ah, so for 'foo/', the code should distinguish between ENOENT and ENOTDIR, based on whether 'foo' exists. I'll update the patch and test accordingly. I'm taking a step

Re: Daily snapshot fails to build with external gettext

2009-09-16 Thread Ralf Wildenhues
* Eric Blake wrote on Wed, Sep 16, 2009 at 07:53:21PM CEST: Tom G. Christensen writes: Undefined first referenced symbol in file libintl_gettext ../gllib/libgnu.a(xalloc-die.o) But thinking about it more, since every

Re: mingw remove bug

2009-09-16 Thread Jim Meyering
Eric Blake wrote: Eric Blake ebb9 at byu.net writes: I'm arguing that the second program should also report No such file or directory. Ah, so for 'foo/', the code should distinguish between ENOENT and ENOTDIR, based on whether 'foo' exists. I'll update the patch and test accordingly.

Re: [PATCH] posixtm: don't reject a time with 60 as the number of seconds

2009-09-16 Thread Jim Meyering
Eric Blake wrote: Jim Meyering jim at meyering.net writes: FYI, here's the new test, in case anyone feels like reviewing: +static struct posixtm_test T[] = + { +{ 12131415.16, 13, 1039788916 Fri Dec 13 14:15:16 2002 }, +{ 12131415.16, 13, 1039788916 Fri Dec 13 14:15:16

Re: mingw remove bug

2009-09-16 Thread Eric Blake
Jim Meyering jim at meyering.net writes: Meanwhile, the rmdir-errno module, in use by coreutils until today, guessed wrong for cross-compilation to Solaris (where rmdir fails with EEXIST, not ENOTEMPTY, on a populated directory); now that coreutils no longer uses the module [1], I see no

improve unlink on Solaris

2009-09-16 Thread Eric Blake
I'm working on a patch to fix unlink(file/) on Solaris 9. But as a prerequisite (to avoid anyone corrupting their file system if running the unit test as root, and accidentally unlinking an empty directory), I noticed that mingw failed to compile unlinkdir.c due to a missing geteuid. This

Re: canonicalize-lgpl bug

2009-09-16 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/16/2009 9:11 AM: I've reached this point in reading the patches. So far they look fine. I will read the remainder, and test tomorrow. I'll try and rebase my series before then. Now rebased: git pull

time_t on NetBSD/i386

2009-09-16 Thread Hasso Tepper
time_t is 64 bits in recent NetBSD versions even on i386 platform, therefore these assertations fail on it: in lib/mktime.c: verify (long_int_year_and_yday_are_wide_enough, INT_MAX = LONG_MAX / 2 || TIME_T_MAX = UINT_MAX); in lib/getdate.y: verify (LONG_MIN = TYPE_MINIMUM (time_t)