Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

2009-09-19 Thread Simon Josefsson
emad hajjar alep...@hotmail.com writes: ./gnulib-tool: *** file /root/gnulib/./m4/canonicalize-lgpl.m4 not found ./gnulib-tool: *** Stop. Indeed, the file does not exist but is referenced from relocatable-prog-wrapper: Files: ... m4/canonicalize-lgpl.m4 Bruno, Ben, is this patch the right

Re: readlink(1) behavior

2009-09-19 Thread Jim Meyering
Jim Meyering wrote: Eric Blake wrote: According to Jim Meyering on 9/18/2009 4:47 AM: Assuming ln -s /nowhere dangling-symlink, New behavior: $ ./readlink -fv dangling-symlink/ /nowhere Previous: $ readlink -fv dangling-symlink/ readlink: dangling-symlink/: No such file

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Simon Josefsson on 9/19/2009 2:41 AM: Files: ... m4/canonicalize-lgpl.m4 Bruno, Ben, is this patch the right thing? I'm neither, but yes, the patch is right. Sorry for not realizing I broke that when I merged the m4 file of

Re: build failure on HP-UX 11.11

2009-09-19 Thread Bruno Haible
Greg Wooledge wrote: The gcc bootstrap finally finished. The failure I reported does not occur with gcc 3.4.6 (+ GNU as) built from source on the same target machine. Whether this indicates a problem with the binary gcc build I was using (specifically, its generated header files), or a

Re: build failure on HP-UX 11.11

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 9/19/2009 7:16 AM: I agree with you that it was a problem with that particular gcc, because - the build works fine with the CC=cc -Ae -D_XOPEN_SOURCE=500 setting mentioned in the INSTALL file, - as you found

Re: readlink(1) behavior

2009-09-19 Thread Dmitry V. Levin
On Fri, Sep 18, 2009 at 02:27:32PM +0200, Jim Meyering wrote: Eric Blake wrote: According to Jim Meyering on 9/18/2009 4:47 AM: Assuming ln -s /nowhere dangling-symlink, New behavior: $ ./readlink -fv dangling-symlink/ /nowhere Previous: $ readlink -fv

Re: need opendir_safer, dirent--.h

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/2/2009 1:00 PM: And here's openat-safer, plus a rework of making fts safer. Subject: [PATCH 2/2] backupfile, chdir-long, fts, savedir: make safer * lib/backupfile.c (includes): Use dirent--.h, since numbered_backup

Re: build failure on HP-UX 11.11

2009-09-19 Thread Bruno Haible
Eric Blake wrote: Can/should we work around this gcc bug, by ensuring that stdarg.h is always included prior to wchar.h in all configure tests? I think it goes too far to attempt to work around bugs of every possible gcc version on every possible platform. - The number of users of that

Re: need opendir_safer, dirent--.h

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/19/2009 8:17 AM: I've tested that, with this patch, './gnulib-tool --with-tests --test openat' no longer drags in fcntl-safer, but './gnulib-tool --with-tests --test openat-safer' still passes the new test-openat.

Re: [PATCH] posixtm: don't reject a time with 60 as the number of seconds

2009-09-19 Thread Jim Meyering
Jim Meyering wrote: Paolo Bonzini wrote: { 12131415.16, 13, 1039788916 Fri Dec 13 14:15:16 2002 }, { 12131415.16, 13, 1039788916 Fri Dec 13 14:15:16 2002 }, Uhm, why 2002? You could pre-generate all possible outputs from 2009 to 2038 and only one of them will be

Re: [PATCH] posixtm: don't reject a time with 60 as the number of seconds

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/19/2009 10:46 AM: +++ b/tests/test-posixtm.c @@ -0,0 +1,175 @@ +/* Test that openat_safer leave standard fds alone. Really? This line is a bit too much copy-n-paste ;) - -- Don't work too hard, make some time for

Re: [PATCH] posixtm: don't reject a time with 60 as the number of seconds

2009-09-19 Thread Jim Meyering
Eric Blake wrote: According to Jim Meyering on 9/19/2009 10:46 AM: +++ b/tests/test-posixtm.c @@ -0,0 +1,175 @@ +/* Test that openat_safer leave standard fds alone. Really? This line is a bit too much copy-n-paste ;) Hah! Thanks. This works better: From

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/19/2009 5:16 AM: According to Simon Josefsson on 9/19/2009 2:41 AM: Files: ... m4/canonicalize-lgpl.m4 Bruno, Ben, is this patch the right thing? I'm neither, but yes, the patch is right. Sorry for not realizing

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

2009-09-19 Thread Jim Meyering
Eric Blake wrote: ... Also, we need this, to pick up the change in .h file: ... Subject: [PATCH] canonicalize-lgpl: adjust clients to use correct header ... * lib/fchdir.c (includes): Use stdlib.h, not canonicalize.h. Looks good. Along that line, I've added this: From

wrong license notice in error module

2009-09-19 Thread holzplatten
Hello, I have found out that both lib/error.h and lib/error.c contain the GPL license notice, however, module's description and documentation point out that error module is licensed under LGPL. Regards, Pedro

Re: wrong license notice in error module

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to holzplat...@es.gnu.org on 9/19/2009 2:04 PM: Hello, I have found out that both lib/error.h and lib/error.c contain the GPL license notice, however, module's description and documentation point out that error module is licensed under

Re: wrong license notice in error module

2009-09-19 Thread Pedro J. Ruiz Lopez
Eric Blake wrote: Not a bug. Please read http://www.gnu.org/software/gnulib/manual/gnulib.html#Copyright. The module is kept as GPL in the repository to minimize churn in GPL clients, but can legally be downgraded to LGPL by using gnulib-tool into your LGPL project. Next time I will spend

link (was: mkfifoat, renameat)

2009-09-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/9/2009 5:31 PM: Meanwhile, I noticed that the link module has a bug on mingw, where link (a,b/.) created the regular file b rather than failing with ENOENT (I noticed it because cygwin 1.5 had the same bug, and I

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

2009-09-19 Thread Bruno Haible
Eric Blake wrote: --- a/lib/progreloc.c +++ b/lib/progreloc.c @@ -43,7 +43,6 @@ # include windows.h #endif -#include canonicalize.h #include relocatable.h #ifdef NO_XMALLOC If you do this, the canonicalize_file_name declaration may be absent when progreloc.c is compiled, leading