ignore-value vs off_t

2011-01-30 Thread Simon Josefsson
/test-ignore-value.c:54: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘doOff’ make[4]: *** [test-ignore-value.o] Fel 1 From 13f769497814bf636c5d2a98f1b17cbf0d088be9 Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Sun, 30 Jan 2011 09:28:59 +0100 Subject

Re: Document reasonable portability targets

2011-01-30 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: * Simon Josefsson wrote on Sat, Jan 29, 2011 at 10:39:34PM CET: Btw, there is nothing about Cray UNICOS in your text but there is Cray platform specific stuff in the gnulib code. Does anyone know about status of Cray architectures? FWIW, I

Re: Document reasonable portability targets

2011-01-30 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: I can't find any recent information about UNICOS at cray.com so I suspect it disappeared off the radar some time ago. We could consider removing some old cruft in gnulib if that is the case. That would make sense, if gnulib aggressively wants

Re: syncing Emacs from sources maintained elsewhere

2011-01-29 Thread Simon Josefsson
Eli Zaretskii e...@gnu.org writes: Date: Fri, 28 Jan 2011 15:40:08 -0700 From: Eric Blake ebl...@redhat.com CC: Paul Eggert egg...@cs.ucla.edu, bug-gnulib@gnu.org, br...@clisp.org, emacs-de...@gnu.org Can you assume that emacs will always be built with gcc on Windows, or are there

Re: rename, same-inode, unlink LGPL - LGPLv2+?

2011-01-29 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org writes: Hi! I'm using rename/unlink (the former depends on same-inode) in a LGPLv2+ library and noticed they are marked as 'LGPL' in gnulib. According to comments in files or git logs you have written parts of these files. Would you consider relicensing

recommend strdup or strdup-posix?

2011-01-29 Thread Simon Josefsson
I was using strdup and it triggered this warning in gnulib: _GL_WARN_ON_USE (strdup, strdup is unportable - use gnulib module strdup for portability); However the strdup module is deprecated according to modules/strdup: This module is obsolete. But you may want to use

Re: Document reasonable portability targets

2011-01-29 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi, The same question was asked several times over the last few months: [1][2][3]. Some people think that dropping SunOS 4 support was aggressive, others think that gnulib should drop Cygwin 1.5.x support less than one year after Cygwin 1.7.x was

rename, same-inode, unlink LGPL - LGPLv2+?

2011-01-28 Thread Simon Josefsson
Hi! I'm using rename/unlink (the former depends on same-inode) in a LGPLv2+ library and noticed they are marked as 'LGPL' in gnulib. According to comments in files or git logs you have written parts of these files. Would you consider relicensing these under the LGPLv2+? The files same-inode.h

Re: rename, same-inode, unlink LGPL - LGPLv2+?

2011-01-28 Thread Simon Josefsson
Jim Meyering j...@meyering.net writes: Simon Josefsson wrote: Hi! I'm using rename/unlink (the former depends on same-inode) in a LGPLv2+ library and noticed they are marked as 'LGPL' in gnulib. According to comments in files or git logs you have written parts of these files. Would you

Re: Files from gnulib

2011-01-27 Thread Simon Josefsson
Andy Moreton andrewjmore...@gmail.com writes: On Wed 26 Jan 2011, Bastien ROUCARIES wrote: Therefore since 2001 (creation of doslfn), 8.3 name problem should not exist. Instead of tackling the main problem lack of 8.3 support and use the new api, you are stick in the 90's. It seems odd

sc_error_message_uppercase

2011-01-27 Thread Simon Josefsson
I got this from 'make syntax-check' in a project: oathtool/oathtool.c-225- printf (Step size (seconds): %ld\n, time_step_size); oathtool/oathtool.c-235- printf (Time now: %s (%ld)\n, outstr, when); maint.mk: found capitalized error message make: *** [sc_error_message_uppercase]

Re: capitalization of error messages and option descriptions

2011-01-27 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: # Error messages should not start with a capital letter Why should error messages not start with a capital letter? I don't know. I prefer if they are normal human language sentences which typically start with a capital and ends with a dot. However in

Re: uninorm/nfc - Unicode version?

2011-01-18 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Btw, I'm (finally) working on a IDNA2008 implementation, and it is using your libunistring. How will this work with the glibc add-on? Will it incorporate some parts of libunistring literally, or will it load libunistring dynamically? I recalled another

Re: Should gnulib lib_SOURCES contain .h files? also, splitting up ftoastr

2011-01-11 Thread Simon Josefsson
Paul Eggert egg...@cs.ucla.edu writes: While looking into this I noticed that ftoastr, like some but not all other modules, puts a .h file into lib_SOURCES: lib_SOURCES += ftoastr.h ftoastr.c dtoastr.c ldtoastr.c Now I naively had thought that lib_SOURCES was just for .c files that produce

Re: uninorm/nfc - Unicode version?

2011-01-09 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, There is no hurry, I'm mostly curious about what kind of non-trivial changes there would be. I know that between 5.2 and 6.0 there were some changes made that would affect a IDNA2008 implementation for example. The best would be if the

Re: uninorm/nfc - Unicode version?

2011-01-05 Thread Simon Josefsson
Ben Pfaff b...@cs.stanford.edu writes: Simon Josefsson si...@josefsson.org writes: The best would be if the process to re-generate the files were documented, then I could generate them on the fly to test my code with a 5.1, 5.2 and 6.0 Unicode library, which would be useful

Re: uninorm/nfc - Unicode version?

2011-01-05 Thread Simon Josefsson
Ben Pfaff b...@cs.stanford.edu writes: Simon Josefsson si...@josefsson.org writes: The best would be if the process to re-generate the files were documented, then I could generate them on the fly to test my code with a 5.1, 5.2 and 6.0 Unicode library, which would be useful

uninorm/nfc - Unicode version?

2011-01-04 Thread Simon Josefsson
The Unicode NFC stuff seems to be based on Unicode 5.1.0 tables -- would it be possible to upgrade it to 5.2.0 or better 6.0.0? lib/uninorm/composition-table.gperf says: /* DO NOT EDIT! GENERATED AUTOMATICALLY! */ /* Canonical composition of Unicode characters. */ /* Generated automatically by

Re: uninorm/nfc - Unicode version?

2011-01-04 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, The Unicode NFC stuff seems to be based on Unicode 5.1.0 tables -- would it be possible to upgrade it to 5.2.0 or better 6.0.0? I'm usually a bit lazy about these upgrades, because these days, the changes between Unicode versions are not

Re: update-copyright for non-FSF copyright notices?

2011-01-03 Thread Simon Josefsson
Jim Meyering j...@meyering.net writes: Jim Meyering wrote: Simon Josefsson wrote: Bruce Korb bk...@gnu.org writes: On 01/02/11 11:02, Simon Josefsson wrote: Jim Meyering j...@meyering.net writes: Simon Josefsson wrote: How about this patch? Not all projects are copyright'ed by the FSF

update-copyright for non-FSF copyright notices?

2011-01-02 Thread Simon Josefsson
--- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-01-02 Simon Josefsson si...@josefsson.org + + * build-aux/update-copyright: Support UPDATE_COPYRIGHT_HOLDER + environment variable. + 2011-01-01 Ben Pfaff b...@cs.stanford.edu Rename uc_is_grapheme_cluster_break

git-version-gen

2011-01-02 Thread Simon Josefsson
Probably a silly question, but when I use this script to produce intra-version numbers, how do I make it produce non-intra-version numbers? For example when I like to do a release? /Simon

Re: update-copyright for non-FSF copyright notices?

2011-01-02 Thread Simon Josefsson
Jim Meyering j...@meyering.net writes: Simon Josefsson wrote: How about this patch? Not all projects are copyright'ed by the FSF. The patch makes it possible to override the otherwise hard-coded string, thought cfg.mk and without modifying the update-copyright script iself. I like it. One

Re: update-copyright for non-FSF copyright notices?

2011-01-02 Thread Simon Josefsson
Bruce Korb bk...@gnu.org writes: On 01/02/11 11:02, Simon Josefsson wrote: Jim Meyering j...@meyering.net writes: Simon Josefsson wrote: How about this patch? Not all projects are copyright'ed by the FSF. The patch makes it possible to override the otherwise hard-coded string, thought

Re: times test warnings

2010-12-27 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: This patch fixes it. OK to push? Yes, please do. Thanks, /Simon

Re: [PATCH] doc: document Solaris printf bug with large float precisions

2010-12-24 Thread Simon Josefsson
Paul Eggert egg...@cs.ucla.edu writes: Here's a simpler test case that illustrates the Solaris bug, in case there's anybody here who can get bug fixes into Solaris: #include stdio.h int main (void) { char buf[1000]; int n = snprintf (buf, sizeof buf, %.511f, 1.0); printf (%d

Re: signature warnings on OSF/1 5.1

2010-12-20 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: * test-gethostname.c:24: warning: initialization from incompatible pointer type Similarly: - POSIX: int gethostname(char *, size_t); - OSF/1: int gethostname(char *, int); Likewise. * test-inet_ntop.c:24: warning: initialization from incompatible

Re: gold speed for small programs

2010-12-13 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: Trying out gold (no LTO) on GCC's cc1, a log shows that the single biggest part (20%) of user time for such a medium sized program may be spent in SHA1 computation for the build id. I think the SHA1 code in libiberty would benefit from an SSE

Re: getpass: get system declaration

2010-11-28 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: On Solaris at least, getpass() is not declared in unistd.h or stdlib.h if __EXTENSIONS__ is not defined. This fixes the autoconf test and the use of unistd.h in lib/getpass.h. By the way, on all systems (including glibc), getpass() is declared by

Re: sys_socket: ensure ss_family

2010-11-28 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, On AIX 5.1, I'm seeing this compilation failure: gcc -D_ALL_SOURCE -DHAVE_CONFIG_H -I. -DGNULIB_STRICT_CHECKING=1 -I. -I. -I.. -I./.. -I../gllib -I./../gllib-g -O2 -MT test-sys_socket.o -MD -MP -MF .deps/test-sys_socket.Tpo -c -o

Re: getdomainname: fix several problems

2010-11-28 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Tested with a unit test on glibc, MacOS X 10.5, AIX 5.1, OSF/1 5.1, Solaris 10, mingw. OK to commit? Thank you! Seems fine to me. Paul Eggert egg...@cs.ucla.edu writes: On 11/28/2010 08:56 AM, Bruno Haible wrote: So what the gnulib replacement was

Re: symbols x platforms matrix

2010-11-24 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: I don't have the 10.5 machine available any more. I have a MacOS X 10.5 machine myself, so I've now also taken the data from there. The updated matrix is at http://www.haible.de/bruno/gnu/various-symlists.tar.gz I'm applying the doc fix below.

Re: symbols x platforms matrix

2010-11-23 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: * macosx-10.5: New directory. Raw data from Simon Josefsson. Hi Bruno -- the ZIP I sent was for 10.4.11 (PPC), the filename was confused. I just checked the zip file against the 10.4 machine again (with all updates), and they were identical. I don't

unistd.h: daemon

2010-11-21 Thread Simon Josefsson
Glibc has a 'daemon' function, which is from BSD, however it is not documented in the glibc manual [1] and it is not in POSIX. Mike noticed that InetUtils is using it: http://thread.gmane.org/gmane.comp.gnu.inetutils.bugs/3040/focus=3041 This begs the question of whether using the 'daemon'

Re: [PATCH] suggestion enhancement valgrind_tests.m4

2010-11-16 Thread Simon Josefsson
Bernd Becker becker.be...@gmx.net writes: Hi, I tried this a few weeks ago, but didn't get a response, yet. So maybe this time I have more luck Sorry for slow response! Thanks for working on this. If you want the patch to go into gnulib, you need to sign over the copyright to the FSF. Have

syntax-check warns on parse-datetime.texi

2010-11-16 Thread Simon Josefsson
Is this something we want to fix? /Simon doc/parse-datetime.texi:459:@cindex beginning of time, for @acronym{POSIX} doc/parse-datetime.texi:460:@cindex epoch, for @acronym{POSIX} doc/parse-datetime.texi:462:an epoch---a well-defined point of time. On @acronym{GNU} and

Re: [PATCH] pmccabe2html: bug fixes: don't skip last input line; quote filename in shell command

2010-11-11 Thread Simon Josefsson
torsten.sch...@leica-microsystems.com writes: * build-aux/pmccabe2html: Fixed a off-by-one error, so last input line is also considered for output. Quoted function name in shell command, so temporary files for functions like MyClass::operator() are removed correctly without errors.

Re: MD5 module license

2010-11-07 Thread Simon Josefsson
Sylvain Beucler b...@beuc.net writes: Hi, The license of the MD5 module is documented as LGPLv2+, but the source headers say it's under the GPLv2+, and that it's part of the (LGPL) libc. What is the actual license? :) The gnulib modules file is the canonical place, which says LGPLv2+.

Re: pmccabe cyclomatic complexity type inconsistency

2010-09-30 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: I've just been puzzling over why the colouring and sorting sometimes appeared to be wrong, and discovered that this is because the output of pmccabe is sorted on its first column, modified cyclomatic complexity, but the figures actually reported by

Re: NULL environ?

2010-09-30 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Thanks for having reported it already [1]. Let's see how they handle it. They solved it quickly, and I have verified that it works. I'm going to do a gnulib build using latest GCC 4.5.1 mingw-w64 and latest wine to see how well it compares against a build

NULL environ?

2010-09-27 Thread Simon Josefsson
Does POSIX permit a NULL 'environ' variable? I'd say no given what http://www.opengroup.org/onlinepubs/9699919799/functions/environ.html has to say: In addition, the following variable: extern char **environ; is initialized as a pointer to an array of character pointers to the

stdlib self test: error: 'SIGTERM' undeclared

2010-09-26 Thread Simon Josefsson
This command: gnulib-tool --create-testdir --dir m --with-tests stdlib; cd m ; ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu ; make results in: test-stdlib.c: In function ‘main’: test-stdlib.c:63: error: ‘SIGTERM’ undeclared (first use in this function) test-stdlib.c:63: error:

Re: pmcabe2html example rule question

2010-09-26 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: Given the example rule, the cyclo-${PACKAGE}.html file must be deleted in order to be remade, as the rule's target is itself cyclo-${PACKAGE}.html, with no dependencies. It would be more useful if either the rule depended on the sources (best), or if the

Re: Mentions of GSS in gnulib.texi

2010-09-26 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: On 21 September 2010 21:51, Simon Josefsson si...@josefsson.org wrote: Thanks, applied. I didn't see a patch for ChangeLog in there though? I added it myself and pushed it separately. I used git format-patch, which seemed to put my ChangeLog entry

Re: stdlib self test: error: 'SIGTERM' undeclared

2010-09-26 Thread Simon Josefsson
Thanks for installing that. I should have tested more, there is another problem too: /home/jas/src/gnulib/m/gltests/test-sys_wait.h:41: undefined reference to `_WSTOPSIG' We _could_ do this: -/* The signal that terminated a process is not known posthum. */ +/* The signal that

Re: author names in .c files

2010-09-26 Thread Simon Josefsson
Jim Meyering j...@meyering.net writes: Eric Blake wrote: Ralf just pointed this out to me: http://producingoss.com/en/producingoss.html#territoriality For an example of something that looks like territoriality, notice how many tests/test-*.c files are attached to my name: $ git grep 'Eric

Re: stdlib self test: error: 'SIGTERM' undeclared

2010-09-26 Thread Simon Josefsson
. Reported by Simon Josefsson. Excellent, thank you. It works fine here. /Simon

[PATCH] getaddrinfo: Initialize sockets, to make it work under Windows.

2010-09-25 Thread Simon Josefsson
/getaddrinfo |1 + tests/test-getaddrinfo.c | 19 --- 5 files changed, 15 insertions(+), 20 deletions(-) diff --git a/ChangeLog b/ChangeLog index e4692b7..cfcf9a9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2010-09-25 Simon Josefsson si...@josefsson.org

Re: On OpenBSD and if_freenameindex(3).

2010-09-25 Thread Simon Josefsson
Eric Blake ebl...@redhat.com writes: It turns out that MirBSD has the same bug regarding if_freenameindex not being a function. So I've gone ahead and documented that; we can update the documentation when we implement the net_if (replacement header) and if_freenameindex (function

Re: On OpenBSD and if_freenameindex(3).

2010-09-21 Thread Simon Josefsson
that works on various systems. Perhaps OpenBSD isn't the only system not working here. /Simon From 3f130a97c39ecb2c388fa34f4123a33c27c66213 Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Tue, 21 Sep 2010 14:19:58 +0200 Subject: [PATCH] New module to test net/if.h interfaces

Re: Another minor patch to pmccabe2html

2010-09-21 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: Attached, to make the whitespace in the Makefile.am example more copy-and-paste friendly. Applied, thanks. By the way, is there some reason to keep this file and pmccabe.css in gnulib rather than push it upstream to pmccabe, and make the gnulib module

Re: A fix for pmccabe2html

2010-09-21 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: On 20 September 2010 15:49, Eric Blake ebl...@redhat.com wrote: Rather than describing the fix, could you post this as a patch? Sorry; you've made me realise that my habit of not posting patches for code I'm not sure about is silly for several reasons.

Re: Mentions of GSS in gnulib.texi

2010-09-21 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: Are the mentions of GSS in the section Out of memory handling bogus cut-and-paste-o's or similar? A bit of googling suggests that the text has indeed been cut and pasted from the GNU GSS manual. It seems that this section is essentially meant to document

Re: pmccabe2html: more nits; build-aux confusion

2010-09-21 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: 1. The example Makefile.am code has lib/ rather than src/ in the path to the source code, even though it's clearly the package source that is to be analysed, not the gnulib library code. This is because it is an example, and the projects I used it for had

Re: On OpenBSD and if_freenameindex(3).

2010-09-21 Thread Simon Josefsson
Mats Erik Andersson mats.anders...@gisladisker.se writes: tisdag den 21 september 2010 klockan 14:22 skrev Simon Josefsson detta: As an initial response to this problem, I'm installing a self check of the net/if.h interface. See below. Mats, if you could quote the compiler errors you get

Re: pmccabe2html: more nits; build-aux confusion

2010-09-21 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: On 21 September 2010 13:38, Simon Josefsson si...@josefsson.org wrote: Reuben Thomas r...@sc3d.org writes: 1. The example Makefile.am code has lib/ rather than src/ in the path to the source code, even though it's clearly the package source

Re: Another minor patch to pmccabe2html

2010-09-21 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: On 21 September 2010 13:28, Simon Josefsson si...@josefsson.org wrote: Reuben Thomas r...@sc3d.org writes: By the way, is there some reason to keep this file and pmccabe.css in gnulib rather than push it upstream to pmccabe, and make the gnulib module just

Re: Mentions of GSS in gnulib.texi

2010-09-21 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: On 21 September 2010 13:34, Simon Josefsson si...@josefsson.org wrote: Reuben Thomas r...@sc3d.org writes: Are the mentions of GSS in the section Out of memory handling bogus cut-and-paste-o's or similar? A bit of googling suggests that the text has

Re: On OpenBSD and if_freenameindex(3).

2010-09-21 Thread Simon Josefsson
Eric Blake ebl...@redhat.com writes: On 09/21/2010 06:22 AM, Simon Josefsson wrote: As an initial response to this problem, I'm installing a self check of the net/if.h interface. See below. Mats, if you could quote the compiler errors you get when building the self-check below on OpenBSD

Re: On OpenBSD and if_freenameindex(3).

2010-09-21 Thread Simon Josefsson
Mats Erik Andersson mats.anders...@gisladisker.se writes: My protocol report_for_test_net_if.txt is attached. I am not able to compile the test into any working executable for OpenBSD 4.6. The mishaps are due to if_freenameindex. Thanks, this is very useful. Is there a if_freenameindex

Re: On OpenBSD and if_freenameindex(3).

2010-09-21 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Mats Erik Andersson wrote: In OpenBSD (definitely in 4.6) there is a POSIX violation, quoting Simon here, since the header file states ### /usr/include/net/if.h #define if_freenameindex(x) free(x) This macro causes difficulties ...

Re: Mentions of GSS in gnulib.texi

2010-09-21 Thread Simon Josefsson
Reuben Thomas r...@sc3d.org writes: On 21 September 2010 14:59, Simon Josefsson si...@josefsson.org wrote: The intent was to document how the xalloc-die module is used by many other modules in gnulib to handle out of memory conditions.  Maybe you are right and it is no longer useful to have

Re: module request: sockets.m4

2010-09-02 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Sam, Simon, Sam Steingold wrote: Ok, so please do create a module and guarantee the stability. :-) This wish makes sense: We have a module 'threadlib' which only determines how to link with the thread library, without providing any replacements. I can

Re: propose renaming gnulib memxfrm to amemxfrm (naming collision with coreutils)

2010-08-08 Thread Simon Josefsson
Paul Eggert egg...@cs.ucla.edu writes: On 08/06/10 01:22, Paolo Bonzini wrote: ISAAC is a RNG, so wouldn't that have the same problem above? You definitely need to use a hash function, it's just that you do not need a cryptographic one. I had been thinking of using ISAAC by making the key

Re: propose renaming gnulib memxfrm to amemxfrm (naming collision with coreutils)

2010-08-04 Thread Simon Josefsson
Paul Eggert egg...@cs.ucla.edu writes: Come to think of it, looking at gnulib memxfrm gave me an idea to improve the performance of GNU sort by bypassing the need for an memxfrm-like function entirely. I pushed a patch to do that at

Re: gnulib and static libraries

2010-07-11 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, In this case, GnuTLS uses the read-file module from gnulib, and it ends up being exported in a static GnuTLS library. GNU Wget also has a function called read_file, and things break when linking. ... I have some vague memory that this has

gnulib and static libraries

2010-07-09 Thread Simon Josefsson
A problem that have been (I believe) ignored for a long time is how to handle namespace when using gnulib in project that provides static libraries. Here is an example of where this causes problems: http://lists.gnu.org/archive/html/bug-wget/2010-07/msg00010.html

Re: [PATCH] unistr/u8-strchr: speed up searching for ASCII characters

2010-07-07 Thread Simon Josefsson
Pádraig Brady p...@draigbrady.com writes: +/* The following is equivalent to: + return memmem (s, strlen(s), c, csize); + but faster for long S with matching UC near the start, + and also memmem is sometimes buggy and inefficient. */ switch (u8_uctomb_aux (c,

Re: git-changelog package?

2010-05-24 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon and Jim, When I look at https://git.wiki.kernel.org/index.php/Interfaces,_frontends,_and_tools, searching for the word changelog, I see that there are three tools from GNU people for dealing with the ChangeLog file format that is part of GNU

Re: valgrind-tests.m4

2010-05-20 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: The approach I use in GNU gettext is similar: Makefile.am has this: # For debugging memory leaks and memory allocation bugs. # You should build with --disable-shared when using valgrind. CHECKER = #CHECKER = valgrind --tool=memcheck

Re: valgrind-tests.m4

2010-05-20 Thread Simon Josefsson
I pushed a small followup-patch to make things work. /Simon From 5c9bee128e78e2513fef8955c4c0cd27fcff4c54 Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Thu, 20 May 2010 08:37:18 +0200 Subject: [PATCH] modules/valgrind-tests (configure.ac): Invoke gl_VALGRIND_TESTS

Re: valgrind-tests.m4

2010-05-20 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: Hi Simon, I like this patch, with one small nit: * Simon Josefsson wrote on Wed, May 19, 2010 at 08:41:29AM CEST: +This will run all self-checks under valgrind. This can be wasteful if +you have many shell scripts or other non-binaries

Re: valgrind-tests.m4

2010-05-19 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: * Simon Josefsson wrote on Tue, May 18, 2010 at 09:36:44AM CEST: Ralf Wildenhues writes: Well, one could prepend LOG_COMPILER (the default variable that doesn't go with any specified extension) or have the developer specify some other

Re: valgrind-tests.m4

2010-05-18 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: With Automake 1.11's parallel-tests option, you have the possibility to specify per-extension compilers for tests. Example: # .sh and .pl files are processed to .log files. TEST_EXTENSIONS = .sh .pl SH_LOG_COMPILER = bash -vx

Re: valgrind-tests.m4

2010-05-18 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Ralf Wildenhues wrote: However, in general, tests might be executable programs, or they might be shell or other scripts. In the latter cases, putting valgrind in TESTS_ENVIRONMENT would be at least a waste (you don't want to check bash or perl).

Re: valgrind-tests.m4

2010-05-18 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: The approach I use in GNU gettext is similar: Makefile.am has this: # For debugging memory leaks and memory allocation bugs. # You should build with --disable-shared when using valgrind. CHECKER = #CHECKER = valgrind --tool=memcheck

Re: pwrite module

2010-05-18 Thread Simon Josefsson
The pwrite self-test fails under Cygwin, is this a known issue? http://autobuild.josefsson.org/gnulib/log-201005172227940062000.txt /Simon

valgrind-tests.m4

2010-05-17 Thread Simon Josefsson
I'm running self-tests under valgrind in several projects, and it seems like a general useful thing, so how about putting the macro for this in gnulib? /Simon From 1ec8622b3a4efed0ebaaa4eb19d440fab1708b4e Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Mon, 17 May 2010

Re: valgrind-tests.m4

2010-05-17 Thread Simon Josefsson
Ben Pfaff b...@cs.stanford.edu writes: Simon Josefsson si...@josefsson.org writes: I'm running self-tests under valgrind in several projects, and it seems like a general useful thing, so how about putting the macro for this in gnulib? It looks like this implementation requires rerunning

Re: valgrind-tests.m4

2010-05-17 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: Hi Simon, * Simon Josefsson wrote on Mon, May 17, 2010 at 12:15:51PM CEST: I'm running self-tests under valgrind in several projects, and it seems like a general useful thing, so how about putting the macro for this in gnulib? Nice idea

Re: valgrind-tests.m4

2010-05-17 Thread Simon Josefsson
Ben Pfaff b...@cs.stanford.edu writes: Simon Josefsson si...@josefsson.org writes: Ben Pfaff b...@cs.stanford.edu writes: Simon Josefsson si...@josefsson.org writes: I'm running self-tests under valgrind in several projects, and it seems like a general useful thing, so how about putting

Re: test results on Cygwin

2010-05-03 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Simon Josefsson wrote: Thanks, it should likely solve the problem too -- I'm running a Windows cygwin build to test it now. Yep: http://autobuild.josefsson.org/gnulib/log-20100425225612508.txt ... There is a bunch of printf-failures

Re: test results on Cygwin

2010-05-03 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org writes: I'm running another build now. We are down to two failed self-tests under cygwin, see: http://autobuild.josefsson.org/gnulib/log-201005030918958478000.txt The failures are: file_has_acl(tmpdir0) returned yes, expected no FAIL: test-file-has-acl.sh

[PATCH] top/maint.mk (indent): Run twice to produce idempotent results.

2010-04-29 Thread Simon Josefsson
anyway). /Simon --- ChangeLog|4 top/maint.mk |2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 65d06ef..db345d4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,7 @@ +2010-04-29 Simon Josefsson si...@josefsson.org

Re: replacement header licenses

2010-04-28 Thread Simon Josefsson
Eric Blake ebl...@redhat.com writes: The following replacement headers are all under LGPL instead of LGPLv2+ licensing. Any objection to relaxing them, so that projects like libvirt can use all the replacement headers for things like GNULIB_POSIXCHECK or passing Jim's recent maint.mk syntax

Re: [PATCH 3/4] Avoid a stupid 'const object should have initializer' warning

2010-04-28 Thread Simon Josefsson
Eric Blake ebl...@redhat.com writes: On 04/27/2010 03:24 PM, Andreas Gruenbacher wrote: * lib/getdate.y (RELATIVE_TIME_0): Avoid a stupid 'const object should have initializer' warning. @@ -152,7 +152,7 @@ typedef struct #if HAVE_COMPOUND_LITERALS # define RELATIVE_TIME_0

Re: testdir without unportable tests?

2010-04-26 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org writes: Bruno Haible br...@clisp.org writes: I'm applying these two patches. Thanks, it should likely solve the problem too -- I'm running a Windows cygwin build to test it now. Yep: http://autobuild.josefsson.org/gnulib/log-20100425225612508.txt

Re: netdb.h, getaddrinfo

2010-04-26 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, A week ago I proposed: I propose to generate netdb.h always, like we do with stdlib.h and unistd.h for 3 years and for many others for 2 months. Then we can also add GNULIB_POSIXCHECK advice to netdb.h. Here's the second part: The patch to

error: '::calloc' has not been declared

2010-04-26 Thread Simon Josefsson
Note: this is another low-priority issue that doesn't cause any immediate real problem except that it breaks snapshot building. There is an error building test-stdlib-c++2 on Mac OS X 10.4.11: http://autobuild.josefsson.org/gnulib/log-20100425095093069.txt depbase=`echo test-stdlib-c++2.o |

Re: ttyname_r on Mac

2010-04-26 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: So it seems ttyname_r on older Mac OS X versions returned char*. Yes. The attached patch fixes it for Solaris 10 and - presumably - also on the MacOS X 10.4 that you are using. It appears to work, the test-fcntl-h-c++ test builds OK in:

Re: test-string-c++.o:(.data+0x0): undefined reference to `rpl_memchr'

2010-04-25 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Simon Josefsson wrote: Adding AC_PROG_CXX to gltests/configure.ac solves the problem. I see that ansi-c++-opt.m4 may be attempting to do setup a C++ compiler, but it doesn't seem to work when cross-compiling. Well spotted! This should fix it: It works

Re: portable openpty, forkpty

2010-04-25 Thread Simon Josefsson
. You should have received a copy of the GNU General Public License along with this program. If not, see http://www.gnu.org/licenses/. */ /* Written by Simon Josefsson si...@josefsson.org, 2009 and Bruno Haible br...@clisp.org, 2010. */ #include util.h #include stdio.h #include string.h

Re: portable openpty, forkpty

2010-04-25 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: I'm committing this, clarifying that the master file descriptor needs to be closed before the slave file descriptor: Thanks. I may get access to a newer Mac relatively soon, and I'll test it on that machine as well. /Simon

ttyname_r on Mac

2010-04-25 Thread Simon Josefsson
Note: this problem doesn't cause my any immediate problem, but it breaks the daily build on Mac. I don't think it is important to work on fixing this, but someone finds it interesting. There appears to be a ttyname_r signature bug, see:

Re: testdir without unportable tests?

2010-04-25 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: I'm applying these two patches. Thanks, it should likely solve the problem too -- I'm running a Windows cygwin build to test it now. /Simon

Re: test-string-c++.o:(.data+0x0): undefined reference to `rpl_memchr'

2010-04-23 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: g++ -o test-string-c++.exe test-string-c++.o test-string-c++2.o ../gllib/libgnu.a test-string-c++.o:(.data+0x0): undefined reference to `rpl_memchr' Why is CXX=g++ being used when you are cross-compiling from linux to mingw?? Ah, that's the

in-memory representation of NULL pointers?

2010-04-23 Thread Simon Josefsson
Not gnulib specific, but related to our coding style: Does POSIX somewhere guarantee that the in-memory representation of NULL pointers is 0? I know that C89 doesn't make that guarantee, and that some historic systems used non-0 memory values to represent NULL, but I'm hoping that this is not

Re: in-memory representation of NULL pointers?

2010-04-23 Thread Simon Josefsson
Eric Blake ebl...@redhat.com writes: On 04/23/2010 11:27 AM, Simon Josefsson wrote: Not gnulib specific, but related to our coding style: Does POSIX somewhere guarantee that the in-memory representation of NULL pointers is 0? I know that C89 doesn't make that guarantee, and that some

Re: test-string-c++.o:(.data+0x0): undefined reference to `rpl_memchr'

2010-04-22 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Can you show the result of 'grep MEMCHR config.status' and the relevant portion of gllib/string.h ? S[REPLACE_MEMCHR]=1 S[HAVE_RAWMEMCHR]=1 S[HAVE_MEMCHR]=1 S[GNULIB_RAWMEMCHR]=0 S[GNULIB_MEMCHR]=1 D[HAVE_MEMCHR]= 1 D[GNULIB_TEST_MEMCHR]= 1 See

Re: strnlen on OSX C++

2010-04-22 Thread Simon Josefsson
Jarno Rajahalme jarno.rajaha...@nsn.com writes: Bruno, I have those patches applied (and a up-to-date gnulib, as git diff shows nothing), but now get a different compilation error: In file included from main.cc:4: ../lib/string.h:684: error: 'strnlen' was not declared in this scope

<    1   2   3   4   5   6   7   8   9   10   >