error: conflicting types for ‘rpl_gethostname ’

2010-01-12 Thread Simon Josefsson
Here is an interesting problem. This command j...@mocca:~/src/gnulib master$ rm -rf m gnulib-tool --create-testdir --dir m getsubopt gethostname cd m ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu make check results in this error: i586-mingw32msvc-gcc -DHAVE_CONFIG_H -I.

Re: Cygwin build report on Windows XP

2010-01-12 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, The tests that failed were: file_has_acl(tmpdir0) returned yes, expected no FAIL: test-file-has-acl.sh This is normal and expected. In Cygwin 1.5.x, setacl and chown don't harmonize: if a program calls setacl after chown, the permissions

Re: another dup2 mingw failure

2010-01-11 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 1/9/2010 4:06 AM: There is another dup2 failure due to Wine, see: http://bugs.winehq.org/show_bug.cgi?id=21291 The patch below works around it. Thoughts? Hmm. Repeatedly adding workarounds for wine bugs seems awkward

Re: open MinGW failure

2010-01-11 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: The relevant code is: /* Cannot create directory. */ errno = 0; ASSERT (func (nonexist.ent/, O_CREAT | O_RDONLY, 0600) == -1); Open returns 3 for me, and it has created a file 'nonexist.ent'. This must be a bug in Wine, then. Please report

Re: open MinGW failure

2010-01-11 Thread Simon Josefsson
Paolo Bonzini bonz...@gnu.org writes: On 01/09/2010 12:33 PM, Bruno Haible wrote: Hmm, you and Paolo explained to me on 2009-08-21 that Wine should be considered as a platform of its own. But I still don't fully agree. Can you first report the bug to the Wine people and come back to patching

another dup2 mingw failure

2010-01-09 Thread Simon Josefsson
There is another dup2 failure due to Wine, see: http://bugs.winehq.org/show_bug.cgi?id=21291 The patch below works around it. Thoughts? /Simon 2010-01-09 Simon Josefsson si...@josefsson.org * lib/dup2.c (rpl_dup2): Restore text mode when needed, to work around Wine bug

Re: open MinGW failure

2010-01-09 Thread Simon Josefsson
This problem was also caused by Wine, and not visible under Windows XP. See http://bugs.winehq.org/show_bug.cgi?id=21292 My old patch fixes the problem under Wine, but this updated patch adds a comment explaining. Ok to push? /Simon diff --git a/m4/open.m4 b/m4/open.m4 index d705b3a..bc04613

dup2 mingw failure

2010-01-08 Thread Simon Josefsson
I got this on MinGW: test-dup2.c:140: assertion failed FAIL: test-dup2.exe The relevant code is: /* The destination must be valid. */ errno = 0; ASSERT (dup2 (fd, -2) == -1); Debugging this, it seems MinGW dup2 returns -2 in this situation. Any ideas? Is -2 a valid file descriptor on

open MinGW failure

2010-01-08 Thread Simon Josefsson
I got this when cross-compiling to MinGW with Wine: test-open.h:34: assertion failed FAIL: test-open.exe The relevant code is: /* Cannot create directory. */ errno = 0; ASSERT (func (nonexist.ent/, O_CREAT | O_RDONLY, 0600) == -1); Open returns 3 for me, and it has created a file

Re: dup2 mingw failure

2010-01-08 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 1/8/2010 2:36 AM: I got this on MinGW: test-dup2.c:140: assertion failed FAIL: test-dup2.exe I wish mingw had a better version number reporting scheme. I can't reproduce the failure when I cross-compile from cygwin to mingw

Re: [PATCH] fix build failure with getline.c

2010-01-02 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Robert Millan on 1/1/2010 4:24 PM: Aren't you using the gnulib stdio module, or is the code not working somehow? So no, the stdio module wasn't being included. Maybe you want to consider removing this dependency, I think other projects could be

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Robert Millan on 1/1/2010 5:56 AM: When importing getline.c into GNU GRUB, it failed to build due to undefined ssize_t. Here's a fix (I believe including sys/types.h is portable enough, please let me know if I'm wrong). Hmm. The prototype for

Re: [PATCH] fix build failure with getline.c

2010-01-01 Thread Simon Josefsson
Robert Millan r...@aybabtu.com writes: When importing getline.c into GNU GRUB, it failed to build due to undefined ssize_t. Here's a fix (I believe including sys/types.h is portable enough, please let me know if I'm wrong). I don't your this patch is the right solution -- the gnulib getline

Re: test-localename crash

2009-12-31 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, Simon Josefsson wrote: The test-localename test crashes for me: #0 strcmp () at ../sysdeps/i386/i686/strcmp.S:39 #1 0x08049840 in test_locale_name_thread () at test-localename.c:421 Debugging it shows that the variables passed to strcmp

Re: test-symlink failure on MinGW

2009-12-29 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 12/28/2009 11:51 PM: This patch looks a bit cleaner, it moves the system call into the function actually responsible for creating the same files. And it also fixes lstat self-tests. On the one hand, you are correct

Re: licenses of tests

2009-12-29 Thread Simon Josefsson
Eric Blake e...@byu.net writes: I noticed several of my recently written tests suffered from a copy-and-paste license error (they stated GPLv2+, even though unit tests are generally v3+ because they are not linked into the final product). Here are the remaining files that suffer from the

test-localename mingw failure?

2009-12-29 Thread Simon Josefsson
This rm -rf m ./gnulib-tool --create-testdir --dir m --with-tests localename; cd m ./configure --host=i586-mingw32msvc --build=i686-pc-linux-gnu make check yields i586-mingw32msvc-gcc -DHAVE_CONFIG_H -I. -I. -I. -I.. -I./.. -I../gllib -I./../gllib -g -O2 -MT test-localename.o -MD -MP

test-localename crash

2009-12-29 Thread Simon Josefsson
The test-localename test crashes for me: /bin/sh: line 5: 15913 Segmentation fault ${dir}$tst FAIL: test-localename Gdb says: (gdb) r Starting program: /home/jas/src/gnulib/m/gltests/test-localename Program received signal SIGSEGV, Segmentation fault. strcmp () at

Re: lib/regex_internal.h uses #if _LIBC instead of #if defined (_LIBC)

2009-12-29 Thread Simon Josefsson
Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com writes: === modified file 'gnulib/regex_internal.h' --- gnulib/regex_internal.h2009-12-27 15:37:18 + +++ gnulib/regex_internal.h2009-12-29 22:32:31 + @@ -58,7 +58,7 @@ # define SIZE_MAX ((size_t) -1) #endif -#if

Re: test-symlink failure on MinGW

2009-12-28 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 12/27/2009 3:06 AM: I got this error when cross-compiling to MinGW: ../../../src/libidn-1.16/gltests/test-symlink.c:43: assertion failed FAIL: test-symlink.exe The reason is use of a system call. I changed it into a shell

Re: test-symlink failure on MinGW

2009-12-28 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org + + * tests/test-areadlink.h (test_areadlink): Call rm here, without + ASSERT. + * tests/test-symlink.h (test_symlink): Likewise. + * tests/test-lstat.h (test_lstat_func): Don't ASSERT rm call. + * tests/test-areadlink-with-size.c

Re: new module 'unused-parameter'

2009-12-28 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org writes: Bruno Haible br...@clisp.org writes: Hi Jim, Eric wrote: Also, se-context.in.h and se-selinux.in.h would benefit from an unused-parameter module. Here's a proposed patch to make the generated selinux/selinux.h and selinux/context.h files

test-symlink failure on MinGW

2009-12-27 Thread Simon Josefsson
Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Sun, 27 Dec 2009 11:05:50 +0100 Subject: [PATCH] test-symlink: Don't use system. --- ChangeLog |7 +++ modules/symlink-tests |4 +++- tests/test-symlink.c |3 --- tests/test-symlink.sh |6

Re: new module 'unused-parameter'

2009-12-27 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Jim, Eric wrote: Also, se-context.in.h and se-selinux.in.h would benefit from an unused-parameter module. Here's a proposed patch to make the generated selinux/selinux.h and selinux/context.h files independent of the stuff defined in config.h. I

Re: _GL_ARG_NONNULL

2009-12-16 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, The cause seems to be a un-expanded _GL_ARG_NONNULL: j...@mocca:~/gnutls4win$ grep 'NONNULL is copied' build/libidn-1.16/gltests/stdlib.h /* The definition of _GL_ARG_NONNULL is copied here. */ _GL_ARG_NONNULL should be defined in the

Re: _GL_ARG_NONNULL

2009-12-16 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Simon Josefsson wrote: If not, then take a look at gltests/Makefile. It should define ARG_NONNULL_H. No, there is stdlib.h: stdlib.in.h $(LINK_WARNING_H) $(ARG_NONNULL_H) but ARG_NONNULL_H is never defined in the Makefile. Did you somehow pass

Re: GL_LINK_WARNING

2009-12-15 Thread Simon Josefsson
Eric Blake e...@byu.net writes: Eric Blake ebb9 at byu.net writes: So, what should I do? Options: 1. Check in the patches below as-is 2. Ditch this series, and instead go and change all uses of GNULIB_POSIXCHECK that used #define func(args) (GL_LINK_WARNING(...),func(args)) to

_GL_ARG_NONNULL

2009-12-15 Thread Simon Josefsson
Libidn with recent gnulib fails on mingw: ./stdlib.h: In function 'rpl_putenv': ./stdlib.h:337: error: expected declaration specifiers before '_GL_ARG_NONNULL' The cause seems to be a un-expanded _GL_ARG_NONNULL: j...@mocca:~/gnutls4win$ grep 'NONNULL is copied'

Re: untabify - last call for objections

2009-12-10 Thread Simon Josefsson
Is there a need to modify how 'indent' works here? Or document how to make indent do the right thing? When making substantial changes to gnulib code, I tend to run 'indent' on the code to make sure I'm following the right style -- but that would add tabs, wouldn't it? /Simon

Re: pty.h replacement

2009-12-10 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org writes: Subject: [PATCH] Add pty module for forkpty and openpty. I have pushed that patch -- it added a new module, so it should have minimal impact on existing code. If there is any problem with it, we'll find out when InetUtils starts to use it. /Simon

Re: untabify - last call for objections

2009-12-10 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Simon Josefsson wrote: Is there a need to modify how 'indent' works here? Or document how to make indent do the right thing? When making substantial changes to gnulib code, I tend to run 'indent' on the code to make sure I'm following the right style

Re: [PATCH] non-null declarations

2009-12-10 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Opinions? Objections? Looks fine to me. I didn't test it, but obviously I'll report back if it breaks anything. /Simon

Re: untabify, coding standards

2009-12-10 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Simon Josefsson wrote: Is this style something we want to try push into the GNU Coding Standard and/or into the GNU indent default? I don't care much about coding styles conventions, but I care about consistency. Moving away from the default style

Re: untabify - last call for objections

2009-12-10 Thread Simon Josefsson
Pádraig Brady p...@draigbrady.com writes: I don't care much about coding styles conventions, but I care about consistency. Moving away from the default style of GNU indent in gnulib seems a bit inconsistent to me. I can't find anything about tab vs space in the coding standard though.

Re: pty.h replacement

2009-12-10 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: The reason is that libgnu.a is not being included in the link line. This fixes it: Thanks. Strange that it didn't happen on my system. /Simon

iruserok

2009-12-09 Thread Simon Josefsson
InetUtils rshd failed to build on Mac OS X for another reason: rshd.c:178: error: conflicting types for 'iruserok' /usr/include/unistd.h:514: error: previous declaration of 'iruserok' was here The rshd.c line 178 is: extern int iruserok (uint32_t raddr, int superuser, const

Re: iruserok

2009-12-09 Thread Simon Josefsson
FYI, the glibc bug for this is: http://sources.redhat.com/bugzilla/show_bug.cgi?id=11070 /Simon

Re: add license to link-warning.h

2009-12-09 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: I'm applying this: Thanks! Jim's change looks fine too. /Simon

Re: pty.h replacement

2009-12-08 Thread Simon Josefsson
consuming for me. Of course, if someone else wants to work on the additional step, it would be great. I think things will be simpler if we start with just handling the header/library issue though. /Simon From 20378b72d283e0ad87da78a24976a64faeb3b9ae Mon Sep 17 00:00:00 2001 From: Simon Josefsson si

Re: pty.h replacement

2009-12-08 Thread Simon Josefsson
, but I'd like to push the patch below first so that Mac OS X works. +2009-12-07 Simon Josefsson si...@josefsson.org + +* modules/pty: New file. +* modules/pty-tests: New file. +* doc/glibc-headers/pty.texi: New file. Your patch modifies pty.texi; it doesn't create it. Fixed below

add license to link-warning.h

2009-12-08 Thread Simon Josefsson
because it is in build-aux/ rather than lib/). /Simon From 4a9985002d673a4984b5fb33c9d757b4d6765365 Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Tue, 8 Dec 2009 22:14:21 +0100 Subject: [PATCH] build-aux/link-warning.h: Add license header. --- ChangeLog

Re: Build failure on Darwin

2009-12-07 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org writes: l...@gnu.org (Ludovic Courtès) writes: Hello, Current Git fails to build on Darwin: http://hydra.nixos.org/build/175517/log/raw I haven’t investigated any further, though. Darwin has forkpty in util.h instead of the glibc name of pty.h

Re: [bug-libunistring] ‘test-xalloc-die’ failure

2009-11-27 Thread Simon Josefsson
Jim Meyering j...@meyering.net writes: Simon, here's a proposed fix: It passes my simple test of running like this (no libtool, though): ./gnulib-tool --create-testdir --with-tests --test xalloc-die Ok to push? I see no problem with it, please push! /Simon

Re: [PATCH 2/2] test pread (using the new init.sh framework)

2009-11-27 Thread Simon Josefsson
Jim, there seems to be some PATH issue causing build failures: ../../gltests/test-pread.sh: 6: test-pread: not found FAIL: test-pread.sh See: http://autobuild.josefsson.org/gnulib/log-200911270751109732000.txt /Simon

Re: symbols x platforms matrix

2009-11-26 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Hi Simon, The question which platforms support a given interface? is, I think, best answered by the symbols x platforms matrix that I'm maintaining at http://www.haible.de/bruno/gnu/various-symlists.tar.gz Ah, that is probably more reliable. How

Re: doc update

2009-11-25 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: This doc update considers that MacOS X 10.5 has most of the *_l functions that take a locale_t argument. ... -This function is missing on all non-glibc platforms: +This function is missing on many platforms: MacOS X 10.3, FreeBSD 6.0, NetBSD 3.0, OpenBSD

Re: doc update

2009-11-25 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Simon Josefsson wrote: That is a bit open-ended, isn't it? Well, the list of remaining files with this wording is not too long. And we will certainly be interested to know when some other platforms implements the same function, because that means

Re: doc update

2009-11-25 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 11/25/2009 2:43 AM: Bruno Haible br...@clisp.org writes: This doc update considers that MacOS X 10.5 has most of the *_l functions that take a locale_t argument. ... -This function is missing on all non-glibc platforms

Re: doc update

2009-11-25 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org writes: I'm thinking of patches like this: That patch was against an old gnulib, this is what I am really thinking of: diff --git a/doc/glibc-functions/strtof_l.texi b/doc/glibc-functions/strtof_l.texi index 00e74c4..dab09a0 100644 --- a/doc/glibc-functions

Re: doc update

2009-11-25 Thread Simon Josefsson
Eric Blake e...@byu.net writes: Simon Josefsson simon at josefsson.org writes: My patch didn't illustrate my point correctly: my point was that, according to Bruno (and my checks), we do know that at least Mac OS X 10.5 implements the *_l functions, so arguable our documentation should

Re: doc update

2009-11-25 Thread Simon Josefsson
Ben Pfaff b...@cs.stanford.edu writes: Simon Josefsson si...@josefsson.org writes: --- a/doc/glibc-functions/strtof_l.texi +++ b/doc/glibc-functions/strtof_l.texi @@ -11,6 +11,9 @@ Portability problems fixed by Gnulib: Portability problems not fixed by Gnulib: @itemize @item

Re: doc update

2009-11-25 Thread Simon Josefsson
Eric Blake e...@byu.net writes: Simon Josefsson simon at josefsson.org writes: Personally, I think that if glibc, Mac OS X, cygwin and maybe Solaris Any of the BSDs? For example, FreeBSD is finally starting to provide all of the POSIX *at interfaces, even faster than Solaris (even though

Re: doc update

2009-11-25 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Simon Josefsson wrote: The problem with this approach is that people will have only negative information to decide when it would make sense to use a gnulib-replacement module for a function, to deal with the platform that doesn't yet implement

Re: xalloc-die-tests

2009-11-17 Thread Simon Josefsson
Thanks Eric and Jim. One though on the changes is that if we use a shell script to wrap running the binary, we'd might as well make the shell script check that the xalloc-die binary returns a non-0 exit code and drop the XFAIL_TESTS approach for the module. But I don't care strongly about it.

Re: xalloc-die-tests

2009-11-17 Thread Simon Josefsson
Simon Josefsson si...@josefsson.org writes: One though on the changes is that if we use a shell script to wrap running the binary, we'd might as well make the shell script check that the xalloc-die binary returns a non-0 exit code and drop the XFAIL_TESTS approach for the module. But I don't

the _t suffix

2009-11-17 Thread Simon Josefsson
I've seen some people suggest that POSIX reserves the _t suffix namespace for its own variables. Is this true? If so, is there any need to worry about gnulib? There are several gnulib modules that declares types with the _t suffix. I've found this link but it is not really clear to me that it

test-xalloc-die buglet

2009-11-17 Thread Simon Josefsson
I noticed an EOL problem on mingw and pushed the fix below. /Simon From 3e00f5fce5b904dc642aff88abbcf75867263e0a Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Tue, 17 Nov 2009 19:58:12 +0100 Subject: [PATCH] tests/test-xalloc-die.sh: Deal with EOL differences, and more

Re: [PATCH] Add ‘gnulib-tool’ support for LGPLv3+

2009-11-17 Thread Simon Josefsson
l...@gnu.org (Ludovic Courtès) writes: Hello, The attached patch fixes LGPLv3+ support in ‘gnulib-tool’. Hi! Pushed, thanks. /Simon

Re: RFC comments in lib / gc-pbkdf2-sha1.c

2009-11-15 Thread Simon Josefsson
is there are any licencing problem with this file? Thanks for the report, I rewrote the comments to not use copyrighted words from elsewhere. /Simon From 24a6641b053b7fc8bf13b4149722e85d77db9920 Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Sun, 15 Nov 2009 13:52:55 +0100 Subject

xalloc-die-tests

2009-11-15 Thread Simon Josefsson
Pushed. /Simon From a31c6b23b94970756cf070ab279bb6e5e6af0156 Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Sun, 15 Nov 2009 17:20:06 +0100 Subject: [PATCH] Add xalloc-die self-test. --- ChangeLog|7 +++ gnulib-tool |1

Re: code coverage report for gnulib

2009-11-14 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: Hi Simon, * Simon Josefsson wrote on Fri, Nov 13, 2009 at 10:41:20AM CET: I prepared a code coverage report for gnulib: http://www.gnu.org/software/gnulib/coverage/ Thank you for doing this! How did you create the report, and was manual

code coverage report for gnulib

2009-11-13 Thread Simon Josefsson
All, I prepared a code coverage report for gnulib: http://www.gnu.org/software/gnulib/coverage/ There is a bug in the tool that results in duplicated */foo/foo directories, but hopefully that will be debugged later on. The output above should be useful to indicate where more self tests are

improved xvasprintf self test

2009-11-13 Thread Simon Josefsson
Inspired by http://www.gnu.org/software/gnulib/coverage/gllib/xvasprintf.c.gcov.frameset.html I improved the xvasprintf self-check below. /Simon From e718463703e9f7a3d60eeb360fca7efb2562c6b2 Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Fri, 13 Nov 2009 10:53:06

Re: improved xvasprintf self test

2009-11-13 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 11/13/2009 2:53 AM: + + result = my_xasprintf (); + ASSERT (result != NULL); + ASSERT (strcmp (result, ) == 0); + Don't forget to free() result between each test, so that we don't keep leaking memory. Thanks, fixed

improve base64 self tests

2009-11-13 Thread Simon Josefsson
Inspired by http://www.gnu.org/software/gnulib/coverage/gllib/base64.c.gcov.frameset.html I improved the self-tests for the base64 module. Pushed. /Simon From d1d75d5540bf75df8bc41c85b5a9fd111ca1f2dd Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Fri, 13 Nov 2009 14

Re: improve base64 self tests

2009-11-13 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 11/13/2009 6:27 AM: +++ b/tests/test-base64.c @@ -20,10 +20,25 @@ #include stddef.h #include stdio.h #include stdbool.h +#include stdlib.h #include string.h +#include string.h That looks redundant. Thanks, fixed

Re: version-etc tweak

2009-11-10 Thread Simon Josefsson
Eric Blake e...@byu.net writes: Back in January, we had a discussion about formatting of --help output. The result was that coreutils changed to a new style. It has now been several months and several releases, with no complaints about the new style. Also, autoconf 2.64 has been

Re: improving manywarnings

2009-11-09 Thread Simon Josefsson
Eric Blake e...@byu.net writes: I'm considering using manywarnings in m4, and noticed that newer gcc supports even more warnings. I noticed several warnings supported by gcc 4.3.4 --help=warnings that were not listed already; see the patch below. However, looking at it closer, it is obvious

Re: Problem with linking when compiling GNUTLS

2009-11-06 Thread Simon Josefsson
:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Fri, 6 Nov 2009 10:01:57 +0100 Subject: [PATCH] modules/select-tests (test_select_LDADD): Add $(INET_PTON_LIB). --- ChangeLog|5 + modules/select-tests |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff

Re: getaddrinfo needs $(INET_NTOP_LIB)

2009-11-05 Thread Simon Josefsson
Eric Blake e...@byu.net writes: Simon Josefsson simon at josefsson.org writes: Wouldn't it be nicer to rewrite the getaddrinfo.m4 to guarantee that $(GETADDRINFO_LIB) contains the contents of $(INET_NTOP_LIB), so that there is only one link line? Hm, good point. How about this? Yes

Re: Explicit interpreter paths considered harmful

2009-11-02 Thread Simon Josefsson
l...@gnu.org (Ludovic Courtès) writes: diff --git a/build-aux/pmccabe2html b/build-aux/pmccabe2html index 27bb8f3..4fe4c64 100755 --- a/build-aux/pmccabe2html +++ b/build-aux/pmccabe2html @@ -1,4 +1,5 @@ -#!/usr/bin/awk -f +#!/bin/sh +exec awk -f $0 $@ # pmccabe2html - pmccabe to html

Re: test-utimens.h:105: assertion failed

2009-11-02 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 10/30/2009 2:32 AM: A (f)utimens test fail on Ubuntu 8.04 LTS: Thanks for the report. Which kernel and which version of glibc? Is it a machine I might have access to, like the gcc compile farm? Send me your SSH public key

Re: Build + test problems on OpenSolaris (aka Solaris 11)

2009-11-02 Thread Simon Josefsson
dependency /lib/libnsl.so.1) ld: fatal: symbol referencing errors. No output written to ex-serv-export On Mon, 2009-11-02 at 11:40 +0100, Simon Josefsson wrote: When you don't use the workaround, what is the value of LIBSOCKET in doc/examples/Makefile? I think it should contain -lnsl

Re: EAI_NODATA used in test-getaddrinfo.c

2009-11-02 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Jim Meyering wrote: On Freebsd8-rc2 I saw this: test-getaddrinfo.c: In function 'simple': test-getaddrinfo.c:95: error: 'EAI_NODATA' undeclared (first use in this function) lib/netdb.h was not generated. Here's one way to fix it, but I

Re: Build + test problems on OpenSolaris (aka Solaris 11)

2009-11-02 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: How about this patch? Not tested on Solaris systems, but posted for review of my general idea. It's the right approach. But the name of the variable is not well chosen: There are several functions defined in libnsl, therefore several modules may want to

Re: Explicit interpreter paths considered harmful

2009-10-30 Thread Simon Josefsson
l...@gnu.org (Ludovic Courtès) writes: Here's a patch. Likewise, ‘pmccabe2html’ assumes /usr/bin/awk, but I’m not sure what to do here: See the documentation in pmccabe2html -- the recommended way to use the script is already using $(AWK). So I don't think there is any problem, is there?

test-utimens.h:105: assertion failed

2009-10-30 Thread Simon Josefsson
A (f)utimens test fail on Ubuntu 8.04 LTS: ../../gltests/test-utimens.h:105: assertion failed FAIL: test-fdutimensat ../../gltests/test-futimens.h:109: assertion failed FAIL: test-futimens ../../gltests/test-utimens.h:105: assertion failed FAIL: test-utimens Reproduce with: gnulib-tool --test

Re: avoid some warnings in tests

2009-10-23 Thread Simon Josefsson
Eric Blake e...@byu.net writes: In coreutils, I turned on gcc warnings for the gnulib unit tests. This cleans up the modules that are mainly from Jim and myself, and mostly hits places that used 'main ()' or did 'char *foo = str'. Simon and Bruno had the most other tests that used 'main

Re: [PATCH] issue warnings for more missing optional libraries

2009-10-20 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: I like it. Even more I like the configure files that print a summary of the most important decisions or findings at the end of the configuration, thus giving an opportunity to the user to re-configure with different --with or --enable options. (Given the

Re: new snapshot available: coreutils-7.6.63-addb6

2009-10-06 Thread Simon Josefsson
Pádraig Brady p...@draigbrady.com writes: Jim Meyering wrote: Pádraig Brady wrote: Jim Meyering wrote: Eric Blake wrote: According to Pádraig Brady on 10/5/2009 3:53 PM: This is a new test, but FC5 is s old, that I'm not sure it's worth worrying about. March 2006? The failure is

size_max

2009-10-06 Thread Simon Josefsson
62f1470d951412a388560bca7e10b2c99b82224f Mon Sep 17 00:00:00 2001 From: Simon Josefsson si...@josefsson.org Date: Tue, 6 Oct 2009 13:55:18 +0200 Subject: [PATCH] size_max: Drop size_max.h. --- ChangeLog|6 ++ NEWS |3 +++ lib/size_max.h | 31 --- modules

Re: SIZE_MAX

2009-10-06 Thread Simon Josefsson
documentation may help, so I support your patch. /Simon 2009-10-06 Bruno Haible br...@clisp.org * modules/size_max (Description): Discourage its use. Reported by Simon Josefsson. --- modules/size_max.orig 2009-10-06 23:47:04.0 +0200 +++ modules/size_max 2009-10-06

Re: size_max

2009-10-06 Thread Simon Josefsson
the NEWS paragraph): I think this is better, please push. I didn't see any NEWS paragraph though? I think it is useful to have something in NEWS about this, since a header file has been removed. /Simon 2009-10-06 Simon Josefsson si...@josefsson.org Bruno Haible br...@clisp.org

Re: gnulib daily snapshots missing

2009-10-04 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 9/23/2009 12:21 PM: fseek.c:26: error: expected declaration specifiers or '...' before '(' token fseek.c:27: error: conflicting types for 'rpl_fseeko' ./stdio.h:258: error: previous declaration of 'rpl_fseeko' was here I see

Re: config.rpath conflict

2009-10-04 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Simon Josefsson wrote on 2009-08-31: Until then, you have to overwrite autopoint'ed files with copies brought in by gnulib-tool. Is this still the recommended practice for using autopoint and gnulib-tool together? I ran into an issue where

Re: Use $(MKDIR_P) instead of @MKDIR_P@

2009-09-24 Thread Simon Josefsson
Jim Meyering j...@meyering.net writes: Simon Josefsson wrote: Jim Meyering j...@meyering.net writes: autoconf (GNU Autoconf) 2.61 automake (GNU automake) 1.9.6 That is because your version of automake is so old. Use a newer one, if possible, preferably the latest: automake-1.11

Re: Use $(MKDIR_P) instead of @MKDIR_P@

2009-09-23 Thread Simon Josefsson
Thomas Guyot-Sionnest derm...@aei.ca writes: On 31/08/09 09:54 AM, Simon Josefsson wrote: Getting gnulib to build natively on Windows was a bit difficult, make appears to break when trying to CreateProcess on /usr/bin/mkdir which doesn't exist as a binary. How about this patch? It allows

Re: Use $(MKDIR_P) instead of @MKDIR_P@

2009-09-23 Thread Simon Josefsson
Jim Meyering j...@meyering.net writes: autoconf (GNU Autoconf) 2.61 automake (GNU automake) 1.9.6 That is because your version of automake is so old. Use a newer one, if possible, preferably the latest: automake-1.11 Gnulib's DEPENDENCIES says 1.9.6 or later is ok. What features of newer

Re: gnulib daily snapshots missing

2009-09-23 Thread Simon Josefsson
Tom G. Christensen t...@jupiterrise.com writes: For a while now no new snapshots was appearing and now the last remaining ones expired and the directory is empty :( The cause is build failures for gnulib, see: http://autobuild.josefsson.org/gnulib/log-200909231241047502000.txt The end reads:

Re: ./gnulib-tool --create-testdir --dir=./gnulib_build

2009-09-19 Thread Simon Josefsson
emad hajjar alep...@hotmail.com writes: ./gnulib-tool: *** file /root/gnulib/./m4/canonicalize-lgpl.m4 not found ./gnulib-tool: *** Stop. Indeed, the file does not exist but is referenced from relocatable-prog-wrapper: Files: ... m4/canonicalize-lgpl.m4 Bruno, Ben, is this patch the right

Re: module Include: section

2009-09-18 Thread Simon Josefsson
Eric Blake e...@byu.net writes: Eric Blake ebb9 at byu.net writes: Any objections to a patch that normalizes the outliers to drop #include? As in the following? Fine with me -- consistency is good. Is anything actually using the content of the 'Include' statement? /Simon

Re: avoiding obsolete macros like AC_TRY_RUN

2009-09-07 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: Simon Josefsson for m4/gc-camellia.m4 m4/getaddrinfo.m4 m4/getline.m4 m4/readline.m4 m4/select.m4 m4/sockets.m4 m4/socklen.m4 m4/sockpfaf.m4 m4/sysexits.m4 OK to commit? I welcome this change. I have not tested it manually, but please

Re: Use $(MKDIR_P) instead of @MKDIR_P@

2009-09-01 Thread Simon Josefsson
Jim Meyering j...@meyering.net writes: So I'll let Simon push his patch. Done! Thanks for discussion. /Simon

Re: config.rpath conflict

2009-08-31 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: Would this problem go away if gnulib's copy is updated? This problem will only go away when either the integration between gettextize and automake is improved (but this is stalled since apparently currently noone with automake skills seriously wants to

Re: Wine, qemu, emulators

2009-08-31 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: The problem is that if mingw+wine doesn't work for me (as developer) I won't be able to produce Windows package and feel confident that they will work. You can also produce or test the Windows packages on real Windows, to get confidence, no? Of course.

Use $(MKDIR_P) instead of @MKDIR_P@

2009-08-31 Thread Simon Josefsson
Getting gnulib to build natively on Windows was a bit difficult, make appears to break when trying to CreateProcess on /usr/bin/mkdir which doesn't exist as a binary. How about this patch? It allows users to specify the mkdir command when invoking 'make'. The patch seems generally to be the

Re: test-func failure on Solaris

2009-08-27 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: On Solaris/x86, with SunPRO C 5.9, the test-func test fails. The reason is that sizeof __func__ evaluates to 0. The compiler warns about it: test-func.c, line 40: warning: null dimension: sizeof() What to do? m4/func.m4 could defined __func__ to a

Re: pipe-filter self-tests

2009-08-25 Thread Simon Josefsson
Eric Blake e...@byu.net writes: According to Simon Josefsson on 8/24/2009 2:49 PM: Simon Josefsson si...@josefsson.org writes: test-pipe.c:79: assertion failed test-pipe.sh: iteration 4 failed test-pipe.c:79: assertion failed test-pipe.sh: iteration 5 failed test-pipe.c:79: assertion

Re: Wine, qemu, emulators

2009-08-21 Thread Simon Josefsson
Bruno Haible br...@clisp.org writes: I don't think there's much point in spending time on these failures. Ultimately people want to use Win32 binaries on Windows (or possibly ReactOS), but not on Wine. People wanting to execute programs on Linux will use the ELF format compiled programs, not

bashism in _header_without_use?

2009-08-20 Thread Simon Josefsson
Running 'make syntax-check' when /bin/sh is bash works fine, but not when /bin/sh is dash. Reproduce by 'git clone git://git.savannah.gnu.org/gnutls.git cd gnutls make syntax-check'. Any ideas? I worked around the problem and don't have time to look into a proper fix now, but thought I should

<    2   3   4   5   6   7   8   9   10   11   >