Re: Problem with valgrind-tests: relies on bash not causing error

On 5 August 2017 at 19:46, Paul Eggert wrote: > Thanks, I installed the attached somewhat-more-fancier patch; does it work > for you? > ​That works fine; thanks very much. -- https://rrt.sc3d.org

Re: Problem with valgrind-tests: relies on bash not causing error

Thanks, I installed the attached somewhat-more-fancier patch; does it work for you? >From 59c181fa400ead71e9a28e3db9abc107f8fc9ea3 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 5 Aug 2017 11:45:10 -0700 Subject: [PATCH] valgrind-tests: use ls, and cache *

Re: Problem with valgrind-tests: relies on bash not causing error

On 12 April 2017 at 13:36, Reuben Thomas wrote: > The test for whether to use valgrind runs: > > /bin/bash -c 'exit 0' > > This looks pretty harmless; unfortunately, bash itself causes problems: > > $ valgrind -q --error-exitcode=1 --leak-check=full /bin/bash -c 'exit 0' >

Re: Problem with valgrind-tests: relies on bash not causing error

On 04/14/2017 10:56 PM, Marc Nieper-Wißkirchen wrote: > While your proposed solution would work for anyone who is aware of this > problem, it won't work for an unaware user who would simply run ./configure, > wondering why valgrind isn't detected. As it seems > rather involved to resolve the

Re: Problem with valgrind-tests: relies on bash not causing error

Hi Bruno, Hi Reuben, >/The test for whether to use valgrind runs:/ >// >//bin/bash -c 'exit 0'/ >// >/This looks pretty harmless; unfortunately, bash itself causes problems:/ I'd suggest that you change m4/valgrind-tests.m4 to use the AC_CACHE_CHECK macro instead

Re: Problem with valgrind-tests: relies on bash not causing error

On 12 April 2017 at 15:23, Bruno Haible wrote: > Hi Reuben, > > > This is a separate issue, though: the real problem here is that a way is > > needed to run libtool wrappers with libtool > > In GNU gettext, I never succeeded in making valgrind work with the libtool > wrappers;

Re: Problem with valgrind-tests: relies on bash not causing error

Hi Reuben, > This is a separate issue, though: the real problem here is that a way is > needed to run libtool wrappers with libtool In GNU gettext, I never succeeded in making valgrind work with the libtool wrappers; instead I noted # You should build with --disable-shared when using valgrind.

Re: Problem with valgrind-tests: relies on bash not causing error

Hi Reuben, > The test for whether to use valgrind runs: > > /bin/bash -c 'exit 0' > > This looks pretty harmless; unfortunately, bash itself causes problems: I'd suggest that you change m4/valgrind-tests.m4 to use the AC_CACHE_CHECK macro instead of "lone" AC_MSG_CHECKING and AC_MSG_RESULT

Re: Problem with valgrind-tests: relies on bash not causing error

​Having applied the workaround of using "ls" in the configure test, my tests still don't run because the LOG_COMPILER trick suggested in the gnulib manual doesn't take account of libtool wrappers. Net result: valgrind is being called on bash (as it runs the test binary's wrapper script). This is