Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-17 Thread Corinna Vinschen
On Feb 17 09:30, Reuben Thomas wrote: > On Sat, 11 Feb 2023 at 12:40, Corinna Vinschen wrote: > > > On Feb 11 12:29, Reuben Thomas wrote: > > > On Sat, 11 Feb 2023 at 12:06, Corinna Vinschen > > wrote: > > > > > > > > > > > If you're sure that the native recode.dll has been built, is it > >

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-17 Thread Reuben Thomas
On Sat, 11 Feb 2023 at 12:40, Corinna Vinschen wrote: > On Feb 11 12:29, Reuben Thomas wrote: > > On Sat, 11 Feb 2023 at 12:06, Corinna Vinschen > wrote: > > > > > > > > If you're sure that the native recode.dll has been built, is it > possible > > > that it's just not found, because it's not

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-11 Thread Corinna Vinschen
On Feb 11 12:29, Reuben Thomas wrote: > On Sat, 11 Feb 2023 at 12:06, Corinna Vinschen wrote: > > > > > If you're sure that the native recode.dll has been built, is it possible > > that it's just not found, because it's not in Windows' DLL search path? > > > > > Yes, because it was working fine

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-11 Thread Reuben Thomas
On Sat, 11 Feb 2023 at 12:06, Corinna Vinschen wrote: > > If you're sure that the native recode.dll has been built, is it possible > that it's just not found, because it's not in Windows' DLL search path? > > Yes, because it was working fine before, and I've not changed anything about where it

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-11 Thread Corinna Vinschen
On Feb 11 11:36, Reuben Thomas wrote: > On Fri, 10 Feb 2023 at 14:21, Bruno Haible wrote: > > > It complains about the symbols defined in libiconv. This means, you need > > to invoke the Gnulib module 'iconv' and add $(LIBICONV) or $(LTLIBICONV) > > to the LDFLAGS. > > > > Bruno to the rescue

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-11 Thread Reuben Thomas
On Fri, 10 Feb 2023 at 14:21, Bruno Haible wrote: > It complains about the symbols defined in libiconv. This means, you need > to invoke the Gnulib module 'iconv' and add $(LIBICONV) or $(LTLIBICONV) > to the LDFLAGS. > Bruno to the rescue again! Many thanks. Having added the iconv gnulib

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-10 Thread Bruno Haible
Corinna Vinschen wrote: > > In Cygwin projects using libtool, we always have to add -no-undefined > > in LDFLAGS. Likewise for AIX, IIRC. Reuben Thomas wrote: > > Patch is attached. It would be nice if that's ok for inclusion. > > > I did apply this patch, but just noticed that it broke the

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-10 Thread Reuben Thomas
On Tue, 7 Feb 2023 at 15:22, Corinna Vinschen wrote: > In Cygwin projects using libtool, we always have to add -no-undefined > iLDFLAGS. This is some old safe-guard in libtool to remind developers > that when creating Windows DLLs, all external symbols must be resolved. > > Fortunately, libtool

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-07 Thread Corinna Vinschen
Hi Reuben, On Feb 7 14:22, Corinna Vinschen wrote: > On Feb 6 20:50, Reuben Thomas wrote: > > On Mon, 6 Feb 2023 at 20:38, Bruno Haible wrote: > > > > > 1. 'recode' is updated to a current gnulib and publish a corresponding > > > tarball. (Hi Reuben :) ) > > > > > > > I've updated

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-07 Thread Corinna Vinschen
On Feb 6 20:50, Reuben Thomas wrote: > On Mon, 6 Feb 2023 at 20:38, Bruno Haible wrote: > > > 1. 'recode' is updated to a current gnulib and publish a corresponding > > tarball. (Hi Reuben :) ) > > > > I've updated gnulib in recode git; I'd be grateful if I could have a report > that

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-06 Thread Reuben Thomas
On Mon, 6 Feb 2023 at 20:38, Bruno Haible wrote: > 1. 'recode' is updated to a current gnulib and publish a corresponding > tarball. (Hi Reuben :) ) > I've updated gnulib in recode git; I'd be grateful if I could have a report that it's doing what's needed here before I make a release,

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-06 Thread Corinna Vinschen
On Feb 6 21:38, Bruno Haible wrote: > Corinna Vinschen wrote: > > I just ran the setlocale_null-mt-* tests with gnulib from git master > > under Cygwin with my newlib patch, and the tests succeeded. I checked > > that configure is doing the right thing and config.h contains the right > >

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-06 Thread Bruno Haible
Corinna Vinschen wrote: > I just ran the setlocale_null-mt-* tests with gnulib from git master > under Cygwin with my newlib patch, and the tests succeeded. I checked > that configure is doing the right thing and config.h contains the right > settings: > > $ ./configure > [...] > checking

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-06 Thread Corinna Vinschen
On Feb 6 18:37, Bruno Haible wrote: > Corinna Vinschen wrote: > > This patch will be in the next Cygwin release 3.4.6. > > Thanks! > > > I'm just a bit fuzzy what patches will be required for gnulib now... > > With this patch, the setlocale_null lock should be gone in Cygwin >= 3.4.6. > I

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-06 Thread Bruno Haible
Corinna Vinschen wrote: > This patch will be in the next Cygwin release 3.4.6. Thanks! > I'm just a bit fuzzy what patches will be required for gnulib now... With this patch, the setlocale_null lock should be gone in Cygwin >= 3.4.6. I can't really test it, but I hope the patch is correct.

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-06 Thread Bruno Haible
Hi Corinna, Sorry, I wanted to reply sooner. > > May I ask what's the idea to provide a thread-safe setlocale? It was > > never defined as thread-safe and POSIX explicitely mentions that. Any > > application expecting to call setlocale thread-safe is broken by design. The 'recode' package

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-06 Thread Corinna Vinschen
Hi Bruno, On Feb 5 22:22, Corinna Vinschen wrote: > On Feb 5 21:41, Bruno Haible wrote: > > Another option — since we are talking about a single symbol and a single > > platform — would be if the locking for setlocale_null were not necessary > > on Cygwin in the first place. I determined that

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-05 Thread Corinna Vinschen
On Feb 5 21:41, Bruno Haible wrote: > Hi Corinna, > > Thanks for the heads-up and patch. > > > Note that dllimport/dllexport decorations are not at all required on > > Cygwin for quite some time. > > Is this true in all circumstances? I thought that when --disable-auto-import > is in use AND

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-05 Thread Bruno Haible
I wrote: > Then the lock would be necessary. but meant: Then the lock would not be necessary.

Re: [PATCH] Do not decorate symbols as dllexport on Cygwin

2023-02-05 Thread Bruno Haible
Hi Corinna, Thanks for the heads-up and patch. > Note that dllimport/dllexport decorations are not at all required on > Cygwin for quite some time. Is this true in all circumstances? I thought that when --disable-auto-import is in use AND the shared library wants to export variables, dllimport